Re: Website prep work and questions (mainly about the 1.15 release notes)

2022-04-06 Thread Johan Corveleyn
On Wed, Apr 6, 2022 at 1:28 AM Nathan Hartman wrote: > On Tue, Apr 5, 2022 at 7:19 PM Mark Phippard wrote: >> On Tue, Apr 5, 2022 at 4:49 PM Johan Corveleyn wrote: >> > 4. Signature verified OK, but Mark's key not trusted, which, as Nathan >> > also said, is normal because it hasn't been crosse

Re: Pristines-on-demand: authz denied during textbase sync (#4888)

2022-04-06 Thread Julian Foad
> Filed as issue #4888, https://subversion.apache.org/issue/4888 I have just been looking back over this issue. Clearly there is more to it than a quick fix. Summary, based on reviewing the email thread: - FAIL: authz_tests.py 31 remove_access_after_commit - Patched in

Re: Pristines-on-demand: authz denied during textbase sync (#4888)

2022-04-06 Thread Evgeny Kotkov
Julian Foad writes: > I suggest: > > - revert the patch I applied, as it's papering over the problem in an > incomplete way and so possibly causes more confusion than it fixes. > > - leave this issue open and come back to it later; it's an edge case not > part of common work flows. +1. Regards

Re: Pristines-on-demand: authz denied during textbase sync (#4888)

2022-04-06 Thread Julian Foad
Evgeny Kotkov wrote: >> - revert the patch I applied, as it's papering over the problem in an >> incomplete way and so possibly causes more confusion than it fixes. >> >> - leave this issue open and come back to it later; it's an edge case not >> part of common work flows. > > +1. Thanks! Revert

Pristines-on-demand: fix disabled tests (#4891)

2022-04-06 Thread Julian Foad
One of the main things blocking pristines-on-demand now is a few edge case test failures. It would be great if we could get some further eyes on these. On the branch, these failures have been converted to XFAIL by adding '@Wimp' decorators. Some of them seem to fail even when run against the old

Re: Pristines-on-demand: fix disabled tests (#4891)

2022-04-06 Thread Johan Corveleyn
On Wed, Apr 6, 2022 at 4:02 PM Julian Foad wrote: > === Windows-specific issues > > A few of these are Windows-specific. I can't very well investigate those > myself. Who could volunteer to look at those? They are: > > externals_tests.py ... ... ...: > update_modify_file_external(), >

Pristines-on-demand=enabled == format 32?

2022-04-06 Thread Johan Corveleyn
I think this was asked several times before, but I can't find the thread: is the pristines-on-demand behavior still unconditionally tied to format 32? Or is it that format 32 makes it _possible_ to enable pristines-on-demand? I would object to having pristines-on-demand=enabled coupled to simply h

Re: Pristines-on-demand=enabled == format 32?

2022-04-06 Thread Julian Foad
Johan Corveleyn wrote: > I think this was asked several times before, but I can't find the > thread: is the pristines-on-demand behavior still unconditionally tied > to format 32? Or is it that format 32 makes it _possible_ to enable > pristines-on-demand? Currently it's tied to f32, but it's pret

Re: Pristines-on-demand=enabled == format 32?

2022-04-06 Thread Johan Corveleyn
On Wed, Apr 6, 2022 at 4:28 PM Julian Foad wrote: > > Johan Corveleyn wrote: > > I think this was asked several times before, but I can't find the > > thread: is the pristines-on-demand behavior still unconditionally tied > > to format 32? Or is it that format 32 makes it _possible_ to enable > >

Re: Pristines-on-demand: fix disabled tests (#4891)

2022-04-06 Thread Julian Foad
Johan Corveleyn wrote: >> A few of these are Windows-specific. I can't very well investigate those >> myself. Who could volunteer to look at those? They are: >> >> externals_tests.py ... ... ...: >> update_modify_file_external(), >> remap_file_external_with_prop_del(), >> fil

Re: Pristines-on-demand: fix disabled tests (#4891)

2022-04-06 Thread Julian Foad
Today I have done a quick review/fix/postpone cycle on the 'upgrade', 'update', and 'trans' tests. Details in https://subversion.apache.org/issue/4891 . - Julian

Re: Pristines-on-demand: authz denied during textbase sync (#4888)

2022-04-06 Thread Karl Fogel
On 06 Apr 2022, Julian Foad wrote: Evgeny Kotkov wrote: - revert the patch I applied, as it's papering over the problem in an incomplete way and so possibly causes more confusion than it fixes. - leave this issue open and come back to it later; it's an edge case not part of common work flow

Re: Pristines-on-demand: fix disabled tests (#4891)

2022-04-06 Thread Johan Corveleyn
On Wed, Apr 6, 2022 at 5:12 PM Julian Foad wrote: > Johan Corveleyn wrote: > >> A few of these are Windows-specific. I can't very well investigate those > >> myself. Who could volunteer to look at those? They are: > >> > >> externals_tests.py ... ... ...: > >> update_modify_file_external

Re: Pristines-on-demand: fix disabled tests (#4891)

2022-04-06 Thread Jun Omae
On Thu, Apr 7, 2022 at 2:47 PM Johan Corveleyn wrote: > This is in fails.log for that one FAIL: > [[[ > ... > File "C:\Python39\lib\sre_parse.py", line 426, in _escape > raise source.error("bad escape %s" % escape, len(escape)) > re.error: bad escape \c at position 32 (line 1, column 33) > F