Re: A two-part vision for Subversion and large binary objects.

2022-03-11 Thread Daniel Sahlberg
Den tors 10 mars 2022 kl 18:48 skrev Karl Fogel : > On 10 Mar 2022, Lorenz wrote: > >Daniel Sahlberg wrote: > > > >>Den tis 8 mars 2022 kl 14:17 skrev Daniel Shahaf > >>: > >> > >>> An alternative is to require the user to let svn know before > >>> they're > >>> starting to edit a file, so we can

Re: A two-part vision for Subversion and large binary objects.

2022-03-11 Thread Julian Foad
Daniel Sahlberg wrote: > I'm taking an opposite position with regards on where this should be > administred. [...] I would prefer a multi-level approach where the > repository (through svn:foo properties) could suggest pristine-less WC I understand completely your case, but the solution you need i

http URLs should be updated to https

2022-03-11 Thread Vincent Lefevre
When running "svn --help", I get: [...] For additional information, see http://subversion.apache.org/ This URL should be updated to https, and probably other instances in the Subversion source. http://svnbook.red-bean.com is also concerned. Even though the websites automatically redirect to htt

Re: http URLs should be updated to https

2022-03-11 Thread Julian Foad
+1. Can you send a patch? - Julian

Re: A two-part vision for Subversion and large binary objects.

2022-03-11 Thread Daniel Sahlberg
Den fre 11 mars 2022 kl 11:04 skrev Julian Foad : > Daniel Sahlberg wrote: > > I'm taking an opposite position with regards on where this should be > > administred. [...] I would prefer a multi-level approach where the > > repository (through svn:foo properties) could suggest pristine-less WC > >

Re: A two-part vision for Subversion and large binary objects.

2022-03-11 Thread Vincent Lefevre
On 2022-03-11 10:04:36 +, Julian Foad wrote: > Daniel Sahlberg wrote: > > I'm taking an opposite position with regards on where this should be > > administred. [...] I would prefer a multi-level approach where the > > repository (through svn:foo properties) could suggest pristine-less WC > > I

Re: http URLs should be updated to https

2022-03-11 Thread Julian Foad
Julian Foad wrote: > +1. Can you send a patch? By the way, the reason I ask if you would be willing, rather than "just quickly doing it" myself, is even a small "obvious" fix like this tends to require more than it initially looks like: checking if it's already done in head of trunk, finding other

Re: Issue #525/#4892: on only fetching the pristines we really need

2022-03-11 Thread Julian Foad
Thinking about next steps. It seems worth investigating how feasible is making at least "update" hydrate pristines at point-of-use (optimally/minimally). "Restore" is an aberration -- The first thought I had after sending that long post is that the "restore" functionality

Re: http URLs should be updated to https

2022-03-11 Thread Vincent Lefevre
On 2022-03-11 10:29:12 +, Julian Foad wrote: > Julian Foad wrote: > > +1. Can you send a patch? > > By the way, the reason I ask if you would be willing, rather than "just > quickly doing it" myself, is even a small "obvious" fix like this tends > to require more than it initially looks like:

Re: A two-part vision for Subversion and large binary objects.

2022-03-11 Thread Daniel Sahlberg
Den fre 11 mars 2022 kl 11:28 skrev Vincent Lefevre : > On 2022-03-11 10:04:36 +, Julian Foad wrote: > > Daniel Sahlberg wrote: > > > I'm taking an opposite position with regards on where this should be > > > administred. [...] I would prefer a multi-level approach where the > > > repository (

Re: A two-part vision for Subversion and large binary objects.

2022-03-11 Thread Julian Foad
Here is an approach that does *not* satisfy both sides of this argument: [[[ svn propset "svn:no-pristines" "*" doc/ cat >> ~/.subversion/config <<-EOF [auto-props] src/**/*.exe = "svn:no-pristines = *" EOF ]]] and we make standard Subversion control its pristine storage based on looking

Re: A two-part vision for Subversion and large binary objects.

2022-03-11 Thread Mark Phippard
On Fri, Mar 11, 2022 at 5:16 AM Daniel Sahlberg wrote: > > Den fre 11 mars 2022 kl 11:04 skrev Julian Foad : >> >> Daniel Sahlberg wrote: >> > I'm taking an opposite position with regards on where this should be >> > administred. [...] I would prefer a multi-level approach where the >> > repositor

Re: Issue #525/#4892: on only fetching the pristines we really need

2022-03-11 Thread Julian Foad
A quick dive in the "restore" code path led me to: - commit a small refactoring (r1898847 on trunk) to deduplicate the code, which should be useful if we need to do anything like adding callbacks to it; - observe that if we disable "restore", 10 tests fail (4 update tests and 6 others). It ma

Re: A two-part vision for Subversion and large binary objects.

2022-03-11 Thread Daniel Sahlberg
Den fre 11 mars 2022 kl 13:05 skrev Julian Foad : > Here is an approach that does *not* satisfy both sides of this argument: > > [[[ > svn propset "svn:no-pristines" "*" doc/ > > cat >> ~/.subversion/config <<-EOF > [auto-props] > src/**/*.exe = "svn:no-pristines = *" > EOF > ]]] > > and w

Re: Issue #525/#4892: on only fetching the pristines we really need

2022-03-11 Thread Julian Foad
With a dive into the main "update" code, I was able to make "update" fetch pristines at the point of use, and so minimally the ones it really needs... I think. So far I have only got it running with "restore" functionality disabled, and run the test suite. I get the (ten) expected fails from the l

Re: Issue #525/#4892: on only fetching the pristines we really need

2022-03-11 Thread Evgeny Kotkov
Julian Foad writes: > Conclusions: > > > It is certainly possible that we could modify "update" and the other > "online" operations, at least, and the previously "offline" operations > too if we want, to make them fetch pristines at point-of-use in this way. > > Such modifications ar

Re: Issue #525/#4892: on only fetching the pristines we really need

2022-03-11 Thread Mark Phippard
On Fri, Mar 11, 2022 at 10:24 AM Evgeny Kotkov wrote: > > Julian Foad writes: > > > Conclusions: > > > > > > It is certainly possible that we could modify "update" and the other > > "online" operations, at least, and the previously "offline" operations > > too if we want, to make the

Re: Issue #525/#4892: on only fetching the pristines we really need

2022-03-11 Thread Julian Foad
Thank you, Evgeny. That is exactly the kind of discussion we need, and you were able to provide far more detailed insights than I was. That should help us decide how to proceed. As for your thoughts about the current approach for MVP, I tend to agree that your approach is likely to be useful for a

Re: Issue #525/#4892: on only fetching the pristines we really need

2022-03-11 Thread Julian Foad
On Mar 11 2022, at 5:07 pm, Mark Phippard wrote: > On Fri, Mar 11, 2022 at 10:24 AM Evgeny Kotkov > wrote: >> >> Julian Foad writes: >> >> > Conclusions: >> > >> > >> > It is certainly possible that we could modify "update" and the other >> > "online" operations, at least, and

Re: Issue #525/#4892: on only fetching the pristines we really need

2022-03-11 Thread Mark Phippard
On Fri, Mar 11, 2022 at 12:21 PM Julian Foad wrote: > > This is where the question comes in ... why does not having the > > pristines change this? The WC still knows what files it has and what > > revisions. Isn't this what drives the process? I just do not > > understand what has changed that fo

Re: Issue #525/#4892: on only fetching the pristines we really need

2022-03-11 Thread Julian Foad
Mark Phippard wrote: > Is there a way to describe it in a way that a really experienced SVN > "user" not "developer" would understand? Set aside the pristinelsss WC > feature. What is the scenario in previous versions of SVN where this > behavior is kicking in? Hi, Mark. I have been mainly aiming

Re: Issue #525/#4892: on only fetching the pristines we really need

2022-03-11 Thread Nathan Hartman
On Fri, Mar 11, 2022 at 2:36 PM Julian Foad wrote: > The "restore missing files" is an odd thing that "update" does outside > of its core purpose: when any versioned file in its scope is missing > from disk, it puts an unmodified copy of the file back on disk there, by > copying (and translating k