Re: [PATCH] fix C4204 errors while building swig-py with Python 3.9 on Windows

2020-11-16 Thread Branko Čibej
On 16.11.2020 04:16, Jun Omae wrote: Hi, I tried to build swig-py with Python 3.9 on Windows, however get the following errors: [[[ C:\usr\apps\python39\include\cpython\abstract.h(205,1): error C4204: nonstandard extension used: non-constant aggregate initializer [C:\usr\src\subversion\trun

Re: svn commit: r1881534 - /subversion/trunk/build/ac-macros/macosx.m4

2020-11-16 Thread Branko Čibej
On 15.11.2020 19:16, Nathan Hartman wrote: On Sat, Nov 14, 2020 at 4:51 AM Branko Čibej wrote: On 13.11.2020 17:37, Nathan Hartman wrote: Done in r1883388. Added to the backport proposal but I'll let you un-veto it :-) This fixes the issue on trunk, but when I merge the two revisions to 1.14

Re: [Patch] Update the INSTALL file for SWIG bindings (Re: svn commit: r1883333 - /subversion/site/staging/docs/release-notes/1.14.html)

2020-11-16 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Sat, 14 Nov 2020 14:52 +0900: > +++ subversion/bindings/swig/INSTALL (working copy) > @@ -141,7 +141,15 @@ > - Make sure that Subversion's ./configure script sees your installed SWIG! > + If you are using the distribution tarball and you want to use the language > +

Re: svn commit: r1881534 - /subversion/trunk/build/ac-macros/macosx.m4

2020-11-16 Thread Daniel Shahaf
Branko Čibej wrote on Mon, 16 Nov 2020 16:15 +0100: > On 15.11.2020 19:16, Nathan Hartman wrote: > > On Sat, Nov 14, 2020 at 4:51 AM Branko Čibej wrote: > >> On 13.11.2020 17:37, Nathan Hartman wrote: > >>> Done in r1883388. Added to the backport proposal but I'll let you un-veto > >>> it :-)

Re: [PATCH] fix C4204 errors while building swig-py with Python 3.9 on Windows

2020-11-16 Thread Daniel Shahaf
Branko Čibej wrote on Mon, 16 Nov 2020 09:19 +0100: > On 16.11.2020 04:16, Jun Omae wrote: > > The attached patch adds #pragma warning to make C4204 a warning > > instead of an > > error only on building swig-py with Visual Studio. > > +1 Should that be added to build/generator/templates/ inst

Re: [Patch] Update the INSTALL file for SWIG bindings (Re: svn commit: r1883333 - /subversion/site/staging/docs/release-notes/1.14.html)

2020-11-16 Thread Yasuhito FUTATSUKI
On 2020/11/17 2:16, Daniel Shahaf wrote: > Yasuhito FUTATSUKI wrote on Sat, 14 Nov 2020 14:52 +0900: >> +++ subversion/bindings/swig/INSTALL (working copy) >> @@ -141,7 +141,15 @@ >> - Make sure that Subversion's ./configure script sees your installed SWIG! >> + If you are using the distribution

Re: [PATCH] fix C4204 errors while building swig-py with Python 3.9 on Windows

2020-11-16 Thread Yasuhito FUTATSUKI
On 2020/11/17 2:33, Daniel Shahaf wrote: > Branko Čibej wrote on Mon, 16 Nov 2020 09:19 +0100: >> On 16.11.2020 04:16, Jun Omae wrote: >>> The attached patch adds #pragma warning to make C4204 a warning >>> instead of an >>> error only on building swig-py with Visual Studio. >> >> +1 +1 > Shoul

Re: [PATCH] fix C4204 errors while building swig-py with Python 3.9 on Windows

2020-11-16 Thread Jun Omae
On Tue, Nov 17, 2020 at 2:33 AM Daniel Shahaf wrote: > > Branko Čibej wrote on Mon, 16 Nov 2020 09:19 +0100: > > On 16.11.2020 04:16, Jun Omae wrote: > > > The attached patch adds #pragma warning to make C4204 a warning > > > instead of an > > > error only on building swig-py with Visual Studio. >