On 2020/11/17 2:33, Daniel Shahaf wrote: > Branko Čibej wrote on Mon, 16 Nov 2020 09:19 +0100: >> On 16.11.2020 04:16, Jun Omae wrote: >>> The attached patch adds #pragma warning to make C4204 a warning >>> instead of an >>> error only on building swig-py with Visual Studio. >> >> +1 +1
> Should that be added to build/generator/templates/ instead? Note that > 4204 is specifically there in two places already. I think this fix is better than the fix by removing 4204 from the list of warnings that are treated as error in build/generator/templates/. This is like a situation with the C4115 case last year [1]. As the problem is not in our source code, we wanted to relax the compile option only in SWIG Python bindings, but we couldn't immediately. So we removed C4115 from the list as a compromise. [1] https://lists.apache.org/thread.html/f1f53e2a8710b6478ca8fd0efa68907e8641ba77afdf64d9f208d85f%40%3Cdev.subversion.apache.org%3E Cheers, -- Yasuhito FUTATSUKI <futat...@yf.bsclub.org>
