On Wed, Apr 01, 2020 at 01:43:28AM +, Daniel Shahaf wrote:
> Daniel Shahaf wrote on Tue, 31 Mar 2020 09:23 +00:00:
> > Please add a docstring.
>
> I've gone ahead and added this to STATUS so it doesn't slip through any
> cracks. Feel free to remove the -0 vote once it's been addressed (you
>
On Tue, Mar 31, 2020 at 12:48:21PM +0200, Stefan Sperling wrote:
> On Tue, Mar 31, 2020 at 01:35:54PM +0300, Denis Kovalchuk wrote:
> > > This has caused a test failure on the windows buildbot:
> > >
> > > https://ci.apache.org/builders/svn-windows-local/builds/3392/steps/Test%20fsfs%2Blocal/logs/f
Stefan Sperling wrote on Wed, 01 Apr 2020 10:31 +0200:
> On Wed, Apr 01, 2020 at 01:43:28AM +, Daniel Shahaf wrote:
> > Daniel Shahaf wrote on Tue, 31 Mar 2020 09:23 +00:00:
> > > Please add a docstring.
> >
> > I've gone ahead and added this to STATUS so it doesn't slip through any
> > cr
On Wed, Apr 01, 2020 at 09:34:39AM +, Daniel Shahaf wrote:
> Stefan Sperling wrote on Wed, 01 Apr 2020 10:31 +0200:
> > On Wed, Apr 01, 2020 at 01:43:28AM +, Daniel Shahaf wrote:
> > > Daniel Shahaf wrote on Tue, 31 Mar 2020 09:23 +00:00:
> > > > Please add a docstring.
> > >
> > > I'v
Stefan Sperling wrote on Wed, 01 Apr 2020 11:13 +0200:
> https://ci.apache.org/builders/svn-x64-macosx-fsfs-v6/builds/2941/steps/Test%20ra_local%2Bfsfs-v6/logs/faillog
>
> The svnadmin build-repcache test runs into a checksum mismatch.
>
> Any ideas?
Note the "actual" checksum is the checksum of
> There's another test failure related to this patch.
>
> This time on Mac OS X:
> https://ci.apache.org/builders/svn-x64-macosx-fsfs-v6/builds/2941/steps/Test%20ra_local%2Bfsfs-v6/logs/faillog
>
> The svnadmin build-repcache test runs into a checksum mismatch.
>
> Any ideas?
I started to handle t
On Wed, Apr 01, 2020 at 09:59:41AM +, Daniel Shahaf wrote:
> Stefan Sperling wrote on Wed, 01 Apr 2020 11:13 +0200:
> > https://ci.apache.org/builders/svn-x64-macosx-fsfs-v6/builds/2941/steps/Test%20ra_local%2Bfsfs-v6/logs/faillog
> >
> > The svnadmin build-repcache test runs into a checksum m
Stefan Sperling wrote on Wed, 01 Apr 2020 12:18 +0200:
> On Wed, Apr 01, 2020 at 09:59:41AM +, Daniel Shahaf wrote:
> > Stefan Sperling wrote on Wed, 01 Apr 2020 11:13 +0200:
> > > https://ci.apache.org/builders/svn-x64-macosx-fsfs-v6/builds/2941/steps/Test%20ra_local%2Bfsfs-v6/logs/faillog
>
On Wed, Apr 01, 2020 at 10:26:40AM +, Daniel Shahaf wrote:
> If you haven't already, re-run that builder using subversion-bot to
> check if the bug is reproducible.
Can you please do this yourself when you find time for it?
You provide a lot of good ideas, while at the same time asking others
Stefan Sperling wrote on Wed, 01 Apr 2020 11:51 +0200:
> On Wed, Apr 01, 2020 at 09:34:39AM +, Daniel Shahaf wrote:
> > Stefan Sperling wrote on Wed, 01 Apr 2020 10:31 +0200:
> > > On Wed, Apr 01, 2020 at 01:43:28AM +, Daniel Shahaf wrote:
> > > > Daniel Shahaf wrote on Tue, 31 Mar 2020
On Wed, Apr 01, 2020 at 11:43:05AM +, Daniel Shahaf wrote:
> Stefan Sperling wrote on Wed, 01 Apr 2020 11:51 +0200:
> > On Wed, Apr 01, 2020 at 09:34:39AM +, Daniel Shahaf wrote:
> > > Stefan Sperling wrote on Wed, 01 Apr 2020 10:31 +0200:
> > > > On Wed, Apr 01, 2020 at 01:43:28AM +,
Daniel Shahaf wrote on Wed, 01 Apr 2020 10:26 +:
> Stefan Sperling wrote on Wed, 01 Apr 2020 12:18 +0200:
> > On Wed, Apr 01, 2020 at 09:59:41AM +, Daniel Shahaf wrote:
> > > Stefan Sperling wrote on Wed, 01 Apr 2020 11:13 +0200:
> > > > https://ci.apache.org/builders/svn-x64-macosx-f
On Wed, Apr 1, 2020 at 7:43 AM Daniel Shahaf wrote:
> Thanks for addressing the commit review.
>
> However, I can't end this mail without saying that I feel your conduct
> in these threads has been wanting, even hostile.
This isn't a defense or attack on anyone, but we're in stressful times
rig
On Wed, Apr 1, 2020 at 8:05 AM Daniel Shahaf wrote:
> The failure is 100% reproducible with «./svnadmin_tests.py
> --fs-type=fsfs --fsfs-version=6 74» on Linux.
I'm experimenting with this also. So far I have nothing definitive but
I can confirm that it is 100% reproducible on Linux with the abov
On Wed, Apr 01, 2020 at 11:45:04AM -0400, Nathan Hartman wrote:
> On Wed, Apr 1, 2020 at 8:05 AM Daniel Shahaf wrote:
> > The failure is 100% reproducible with «./svnadmin_tests.py
> > --fs-type=fsfs --fsfs-version=6 74» on Linux.
>
> I'm experimenting with this also. So far I have nothing defini
On Wed, Apr 01, 2020 at 06:25:12PM +0200, Stefan Sperling wrote:
> On Wed, Apr 01, 2020 at 11:45:04AM -0400, Nathan Hartman wrote:
> > On Wed, Apr 1, 2020 at 8:05 AM Daniel Shahaf
> > wrote:
> > > The failure is 100% reproducible with «./svnadmin_tests.py
> > > --fs-type=fsfs --fsfs-version=6 74»
On Wed, Apr 01, 2020 at 06:40:27PM +0200, Stefan Sperling wrote:
> This seems to fix it.
>
> I don't understand why this is necessary but the regular code path for
> access to node revision data in fsfs also seems to apply this always.
>
> Can an fsfs expert confirm?
Since this fix looks reasona
> > This seems to fix it.
> >
> > I don't understand why this is necessary but the regular code path for
> > access to node revision data in fsfs also seems to apply this always.
> >
> > Can an fsfs expert confirm?
>
> Since this fix looks reasonable to me and we're trying to move the release
> pro
On Wed, Apr 01, 2020 at 10:50:12PM +0300, Denis Kovalchuk wrote:
> > > This seems to fix it.
> > >
> > > I don't understand why this is necessary but the regular code path for
> > > access to node revision data in fsfs also seems to apply this always.
> > >
> > > Can an fsfs expert confirm?
> >
> >
On Wed, Apr 1, 2020 at 3:54 PM Stefan Sperling wrote:
> On Wed, Apr 01, 2020 at 10:50:12PM +0300, Denis Kovalchuk wrote:
> > Because the root cause of the problem was unclear to me I investigated
> it.
> >
> > svn_fs_fs__fixup_expanded_size() function exists due to issue SVN-4554
> [1].
> > In th
Stefan Sperling wrote on Wed, 01 Apr 2020 11:58 +00:00:
> FWIW, "You are expected to fix it" could also be interpreted as hostile.
> It's a direct order from you directed at me, telling me what I should do.
You committed a bug so I asked you to fix it, just like when Denis broke
the build you aske
Good morning futatuki@,
futat...@apache.org wrote on Wed, 01 Apr 2020 21:07 -:
> Explain SWIG is needed for building Python 2 bindings.
>
> Since Subversion distibution 1.14.0 and later will ship with SWIG Python
> bindings *.c source code for Python 3, clarify *.c source files for Python 2
>
Daniel Shahaf wrote on Thu, 02 Apr 2020 00:05 +00:00:
> Stefan Sperling wrote on Wed, 01 Apr 2020 11:58 +00:00:
> > If it makes you feel any better, I'd be happy to stop voluteering for the
> > RM role, and let you or someone else worry about the release going forward.
>
> I won't dignify this pet
On Wed, Apr 1, 2020 at 9:08 PM Daniel Shahaf wrote:
> Daniel Shahaf wrote on Thu, 02 Apr 2020 00:05 +00:00:
> > Stefan Sperling wrote on Wed, 01 Apr 2020 11:58 +00:00:
> > > If it makes you feel any better, I'd be happy to stop voluteering for
> the
> > > RM role, and let you or someone else worr
24 matches
Mail list logo
