Stefan Sperling wrote on Wed, 01 Apr 2020 10:31 +0200: > On Wed, Apr 01, 2020 at 01:43:28AM +0000, Daniel Shahaf wrote: > > Daniel Shahaf wrote on Tue, 31 Mar 2020 09:23 +00:00: > > > Please add a docstring. > > > > I've gone ahead and added this to STATUS so it doesn't slip through any > > cracks. Feel free to remove the -0 vote once it's been addressed (you > > needn't round-trip through me for this). > > Wouldn't it be enough if you or someone else added docstrings on trunk > at some convenient point in time in the future, and then nominated that > revision as a regular follow-up change if it's deemed important enough? >
No, it wouldn't. You committed two new functions without docstring. That's a bug in your commit. You are expected to fix it.
