RE: log --search test failures on trunk and 1.8.x

2013-04-22 Thread Bert Huijben
> -Original Message- > From: Stefan Sperling [mailto:s...@elego.de] > Sent: maandag 22 april 2013 00:08 > To: Ivan Zhakov > Cc: Branko Čibej; Bert Huijben; dev@subversion.apache.org > Subject: Re: log --search test failures on trunk and 1.8.x > > On Sun, Apr 21, 2013 at 07:11:14PM +0400,

Re: log --search test failures on trunk and 1.8.x

2013-04-22 Thread 'Stefan Sperling'
On Mon, Apr 22, 2013 at 11:22:11AM +0200, Bert Huijben wrote: > > -Original Message- > > From: Stefan Sperling [mailto:s...@elego.de] > > Sent: maandag 22 april 2013 00:08 > > To: Ivan Zhakov > > Cc: Branko Čibej; Bert Huijben; dev@subversion.apache.org > > Subject: Re: log --search test fa

RE: log --search test failures on trunk and 1.8.x

2013-04-22 Thread Bert Huijben
> -Original Message- > From: 'Stefan Sperling' [mailto:s...@elego.de] > Sent: maandag 22 april 2013 11:46 > To: Bert Huijben > Cc: 'Ivan Zhakov'; 'Branko Čibej'; dev@subversion.apache.org > Subject: Re: log --search test failures on trunk and 1.8.x > > On Mon, Apr 22, 2013 at 11:22:11AM

Re: log --search test failures on trunk and 1.8.x

2013-04-22 Thread Branko Čibej
On 22.04.2013 12:59, Bert Huijben wrote: > >> -Original Message- >> From: 'Stefan Sperling' [mailto:s...@elego.de] >> Sent: maandag 22 april 2013 11:46 >> To: Bert Huijben >> Cc: 'Ivan Zhakov'; 'Branko Čibej'; dev@subversion.apache.org >> Subject: Re: log --search test failures on trunk and

Re: svn commit: r1469982 - in /subversion/trunk/subversion: include/private/svn_client_private.h libsvn_client/log.c libsvn_client/ra.c tests/cmdline/log_tests.py

2013-04-22 Thread C. Michael Pilato
On 04/20/2013 05:00 AM, Bert Huijben wrote: > Instead of patching more and more corner cases with individual extra ra > calls I think svn_client_log should call svn_client__repos_locations() > once to obtain the history of the path to look at over the entire range > of versions. (=over MAX(rev):MIN

RE: svn commit: r1469982 - in /subversion/trunk/subversion: include/private/svn_client_private.h libsvn_client/log.c libsvn_client/ra.c tests/cmdline/log_tests.py

2013-04-22 Thread Bert Huijben
> -Original Message- > From: C. Michael Pilato [mailto:cmpil...@collab.net] > Sent: maandag 22 april 2013 15:46 > To: Bert Huijben > Cc: dev@subversion.apache.org > Subject: Re: svn commit: r1469982 - in /subversion/trunk/subversion: > include/private/svn_client_private.h libsvn_client/lo

Re: Pristine text missing - cleanup doesn't work

2013-04-22 Thread Julian Foad
I have filed this as issue #4357, "Pristine text missing - cleanup doesn't work", with a reference to this email thread. I thought of the following possible improvements, which I have noted in the doc string of pristine_cleanup_wcroot():  * TODO: At least check that any zero refcount is really

AW: Making the Windows Build Easier

2013-04-22 Thread Markus Schaber
Hi, Berts SharpSVN build also includes a way to pull all the dependencies, using msbuild. However, it does not work with the express editions yet, AFAICS, so your script clearly has at least one advantage. :-) Will it work using the VS 2010 command prompt? Best regards Markus Schaber CODESY

RE: Pristine text missing - cleanup doesn't work

2013-04-22 Thread Bert Huijben
> -Original Message- > From: Julian Foad [mailto:julianf...@btopenworld.com] > Sent: maandag 22 april 2013 16:34 > To: Johan Corveleyn > Cc: Bert Huijben; Subversion Development > Subject: Re: Pristine text missing - cleanup doesn't work > > I have filed this as issue #4357, "Pristine te

RE: Pristine text missing - cleanup doesn't work

2013-04-22 Thread Bert Huijben
> -Original Message- > From: Bert Huijben [mailto:b...@qqmail.nl] > Sent: maandag 22 april 2013 17:18 > To: 'Julian Foad'; 'Johan Corveleyn' > Cc: 'Subversion Development' > Subject: RE: Pristine text missing - cleanup doesn't work > > > > > -Original Message- > > From: Julian

Issue #4358 - Svn WC 1.8 upgrade from 1.7 - wrong schema

2013-04-22 Thread Julian Foad
I noticed that a fresh 1.8.x (pre-release) WC has a different schema from a WC created by 1.7.8 and upgraded by 1.8.x.  (I haven't tried different 1.7.x versions.)  The differences are: --- schema-1.7.8-upgraded-to-1.8-dev +++ schema-1.8-dev -   file_external  TEXT, +   file_external  INTEGER,

Re: svn commit: r1469982 - in /subversion/trunk/subversion: include/private/svn_client_private.h libsvn_client/log.c libsvn_client/ra.c tests/cmdline/log_tests.py

2013-04-22 Thread Paul Burba
On Sat, Apr 20, 2013 at 5:00 AM, Bert Huijben wrote: > >> -Original Message- >> From: pbu...@apache.org [mailto:pbu...@apache.org] >> Sent: vrijdag 19 april 2013 20:22 >> To: comm...@subversion.apache.org >> Subject: svn commit: r1469982 - in /subversion/trunk/subversion: >> include/privat

Re: Pristine text missing - cleanup doesn't work

2013-04-22 Thread Julian Foad
Bert Huijben wrote: >>>  * TODO: At least check that any zero refcount is really correct, before >>>  *       using it. >> >>  We already do this in debug builds. Hmm, you're right, when using a current 1.8-dev build and a fresh WC. When I tested this scenario the other day it was in an old WC t

Re: svn commit: r1469982 - in /subversion/trunk/subversion: include/private/svn_client_private.h libsvn_client/log.c libsvn_client/ra.c tests/cmdline/log_tests.py

2013-04-22 Thread C. Michael Pilato
On 04/22/2013 01:22 PM, Paul Burba wrote: >> I wonder, though: isn't this rev-range support better situated in the RA >> layer itself, extended up to the server? I ask because IIRC, the fallback >> implementation of svn_ra_get_repos_locations() > > You too mean svn_ra_get_location_segments or sv

Re: Issue #4358 - Svn WC 1.8 upgrade from 1.7 - wrong schema

2013-04-22 Thread Julian Foad
I (Julian Foad) wrote: > I noticed that a fresh 1.8.x (pre-release) WC has a different schema from a > WC > created by 1.7.8 and upgraded by 1.8.x.  (I haven't tried different 1.7.x > versions.)  The differences are: > > --- schema-1.7.8-upgraded-to-1.8-dev > +++ schema-1.8-dev > > -   file_e

RE: svn commit: r1469982 - in /subversion/trunk/subversion: include/private/svn_client_private.h libsvn_client/log.c libsvn_client/ra.c tests/cmdline/log_tests.py

2013-04-22 Thread Bert Huijben
> -Original Message- > From: Paul Burba [mailto:ptbu...@gmail.com] > Sent: maandag 22 april 2013 19:23 > To: Bert Huijben > Cc: Michael Pilato; Subversion Development > Subject: Re: svn commit: r1469982 - in /subversion/trunk/subversion: > include/private/svn_client_private.h libsvn_clien

RE: Issue #4358 - Svn WC 1.8 upgrade from 1.7 - wrong schema

2013-04-22 Thread Bert Huijben
> -Original Message- > From: Julian Foad [mailto:julianf...@btopenworld.com] > Sent: maandag 22 april 2013 18:51 > To: Subversion Development > Subject: Issue #4358 - Svn WC 1.8 upgrade from 1.7 - wrong schema > > I noticed that a fresh 1.8.x (pre-release) WC has a different schema from

Re: Issue #4358 - Svn WC 1.8 upgrade from 1.7 - wrong schema

2013-04-22 Thread Julian Foad
Bert Huijben wrote: > Julian Foad wrote: >> --- schema-1.7.8-upgraded-to-1.8-dev >> +++ schema-1.8-dev >> >> -   file_external  TEXT, >> +   file_external  INTEGER, > > This doesn't matter for our use of Sqlite. We only use NULL vs set, but > integer documents what we now store in file_exter

RE: Issue #4358 - Svn WC 1.8 upgrade from 1.7 - wrong schema

2013-04-22 Thread Bert Huijben
> -Original Message- > From: Julian Foad [mailto:julianf...@btopenworld.com] > Sent: maandag 22 april 2013 20:47 > To: Bert Huijben > Cc: 'Subversion Development' > Subject: Re: Issue #4358 - Svn WC 1.8 upgrade from 1.7 - wrong schema > > Bert Huijben wrote: > > > Julian Foad wrote: > >

Re: Issue #4358 - Svn WC 1.8 upgrade from 1.7 - wrong schema

2013-04-22 Thread Julian Foad
Bert Huijben wrote: > Julian Foad wrote:   -CREATE INDEX I_ACTUAL_PARENT ON ACTUAL_NODE (   -    wc_id, parent_relpath);   +CREATE UNIQUE INDEX I_ACTUAL_PARENT ON ACTUAL_NODE (   +    wc_id, parent_relpath, local_relpath);   -CREATE INDEX I_NODES_PARENT ON NODES (   - 

Re: Pristine text missing - cleanup doesn't work

2013-04-22 Thread Johan Corveleyn
On Mon, Apr 22, 2013 at 4:34 PM, Julian Foad wrote: > I have filed this as issue #4357, "Pristine text missing - cleanup doesn't > work", with a reference to this email thread. > > I thought of the following possible improvements, which I have noted in the > doc string of pristine_cleanup_wcroot

Re: Issue #4358 - Svn WC 1.8 upgrade from 1.7 - wrong schema

2013-04-22 Thread Julian Foad
Julian Foad wrote: > Bert Huijben wrote: >>  We also have that index..., but we query nodes in 3 ways: >> >>  * Where local_relpath = 'something' (exact lookup) >>  * Where parent_relpath = 'something' (everything in a directory) >>  * Where local_relpath > './' and local_relpath < '0' (al

Re: Issue #4358 - Svn WC 1.8 upgrade from 1.7 - wrong schema

2013-04-22 Thread Alan Barrett
On Mon, 22 Apr 2013, Bert Huijben wrote: Sqlite doesn't implement an ALTER table statement that can update this, so I don't think we should try to change this for 1.8. You can copy the data to a temporary table; drop the old table; create a new table with the new schema; and then copy everythin

Re: log --search test failures on trunk and 1.8.x

2013-04-22 Thread Stefan Sperling
On Mon, Apr 22, 2013 at 01:13:43PM +0200, Branko Čibej wrote: > On 22.04.2013 12:59, Bert Huijben wrote: > > The assertion shows a design problem which we should handle for future > > compatibility and you suggest just adding some bandages to patch/hide the > > test failure? > > > > The current c