Re: Consolidating private/svn_subr_private.h

2012-09-05 Thread Daniel Shahaf
Greg Stein wrote on Tue, Sep 04, 2012 at 23:11:24 -0400: > On Sep 4, 2012 5:47 PM, "Daniel Shahaf" wrote: > > > > Stefan Fuhrmann wrote on Tue, Sep 04, 2012 at 22:03:54 +0200: > > > Hi there, > > > > > > While looking for the appropriate place to declare a few > > > svn-private constants, I realiz

Re: [PATCH] SVN 1.7 and 1.8 generates extra header when diffing with external tool

2012-09-05 Thread Daniel Shahaf
Alexey Neyman wrote on Tue, Sep 04, 2012 at 23:40:58 -0700: > On Tuesday, September 04, 2012 05:56:27 PM Stefan Sperling wrote: > > On Fri, Aug 31, 2012 at 03:24:18PM -0700, Alexey Neyman wrote: > > > Hi SVN developers, > > > > > > I noticed an issue which prevents the 'post-review' tool from Revi

Re: Consolidating private/svn_subr_private.h

2012-09-05 Thread Branko Čibej
On 05.09.2012 11:47, Daniel Shahaf wrote: > Greg Stein wrote on Tue, Sep 04, 2012 at 23:11:24 -0400: >> On Sep 4, 2012 5:47 PM, "Daniel Shahaf" wrote: >>> Stefan Fuhrmann wrote on Tue, Sep 04, 2012 at 22:03:54 +0200: Hi there, While looking for the appropriate place to declare a few

Re: svn commit: r1357313 - in /subversion/trunk/subversion/svn: cl.h notify.c update-cmd.c

2012-09-05 Thread Stefan Sperling
On Tue, Sep 04, 2012 at 03:01:22PM -0400, Paul Burba wrote: > I just noticed that this causes a segfault when updating with the quiet > option: > > [[[ > > C:\SVN\src-trunk>svn up > Updating '.': > At revision 1380738. > > C:\SVN\src-trunk>svn up -q > This application has halted due to an unexp

Re: thread safe

2012-09-05 Thread Stefan Küng
On Wed, Sep 5, 2012 at 1:14 AM, Branko Čibej wrote: > On 04.09.2012 22:24, Stefan Küng wrote: >> Attached is my first draft of the new svn_config_dup() API. >> >> * it does not return an svn_error_t but the duplicate hash directly. >> The only API call that could return an error is svn_config_crea

Re: thread safe

2012-09-05 Thread Branko Čibej
On 05.09.2012 15:24, Stefan Küng wrote: > On Wed, Sep 5, 2012 at 1:14 AM, Branko Čibej wrote: >> On 04.09.2012 22:24, Stefan Küng wrote: >>> Attached is my first draft of the new svn_config_dup() API. >>> >>> * it does not return an svn_error_t but the duplicate hash directly. >>> The only API cal

Re: thread safe

2012-09-05 Thread Stefan Küng
On Wed, Sep 5, 2012 at 3:54 PM, Branko Čibej wrote: >>> As I said, the return value must be a svn_config_t*. >>> More comments below (I'll ignore coding style). >> Why must it be an svn_config_t* ? >> That makes no sense: we want to duplicate the config hash. > > Ah, I begin to understand; you wa

Re: svn commit: r1357313 - in /subversion/trunk/subversion/svn: cl.h notify.c update-cmd.c

2012-09-05 Thread Julian Foad
Stefan Sperling wrote: > On Tue, Sep 04, 2012 at 03:01:22PM -0400, Paul Burba wrote: >> I just noticed that this causes a segfault when updating with >> the quiet option: > > Thanks for digging into this and explaining the problem, Paul. > > I cannot think of a better way to fix this than recor

Re: svn commit: r1380311 - /subversion/trunk/build/generator/templates/svn_locale.vcxproj.ezt

2012-09-05 Thread Daniel Shahaf
Роман Донченко wrote on Tue, Sep 04, 2012 at 22:13:34 +0400: > I thought the fix was obvious because the presence of the > NMake*CommandLine elements indicates it ought to be a Makefile > project (cf. zlib.vcxproj.ezt); but if you think I'm overstepping my > boundaries here, then sure, I'll go thro

Re: thread safe

2012-09-05 Thread Stefan Küng
Here's my attempt to implement two new APIs to duplicate an svn_config_t and a hash of those. I factored out some code from svn_config_set into two new helper functions which I then used in the new dup functions. Please review. Stefan -- ___ oo // \\ "De Chelonian Mobile" (_

Re: svn commit: r1357313 - in /subversion/trunk/subversion/svn: cl.h notify.c update-cmd.c

2012-09-05 Thread Paul Burba
On Wed, Sep 5, 2012 at 11:11 AM, Julian Foad wrote: > Stefan Sperling wrote: > >> On Tue, Sep 04, 2012 at 03:01:22PM -0400, Paul Burba wrote: >>> I just noticed that this causes a segfault when updating with >>> the quiet option: >> >> Thanks for digging into this and explaining the problem, Paul

Legal Matter

2012-09-05 Thread Akiyoshi Takahashi
 We are media publisher company here in Japan and we have a breach of intellectual property agreement matter in your jurisdiction. Please advise us on your retainer fee so that we can forward you the agreement for your review and run a conflict check.Yours Sincerely,Mr. Akiyoshi Takahashi

Re: Legal Matter

2012-09-05 Thread Lorenz
Akiyoshi Takahashi wrote: >[...] ups, didn't mean to moderate that s... through sorry need coffee -- Lorenz