Re: running test-suite over https

2012-08-13 Thread Philip Martin
Daniel Shahaf writes: > Johan Corveleyn wrote on Sat, Aug 11, 2012 at 22:11:22 +0200: >> >> Okay, I see there is an --ssl-cert option in svntest/main.py which >> does the necessary stuff. It's just not exposed through win-tests.py. > > Someone must have added it while I wasn't looking... Me. s

Re: svn commit: r1367683 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2012-08-13 Thread Daniel Shahaf
phi...@apache.org wrote on Tue, Jul 31, 2012 at 17:14:58 -: > Author: philip > Date: Tue Jul 31 17:14:58 2012 > New Revision: 1367683 > > URL: http://svn.apache.org/viewvc?rev=1367683&view=rev > Log: > Fix issue 4213, "svnadmin recover" fails on old format repositories. > > * subversion/libsv

Re: svn commit: r1367683 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2012-08-13 Thread Philip Martin
Daniel Shahaf writes: > phi...@apache.org wrote on Tue, Jul 31, 2012 at 17:14:58 -: >> Author: philip >> Date: Tue Jul 31 17:14:58 2012 >> New Revision: 1367683 >> >> URL: http://svn.apache.org/viewvc?rev=1367683&view=rev >> Log: >> Fix issue 4213, "svnadmin recover" fails on old format repo

Re: svn commit: r1367683 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2012-08-13 Thread Daniel Shahaf
Philip Martin wrote on Mon, Aug 13, 2012 at 08:39:38 +0100: > Daniel Shahaf writes: > > > phi...@apache.org wrote on Tue, Jul 31, 2012 at 17:14:58 -: > >> Author: philip > >> Date: Tue Jul 31 17:14:58 2012 > >> New Revision: 1367683 > >> > >> URL: http://svn.apache.org/viewvc?rev=1367683&vie

Re: running test-suite over https

2012-08-13 Thread Johan Corveleyn
On Mon, Aug 13, 2012 at 9:28 AM, Philip Martin wrote: > Daniel Shahaf writes: > >> Johan Corveleyn wrote on Sat, Aug 11, 2012 at 22:11:22 +0200: >>> >>> Okay, I see there is an --ssl-cert option in svntest/main.py which >>> does the necessary stuff. It's just not exposed through win-tests.py. >>

Re: running test-suite over https

2012-08-13 Thread Philip Martin
Johan Corveleyn writes: > wrote: >> Me. subversion/tests/cmdline/davautocheck.sh does the relevant magic to >> setup Apache if one uses: >> >>make davautocheck USE_SSL=1 > > Nice. I made a change (locally) to win-tests.py to also pass this > option, but it doesn't seem to work properly. I c

Re: running test-suite over https

2012-08-13 Thread Philip Martin
Philip Martin writes: > Johan Corveleyn writes: > >> wrote: >>> Me. subversion/tests/cmdline/davautocheck.sh does the relevant magic to >>> setup Apache if one uses: >>> >>>make davautocheck USE_SSL=1 >> >> Nice. I made a change (locally) to win-tests.py to also pass this >> option, but it

Re: svn commit: r1371633 - in /subversion/trunk/build/generator/templates: svn_config.vcproj.ezt svn_config.vcxproj.ezt vcnet_vcproj.ezt vcnet_vcxproj.ezt

2012-08-13 Thread Julian Foad
Johan Corveleyn wrote: >> Author: brane >> Date: Fri Aug 10 09:55:16 2012 >> New Revision: 1371633 >> >> URL: http://svn.apache.org/viewvc?rev=1371633&view=rev >> Log: >> On Windows, create the generated svn_private_config.h in the intermediate >> build directory so that different configur

Re: svn commit: r1371633 - in /subversion/trunk/build/generator/templates: svn_config.vcproj.ezt svn_config.vcxproj.ezt vcnet_vcproj.ezt vcnet_vcxproj.ezt

2012-08-13 Thread Branko Čibej
On 13.08.2012 16:21, Julian Foad wrote: > Johan Corveleyn wrote: > >>> Author: brane >>> Date: Fri Aug 10 09:55:16 2012 >>> New Revision: 1371633 >>> >>> URL: http://svn.apache.org/viewvc?rev=1371633&view=rev >>> Log: >>> On Windows, create the generated svn_private_config.h in the intermedia

Re: svn commit: r1371633 - in /subversion/trunk/build/generator/templates: svn_config.vcproj.ezt svn_config.vcxproj.ezt vcnet_vcproj.ezt vcnet_vcxproj.ezt

2012-08-13 Thread Julian Foad
Branko Čibej wrote: > On 13.08.2012 16:21, Julian Foad wrote: >> Johan Corveleyn wrote:   Author: brane   On Windows, create the generated svn_private_config.h in the   intermediate build directory so that different configurations   don't all use the same canonical hos

Re: svn commit: r1371633 - in /subversion/trunk/build/generator/templates: svn_config.vcproj.ezt svn_config.vcxproj.ezt vcnet_vcproj.ezt vcnet_vcxproj.ezt

2012-08-13 Thread Philip Martin
Julian Foad writes: > I always do out-of-tree builds, and we currently create that .h file > in the source tree not the build tree. That's not what I see in my out-of-tree build. The source tree has the non-versioned svn_private_config.h.in created by autogen.sh. The build tree has svn_private_

Re: svn commit: r1371633 - in /subversion/trunk/build/generator/templates: svn_config.vcproj.ezt svn_config.vcxproj.ezt vcnet_vcproj.ezt vcnet_vcxproj.ezt

2012-08-13 Thread Julian Foad
I (Julian Foad) wrote: > Branko Čibej wrote: >> On 13.08.2012 16:21, Julian Foad wrote: >>>   Johan Corveleyn wrote: >   Author: brane > >   On Windows, create the generated svn_private_config.h in the >   intermediate build directory so that different configurations >  

Backport fixes for issue 4110 and 4112 to 1.7.x?

2012-08-13 Thread C. Michael Pilato
Philip, I just closed issue #4205[1] as a duplicate of issue #4110[2], which you fixed (along with issue #4112[3]) back in February. The issue was raised again apparently because we never backported your fixes to 1.7.x. Is that something we should do? Or was there a reason you didn't propose as

Re: running test-suite over https

2012-08-13 Thread Ben Reser
Neon's test suite has some logic in it to generate certificates. We should probably do something similar for this. Side note: If someone implements it just please don't do what neon does and depend on the Gnu specific flag '-d' to the date command to figure out the right timestamp to set on the

Re: Backport fixes for issue 4110 and 4112 to 1.7.x?

2012-08-13 Thread Philip Martin
"C. Michael Pilato" writes: > I just closed issue #4205[1] as a duplicate of issue #4110[2], which you > fixed (along with issue #4112[3]) back in February. The issue was raised > again apparently because we never backported your fixes to 1.7.x. Is that > something we should do? Or was there a

Re: running test-suite over https

2012-08-13 Thread Philip Martin
I considered generating the certificate but I am wary of draining the system entropy. I don't know how much entropy generating an SSL certificate requires but the testsuite doesn't need a high quality certificate and it should avoid using entropy if possible. So I embedded a pre-generated certifi

Re: svn commit: r1371633 - in /subversion/trunk/build/generator/templates: svn_config.vcproj.ezt svn_config.vcxproj.ezt vcnet_vcproj.ezt vcnet_vcxproj.ezt

2012-08-13 Thread Julian Foad
I (Julian Foad) wrote: > I (Julian Foad) wrote: >> Branko Čibej wrote: >>> On 13.08.2012 16:21, Julian Foad wrote: Johan Corveleyn wrote: >> Author: brane >> >> On Windows, create the generated svn_private_config.h in the >> intermediate build directory so that different con

Re: Backport fixes for issue 4110 and 4112 to 1.7.x?

2012-08-13 Thread C. Michael Pilato
On 08/13/2012 11:56 AM, Philip Martin wrote: > "C. Michael Pilato" writes: > >> I just closed issue #4205[1] as a duplicate of issue #4110[2], which you >> fixed (along with issue #4112[3]) back in February. The issue was raised >> again apparently because we never backported your fixes to 1.7.x

Re: 1.7.6 Candidates

2012-08-13 Thread Philip Martin
Philip Martin writes: > Subversion 1.7.6 tarballs are now available for testing/signing by > committers. To obtain them please check out a working copy from > https://dist.apache.org/repos/dist/dev/subversion > > Please add your signatures to the .asc files there. We have sufficient signatures s

Re: svn commit: r1372056 -

2012-08-13 Thread Julian Foad
Daniel Shahaf wrote: > Johan Corveleyn wrote on Sun, Aug 12, 2012 at 17:48:09 +0200: >> It seems the buildbots don't automatically start building on a change >> like this (also happened when you broke the build, it was only after >> julian made another change that the buildbots failed, and blamed

Re: Symmetric merge and deleted subtrees

2012-08-13 Thread Julian Foad
I (Julian Foad) wrote: > I have only had a chance to skim through your reply so far.  I'm glad that > you find it to be an explicable and harmless difference. OK, I follow your explanation and agree; thanks.  I have closed the isse #4217. In investigating this, I tried your suggestion of doing

Fwd: [julianf...@apache.org: svn commit: r828822 - /infrastructure/buildbot/aegis/buildmaster/master1/projects/subversion.conf]

2012-08-13 Thread Daniel Shahaf
- Forwarded message from julianf...@apache.org - > Date: Mon, 13 Aug 2012 19:12:04 - > From: julianf...@apache.org > To: infrastructure-...@apache.org > Subject: svn commit: r828822 - > /infrastructure/buildbot/aegis/buildmaster/master1/projects/subversion.conf > Message-Id: <20120813

Re: Fwd: [julianf...@apache.org: svn commit: r828822 - /infrastructure/buildbot/aegis/buildmaster/master1/projects/subversion.conf]

2012-08-13 Thread Julian Foad
Daniel Shahaf wrote: >> Author: julianfoad >> Date: Mon Aug 13 19:12:03 2012 >> New Revision: 828822 >> >> Log: >> Adjust what triggers a Subversion build. >> >> * master1/projects/subversion.conf >>   (SubversionExcludes): Remove 'packages' because some builds >>     depend on the pack

Fwd: [danie...@apache.org: svn commit: r828826 - /infrastructure/buildbot/aegis/buildmaster/master1/projects/subversion.conf]

2012-08-13 Thread Daniel Shahaf
- Forwarded message from danie...@apache.org - > Date: Mon, 13 Aug 2012 20:01:04 - > From: danie...@apache.org > To: infrastructure-...@apache.org > Subject: svn commit: r828826 - > /infrastructure/buildbot/aegis/buildmaster/master1/projects/subversion.conf > Message-Id: <201208132001

Re: Fwd: [julianf...@apache.org: svn commit: r828822 - /infrastructure/buildbot/aegis/buildmaster/master1/projects/subversion.conf]

2012-08-13 Thread Daniel Shahaf
Julian Foad wrote on Mon, Aug 13, 2012 at 21:03:47 +0100: > Daniel Shahaf wrote: > > >> Author: julianfoad > >> Date: Mon Aug 13 19:12:03 2012 > >> New Revision: 828822 > >> > >> Log: > >> Adjust what triggers a Subversion build. > >> > >> * master1/projects/subversion.conf > >>   (Subver

Re: running test-suite over https

2012-08-13 Thread Johan Corveleyn
On Mon, Aug 13, 2012 at 3:27 PM, Philip Martin wrote: > Philip Martin writes: > >> Johan Corveleyn writes: >> >>> wrote: Me. subversion/tests/cmdline/davautocheck.sh does the relevant magic to setup Apache if one uses: make davautocheck USE_SSL=1 >>> >>> Nice. I made a c

Re: running test-suite over https

2012-08-13 Thread Philip Martin
Johan Corveleyn writes: > I tried all I can think of for configuring Apache. Pf. Do you have an explicit ServerName? Are you using VirtualHost? Can you connect using 1.7/neon? Can you connect using a browser? Here is the complete Apache config file generated by davautocheck.sh: LoadModu

Re: running test-suite over https

2012-08-13 Thread Johan Corveleyn
On Tue, Aug 14, 2012 at 1:10 AM, Philip Martin wrote: > Johan Corveleyn writes: > >> I tried all I can think of for configuring Apache. Pf. > > Do you have an explicit ServerName? Are you using VirtualHost? Can you > connect using 1.7/neon? Can you connect using a browser? Explicit Server

Re: svn commit: r1372665 - /subversion/branches/master-passphrase/subversion/libsvn_auth_kwallet/kwallet.cpp

2012-08-13 Thread Blair Zajac
On 08/13/2012 04:24 PM, phi...@apache.org wrote: Author: philip Date: Mon Aug 13 23:24:06 2012 New Revision: 1372665 URL: http://svn.apache.org/viewvc?rev=1372665&view=rev Log: Fix C++ compile errors. * subversion/libsvn_auth_kwallet/kwallet.cpp (): Include svn_base64.h. (kwallet_master_p

Re: svn commit: r1372665 - /subversion/branches/master-passphrase/subversion/libsvn_auth_kwallet/kwallet.cpp

2012-08-13 Thread C. Michael Pilato
On 08/13/2012 07:24 PM, phi...@apache.org wrote: > Author: philip > Date: Mon Aug 13 23:24:06 2012 > New Revision: 1372665 > > URL: http://svn.apache.org/viewvc?rev=1372665&view=rev > Log: > Fix C++ compile errors. Wow, cool! Thanks, Philip. -- C. Michael Pilato CollabNet <> www.collab.ne