Julian Foad wrote on Mon, Aug 13, 2012 at 21:03:47 +0100:
> Daniel Shahaf wrote:
> 
> >>  Author: julianfoad
> >>  Date: Mon Aug 13 19:12:03 2012
> >>  New Revision: 828822
> >> 
> >>  Log:
> >>  Adjust what triggers a Subversion build.
> >> 
> >>  * master1/projects/subversion.conf
> >>    (SubversionExcludes): Remove 'packages' because some builds 
> >>     depend on the  package scripts, and remove 'tools' because
> >>     some tools are  included by  default in a standard build.
> 
> >>   # List the paths that are not interesting enough to trigger a new build.
> >>   import re
> >>   SubversionExcludes = masterExcludes + ["COMMITTERS", "STATUS",
> >> "CHANGES", "README",  "INSTALL", "COPYING", "HACKING", "TRANSLATING",
> >>  -            "BUGS", "www", "notes", "packages", "subversion/LICENSE",
> >> "subversion/po", "doc", "contrib", "tools", "dist.sh"]
> >>  +            "BUGS", "www", "notes", "subversion/LICENSE",
> >> "subversion/po", "doc", "contrib", "dist.sh"]
> > 
> > The semantics of this list are as follows: if a revision does not touch
> > a path that doesn't match any of the above patterns, then buildbot skips
> > building it.
> 
> Simplifying your triple-negative:
> 
>   "if a rev doesn't touch a path that doesn't match any pattern, don't build"
> 
> => "if a rev DOES touch a path that doesn't match any pattern, DO build"
> 

I already committed a (differently) simplified text; thanks though.

> That's what I thought it meant.  Thanks for confirming.  Or did you mean 
> imply something is wrong?
> 

I was just trying to document the semantics of the variable --- for
readers of dev@ that don't have the full context of the file (namely,
the function's definition).  Sorry for the unclarity.

> - Julian

Reply via email to