Re: svn commit: r1127134 - in /subversion/trunk/subversion: libsvn_client/add.c libsvn_wc/adm_ops.c tests/cmdline/tree_conflict_tests.py

2011-09-07 Thread Stefan Sperling
On Tue, Sep 06, 2011 at 06:04:32PM -0400, Paul Burba wrote: > On Tue, May 24, 2011 at 12:35 PM, wrote: > > Author: stsp > > Date: Tue May 24 16:35:14 2011 > > New Revision: 1127134 > > > > URL: http://svn.apache.org/viewvc?rev=1127134&view=rev > > Log: > > As part of issue #3779, "actual-only nod

Re: Thoughts about issue #3625 (shelving)

2011-09-07 Thread Stefan Sperling
On Wed, Sep 07, 2011 at 12:53:38AM -0400, Jeffrey Pierson wrote: > With the new patch features from 1.7 would it make sense to implement this > feature internally as a stored patch with some extra changes to the client > to allow exporting the shelved changes as a patch and more obviously shelve >

RE: svn commit: r1166096 - in /subversion/trunk/subversion: include/svn_repos.h svnadmin/main.c

2011-09-07 Thread Bert Huijben
> -Original Message- > From: danie...@apache.org [mailto:danie...@apache.org] > Sent: woensdag 7 september 2011 12:20 > To: comm...@subversion.apache.org > Subject: svn commit: r1166096 - in /subversion/trunk/subversion: > include/svn_repos.h svnadmin/main.c > > Author: danielsh > Date:

Download site could do with pointers to other releases and link to KEYS file

2011-09-07 Thread sebb
The Apache Subversion download site [1] only has a short list of files. There's no header or footer as is used by many other ASF products. It would be helpful to have some pointers to the Subversion archives, and a link to the KEYS file, see for example [2] and [3] [1] http://www.apache.org/dist

Re: Download site could do with pointers to other releases and link to KEYS file

2011-09-07 Thread Daniel Shahaf
On the same topic, I note that a README file is present in the dist dir on people.a.o, but not in the dist dir on www.a.o. sebb wrote on Wed, Sep 07, 2011 at 12:34:11 +0100: > The Apache Subversion download site [1] only has a short list of files. > > There's no header or footer as is used by man

Re: Download site could do with pointers to other releases and link to KEYS file

2011-09-07 Thread sebb
On 7 September 2011 13:47, Daniel Shahaf wrote: > On the same topic, I note that a README file is present in the dist dir > on people.a.o, but not in the dist dir on www.a.o. I seem to remember that README files are not synched. Anyway, the file should be called README.html in order to show up a

Re: Download site could do with pointers to other releases and link to KEYS file

2011-09-07 Thread Hyrum K Wright
On Wed, Sep 7, 2011 at 6:34 AM, sebb wrote: > The Apache Subversion download site [1] only has a short list of files. > > There's no header or footer as is used by many other ASF products. > > It would be helpful to have some pointers to the Subversion archives, > and a link to the KEYS file, see

Re: Download site could do with pointers to other releases and link to KEYS file

2011-09-07 Thread sebb
On 7 September 2011 13:57, Hyrum K Wright wrote: > On Wed, Sep 7, 2011 at 6:34 AM, sebb wrote: >> The Apache Subversion download site [1] only has a short list of files. >> >> There's no header or footer as is used by many other ASF products. >> >> It would be helpful to have some pointers to the

Re: Download site could do with pointers to other releases and link to KEYS file

2011-09-07 Thread Daniel Shahaf
I think a HEADER.html that links to our download page (that already has all that information) would be fine? The download page can then link to the KEYS file and so on. sebb wrote on Wed, Sep 07, 2011 at 14:01:59 +0100: > On 7 September 2011 13:57, Hyrum K Wright wrote: > > On Wed, Sep 7, 2011 a

Re: Download site could do with pointers to other releases and link to KEYS file

2011-09-07 Thread sebb
On 7 September 2011 14:13, Daniel Shahaf wrote: > I think a HEADER.html that links to our download page (that already > has all that information) would be fine? That's not nearly as convenient as having the information on the same page (though a link to the download page would be useful). Also th

Re: fs-successor-ids: public API

2011-09-07 Thread Mark Phippard
2011/9/7 Branko Čibej : > On 06.09.2011 23:45, Daniel Shahaf wrote: >> How should the fs-successor-ids branch's new functionality be reflected >> in the API and the public API? >> >> The basic question is "Given PATH@REV, will it be moved or copied in the >> future?", and the use-cases Stefan has a

Re: Download site could do with pointers to other releases and link to KEYS file

2011-09-07 Thread Daniel Shahaf
I see your point. My intention was to avoid duplication of information. sebb wrote on Wed, Sep 07, 2011 at 14:23:52 +0100: > On 7 September 2011 14:13, Daniel Shahaf wrote: > > I think a HEADER.html that links to our download page (that already > > has all that information) would be fine? > > T

Re: Download site could do with pointers to other releases and link to KEYS file

2011-09-07 Thread Hyrum K Wright
On Wed, Sep 7, 2011 at 8:23 AM, sebb wrote: > On 7 September 2011 14:13, Daniel Shahaf wrote: >> I think a HEADER.html that links to our download page (that already >> has all that information) would be fine? > > That's not nearly as convenient as having the information on the same > page (though

Re: fs-successor-ids: public API

2011-09-07 Thread Hyrum K Wright
On Tue, Sep 6, 2011 at 4:45 PM, Daniel Shahaf wrote: > How should the fs-successor-ids branch's new functionality be reflected > in the API and the public API? > > The basic question is "Given PATH@REV, will it be moved or copied in the > future?", and the use-cases Stefan has also boil down to th

Re: svn commit: r1166096 - in /subversion/trunk/subversion: include/svn_repos.h svnadmin/main.c

2011-09-07 Thread Hyrum K Wright
On Wed, Sep 7, 2011 at 6:16 AM, Bert Huijben wrote: > > >> -Original Message- >> From: danie...@apache.org [mailto:danie...@apache.org] >> Sent: woensdag 7 september 2011 12:20 >> To: comm...@subversion.apache.org >> Subject: svn commit: r1166096 - in /subversion/trunk/subversion: >> inclu

Re: Download site could do with pointers to other releases and link to KEYS file

2011-09-07 Thread sebb
On 7 September 2011 13:57, sebb wrote: > On 7 September 2011 13:47, Daniel Shahaf wrote: >> On the same topic, I note that a README file is present in the dist dir >> on people.a.o, but not in the dist dir on www.a.o. > > I seem to remember that README files are not synched. Actually, they are s

Re: Download site could do with pointers to other releases and link to KEYS file

2011-09-07 Thread sebb
On 7 September 2011 14:31, Hyrum K Wright wrote: > On Wed, Sep 7, 2011 at 8:23 AM, sebb wrote: >> On 7 September 2011 14:13, Daniel Shahaf wrote: >>> I think a HEADER.html that links to our download page (that already >>> has all that information) would be fine? >> >> That's not nearly as conven

Re: svn commit: r1166184 - /subversion/branches/fs-successor-ids/subversion/libsvn_fs_fs/fs_fs.c

2011-09-07 Thread Daniel Shahaf
This will assert with % cat $REPOS/db/format 6 layout linear % s...@apache.org wrote on Wed, Sep 07, 2011 at 13:53:59 -: > Author: stsp > Date: Wed Sep 7 13:53:59 2011 > New Revision: 1166184 > > URL: http://svn.apache.org/viewvc?rev=1166184&view=rev > Log: > On the fs-successor-ids branch

Re: Download site could do with pointers to other releases and link to KEYS file

2011-09-07 Thread sebb
On 7 September 2011 14:58, sebb wrote: > On 7 September 2011 14:31, Hyrum K Wright wrote: >> On Wed, Sep 7, 2011 at 8:23 AM, sebb wrote: >>> On 7 September 2011 14:13, Daniel Shahaf wrote: I think a HEADER.html that links to our download page (that already has all that information) wo

Re: Download site could do with pointers to other releases and link to KEYS file

2011-09-07 Thread C. Michael Pilato
On 09/07/2011 10:22 AM, sebb wrote: > Samples available from: > > http://people.apache.org/~sebb/subversion/ > > I added some dummy files to show what it would look like. I can see the utility of some sort of header bit that says, essentially: This is a mirror of the Apache Subversion distri

Re: svn commit: r1166184 - /subversion/branches/fs-successor-ids/subversion/libsvn_fs_fs/fs_fs.c

2011-09-07 Thread Stefan Sperling
On Wed, Sep 07, 2011 at 05:19:19PM +0300, Daniel Shahaf wrote: > This will assert with > > % cat $REPOS/db/format > 6 > layout linear > % Good catch. The assert() is from code I copy-pasted. Will look into it.

Re: svn commit: r1166184 - /subversion/branches/fs-successor-ids/subversion/libsvn_fs_fs/fs_fs.c

2011-09-07 Thread Daniel Shahaf
Stefan Sperling wrote on Wed, Sep 07, 2011 at 16:46:21 +0200: > On Wed, Sep 07, 2011 at 05:19:19PM +0300, Daniel Shahaf wrote: > > This will assert with > > > > % cat $REPOS/db/format > > 6 > > layout linear > > % > > Good catch. The assert() is from code I copy-pasted. Will look into it. You ne

Re: Download site could do with pointers to other releases and link to KEYS file

2011-09-07 Thread Hyrum K Wright
On Wed, Sep 7, 2011 at 9:37 AM, C. Michael Pilato wrote: > On 09/07/2011 10:22 AM, sebb wrote: >> Samples available from: >> >> http://people.apache.org/~sebb/subversion/ >> >> I added some dummy files to show what it would look like. > > I can see the utility of some sort of header bit that says,

Re: fs-successor-ids: public API

2011-09-07 Thread Branko Čibej
On 07.09.2011 06:05, Branko Čibej wrote: > What specific questions are we likely to ask about a particular node > revision? The obvious ones are: > > * when was this "thing" created? (-> path@rev) > * when was it deleted? (-> path@rev) > * what is its immediate predecessor? (-> path@rev) >

Re: fs-successor-ids: public API

2011-09-07 Thread Branko Čibej
On 07.09.2011 15:33, Hyrum K Wright wrote: > I don't know your specific use cases, but invite you to consider the > following. Currently, we essentially have a system modeled after a > singly-linked list, where the links go backward in time. Adding the > successor id tracking effectively turns this

Re: svn commit: r1127134 - in /subversion/trunk/subversion: libsvn_client/add.c libsvn_wc/adm_ops.c tests/cmdline/tree_conflict_tests.py

2011-09-07 Thread Paul Burba
On Wed, Sep 7, 2011 at 3:01 AM, Stefan Sperling wrote: > On Tue, Sep 06, 2011 at 06:04:32PM -0400, Paul Burba wrote: >> On Tue, May 24, 2011 at 12:35 PM,   wrote: >> > Author: stsp >> > Date: Tue May 24 16:35:14 2011 >> > New Revision: 1127134 >> > >> > URL: http://svn.apache.org/viewvc?rev=112713

Are file externals good enough to release 1.7?

2011-09-07 Thread Philip Martin
I was looking at the proposed backport for issue 4000 (copies of file externals) to 1.7 and I'm not sure it fixes the problem--all sorts of things don't work. As far as I can see the fundamental problem is that file externals are always created at op-depth 0, even if the file external is locally a

Re: fs-successor-ids: public API

2011-09-07 Thread Daniel Shahaf
Brane, FYI, I tried to reply offlist but it bounced: : Host or domain name not found. Name service error for name=e-reka.si type=A: Host found but no data record of requested type Branko Čibej wrote on Wed, Sep 07, 2011 at 06:05:05 +0200: > On 06.09.2011 23:45, Daniel Shahaf wrote: > > How sh

Re: svn commit: r1166247 - in /subversion/branches/fs-successor-ids/subversion/libsvn_fs_fs: fs.h fs_fs.c

2011-09-07 Thread Daniel Shahaf
On Wednesday, September 07, 2011 4:16 PM, s...@apache.org wrote: > + /* Create successor-ID data for revision zero. */ >SVN_ERR(svn_io_file_open(&file, path_successor_ids(fs, 0, pool), > APR_WRITE | APR_BUFFERED | APR_CREATE, > APR_OS_DEF

Re: svn commit: r1166247 - in /subversion/branches/fs-successor-ids/subversion/libsvn_fs_fs: fs.h fs_fs.c

2011-09-07 Thread Daniel Shahaf
The code does not create the index for r1000 (the first revision of a non-first shard). On Wednesday, September 07, 2011 4:16 PM, s...@apache.org wrote: > Author: stsp > Date: Wed Sep 7 16:16:47 2011 > New Revision: 1166247 > > URL: http://svn.apache.org/viewvc?rev=1166247&view=rev > Log: > On

Re: svn commit: r1166247 - in /subversion/branches/fs-successor-ids/subversion/libsvn_fs_fs: fs.h fs_fs.c

2011-09-07 Thread Stefan Sperling
On Wed, Sep 07, 2011 at 07:31:05PM +0300, Daniel Shahaf wrote: > On Wednesday, September 07, 2011 4:16 PM, s...@apache.org wrote: > > + /* Create successor-ID data for revision zero. */ > >SVN_ERR(svn_io_file_open(&file, path_successor_ids(fs, 0, pool), > > APR_WRIT

Re: svn commit: r1166247 - in /subversion/branches/fs-successor-ids/subversion/libsvn_fs_fs: fs.h fs_fs.c

2011-09-07 Thread Stefan Sperling
On Wed, Sep 07, 2011 at 06:43:01PM +0200, Stefan Sperling wrote: > On Wed, Sep 07, 2011 at 07:31:05PM +0300, Daniel Shahaf wrote: > > On Wednesday, September 07, 2011 4:16 PM, s...@apache.org wrote: > > > + /* Create successor-ID data for revision zero. */ > > >SVN_ERR(svn_io_file_open(&file,

Re: fs-successor-ids: public API

2011-09-07 Thread Branko Čibej
On 07.09.2011 17:54, Daniel Shahaf wrote: > Brane, FYI, I tried to reply offlist but it bounced: > > : Host or domain name not found. Name service error for > name=e-reka.si type=A: Host found but no data record of requested type Well, well. Funny that this list's traffic goes to that address,

copying dirs with file externals involved

2011-09-07 Thread Neels J Hofmeyr
Hi Philip, I am responding to your 3rd comment in issue #4000: http://subversion.tigris.org/issues/show_bug.cgi?id=4000#desc5 [[[ If I set svn:externals in the copy and then run "svn up" I see a NODES row at op_depth 0: $ svn ps svn:externals '^/A/f g' wc/B $ svn up wc $ sqlite3 wc/.svn/wc.db "s

Re: Are file externals good enough to release 1.7?

2011-09-07 Thread Philip Martin
Philip Martin writes: > As far as I can see the fundamental problem is that > file externals are always created at op-depth 0, even if the file > external is locally added or copied: Thinking a bit more, I suppose that could work. We may not need to layer the file external NODES rows in the way

Re: Thoughts about issue #3625 (shelving)

2011-09-07 Thread Greg Stein
Hi Jeffrey, Thanks for writing. Stefan answers most of the high points, and I'll describe my own thoughts in-line below. Myself, or anyone that beats me to it, should probably start a notes/shelving document. Below: On Wed, Sep 7, 2011 at 03:51, Stefan Sperling wrote: > On Wed, Sep 07, 2011 at

Re: Are file externals good enough to release 1.7?

2011-09-07 Thread Neels J Hofmeyr
Hi all, I recently encountered (and started investigating) countless problems with file externals. I would humbly suggest that 1.7 still has poor file externals functionality ATM, and that this as such is not releaseworthy. But I think we could also still release and fix these things in backports

Re: svn commit: r1165787 - in /subversion/trunk: build.conf subversion/include/svn_delta.h subversion/libsvn_delta/compat.c subversion/tests/libsvn_delta/ subversion/tests/libsvn_delta/editor-test.c

2011-09-07 Thread Greg Stein
On Tue, Sep 6, 2011 at 15:06, wrote: >... > +++ subversion/trunk/subversion/include/svn_delta.h Tue Sep  6 19:06:38 2011 > @@ -42,6 +42,8 @@ >  #include "svn_io.h" >  #include "svn_checksum.h" > > +#include "private/svn_editor.h" > + >  #ifdef __cplusplus >  extern "C" { >  #endif /* __cplusplus

Re: Are file externals good enough to release 1.7?

2011-09-07 Thread Hyrum K Wright
On Wed, Sep 7, 2011 at 4:51 PM, Neels J Hofmeyr wrote: > Hi all, > > I recently encountered (and started investigating) countless problems with > file externals. I would humbly suggest that 1.7 still has poor file > externals functionality ATM, and that this as such is not releaseworthy. > > But I

Re: Thoughts about issue #3625 (shelving)

2011-09-07 Thread Stefan Sperling
On Wed, Sep 07, 2011 at 05:48:47PM -0400, Greg Stein wrote: > On Wed, Sep 7, 2011 at 03:51, Stefan Sperling wrote: > > A first-class 'shelving' feature wouldn't have to worry about conflicts. > > It would simply restore the working copy to the shelved state (either > > destroying unrelated local m

Re: svn commit: r1165787 - in /subversion/trunk: build.conf subversion/include/svn_delta.h subversion/libsvn_delta/compat.c subversion/tests/libsvn_delta/ subversion/tests/libsvn_delta/editor-test.c

2011-09-07 Thread Hyrum K Wright
On Wed, Sep 7, 2011 at 5:02 PM, Greg Stein wrote: > On Tue, Sep 6, 2011 at 15:06,   wrote: >>... >> +++ subversion/trunk/subversion/include/svn_delta.h Tue Sep  6 19:06:38 2011 >> @@ -42,6 +42,8 @@ >>  #include "svn_io.h" >>  #include "svn_checksum.h" >> >> +#include "private/svn_editor.h" >> + >>

Re: Are file externals good enough to release 1.7?

2011-09-07 Thread Neels J Hofmeyr
On 09/08/2011 12:04 AM, Hyrum K Wright wrote: > At this stage in the release process, my primary concern is "are these > issues a regression from 1.6?" File externals in 1.6 were a hack; are > we making things worse in 1.7? If things are on parity with 1.6, I > don't see this as being anything cl

[bug] Permissions of revision files get opened up upon packing

2011-09-07 Thread Daniel Shahaf
When a rev file has mode 0640 and it is packed while umask == 0022, the resulting pack and manifest files have mode 0644 again. I suspect it's due to the svn_io_set_file_read_only() call in pack_shard().

Re: [bug] Permissions of revision files get opened up upon packing

2011-09-07 Thread Daniel Shahaf
Daniel Shahaf wrote on Thu, Sep 08, 2011 at 04:42:37 +0300: > When a rev file has mode 0640 and it is packed while umask == 0022, > the resulting pack and manifest files have mode 0644 again. Filed issue #4014: http://subversion.tigris.org/issues/show_bug.cgi?id=4014

Re: svn commit: r1166332 - in /subversion/trunk/subversion: libsvn_delta/compat.c tests/libsvn_delta/editor-test.c

2011-09-07 Thread Daniel Shahaf
hwri...@apache.org wrote on Wed, Sep 07, 2011 at 19:36:01 -: > @@ -276,6 +345,60 @@ ev2_close_edit(void *edit_baton, > apr_pool_t *scratch_pool) > { >struct ev2_edit_baton *eb = edit_baton; > + apr_array_header_t *sorted_hash; > + apr_pool_t *iterpool; > + int i; > + > +

Re: crash opening Repository Browser for svn:// archives

2011-09-07 Thread Dave Huang
I have a reproducible crash when trying to open the repository browser, sparse - checkout selection, revision graph and probably other features. Reproduce: - "tortoiseproc /command:repobrowser /path:svn://somewhere" - enter your correct credentials It seems to only happen for svn:// repositories