Re: svn commit: r1103771 - in /subversion/trunk/subversion: libsvn_client/prop_commands.c svn/propedit-cmd.c svn/propget-cmd.c

2011-05-17 Thread Hyrum K Wright
On Tue, May 17, 2011 at 7:51 AM, Daniel Shahaf wrote: > hwri...@apache.org wrote on Mon, May 16, 2011 at 15:36:24 -: >> Author: hwright >> Date: Mon May 16 15:36:24 2011 >> New Revision: 1103771 >> >> URL: http://svn.apache.org/viewvc?rev=1103771&view=rev >> Log: >> Convert a bit of the recurs

Re: svn commit: r1103749 - /subversion/trunk/subversion/libsvn_wc/wc_db_wcroot.c

2011-05-17 Thread Greg Stein
On May 16, 2011 10:29 AM, wrote: > > Author: stefan2 > Date: Mon May 16 14:28:45 2011 > New Revision: 1103749 > > URL: http://svn.apache.org/viewvc?rev=1103749&view=rev > Log: > SVN status will try to read the .format file for every folder in > the working copy. That is very expensive, so do a st

Re: svn commit: r1103765 - in /subversion/trunk/subversion: libsvn_wc/update_editor.c libsvn_wc/wc_db.c libsvn_wc/wc_db.h tests/libsvn_wc/db-test.c tests/libsvn_wc/op-depth-test.c

2011-05-17 Thread Greg Stein
On May 16, 2011 11:36 AM, "Hyrum K Wright" wrote: > > On Mon, May 16, 2011 at 3:24 PM, wrote: > > Author: stefan2 > > Date: Mon May 16 15:24:59 2011 > > New Revision: 1103765 > > > > URL: http://svn.apache.org/viewvc?rev=1103765&view=rev > > Log: > > Finding the w/c base folder using svn_wc__db_

Re: svn commit: r1103671 - in /subversion/trunk/subversion/libsvn_wc: wc_db.c wc_db_pristine.c wc_db_private.h wc_db_wcroot.c

2011-05-17 Thread Greg Stein
On May 16, 2011 12:13 PM, wrote: > > Author: stefan2 > Date: Mon May 16 10:13:25 2011 > New Revision: 1103671 > > URL: http://svn.apache.org/viewvc?rev=1103671&view=rev > Log: > Reverse merged revision(s) 1103589 from subversion/trunk > after discussion with Bert. Maybe I missed it, but I think y

Re: svn commit: r1103582 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

2011-05-17 Thread Greg Stein
On May 16, 2011 2:15 AM, wrote: > > Author: hwright > Date: Mon May 16 00:14:39 2011 > New Revision: 1103582 > > URL: http://svn.apache.org/viewvc?rev=1103582&view=rev > Log: > When populating the targets list, don't bother calculating the parent_relpath, > when we already have that information in

Re: [RFC] let old svn's error properly in some 'svn1.7 checkout && svn1.6 status' scenarios

2011-05-17 Thread Daniel Shahaf
Julian Foad wrote on Mon, May 16, 2011 at 17:37:28 +0100: > On Mon, 2011-05-16 at 17:34 +0200, Daniel Shahaf wrote: > > Julian Foad wrote on Mon, May 16, 2011 at 15:49:52 +0100: > > > Daniel Shahaf wrote: > > > > Daniel Shahaf wrote on Mon, May 16, 2011 at 15:36:25 +0200: > > > we should update the

Re: svn commit: r1103771 - in /subversion/trunk/subversion: libsvn_client/prop_commands.c svn/propedit-cmd.c svn/propget-cmd.c

2011-05-17 Thread Daniel Shahaf
Hyrum K Wright wrote on Tue, May 17, 2011 at 07:21:43 +: > On Tue, May 17, 2011 at 7:51 AM, Daniel Shahaf > wrote: > > hwri...@apache.org wrote on Mon, May 16, 2011 at 15:36:24 -: > >> Author: hwright > >> Date: Mon May 16 15:36:24 2011 > >> New Revision: 1103771 > >> > >> URL: http://svn

Fwd: [Daniel Shahaf: Re: Properties lost on checkin]

2011-05-17 Thread Daniel Shahaf
Merging a symlink-add from a foreign repository loses the special status. There doesn't seem to be an open issue for that... - Forwarded message from Daniel Shahaf - > From: Daniel Shahaf > Subject: Re: Properties lost on checkin > To: Christoph Bartoschek > Cc: "us...@subversion.apac

Re: svn commit: r1103582 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

2011-05-17 Thread Hyrum K Wright
On Tue, May 17, 2011 at 8:11 AM, Greg Stein wrote: > On May 16, 2011 2:15 AM, wrote: >> >> Author: hwright >> Date: Mon May 16 00:14:39 2011 >> New Revision: 1103582 >> >> URL: http://svn.apache.org/viewvc?rev=1103582&view=rev >> Log: >> When populating the targets list, don't bother calculating

Re: svn commit: r1088609 - in /subversion/trunk/subversion: libsvn_wc/adm_ops.c tests/cmdline/special_tests.py

2011-05-17 Thread Daniel Shahaf
phi...@apache.org wrote on Mon, Apr 04, 2011 at 13:09:43 -: > +@SkipUnless(svntest.main.is_posix_os) > +def symlink_destination_change(sbox): > + "revert a symlink destination change" ... > + # Now replace the symlink with a normal file and try to commit, we You didn't commit the rest of the

Re: svn commit: r1104056 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

2011-05-17 Thread Hyrum K Wright
On Tue, May 17, 2011 at 8:47 AM, wrote: > Author: rhuijben > Date: Tue May 17 08:47:00 2011 > New Revision: 1104056 >... > Modified: subversion/trunk/subversion/libsvn_wc/wc_db.c > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/wc_db.c?rev=1104056&r1=1104055&r2=1104056

Re: svn commit: r1103838 - in /subversion/trunk/subversion/bindings/javahl/native: Prompter.cpp Prompter.h

2011-05-17 Thread Hyrum K Wright
On Mon, May 16, 2011 at 7:06 PM, Mark Phippard wrote: > On Mon, May 16, 2011 at 2:50 PM,   wrote: >> Author: markphip >> Date: Mon May 16 18:50:40 2011 >> New Revision: 1103838 >> >> URL: http://svn.apache.org/viewvc?rev=1103838&view=rev >> Log: >> JavaHL: Fixed JNI code to look for the new UserPa

Re: svn commit: r1103771 - in /subversion/trunk/subversion: libsvn_client/prop_commands.c svn/propedit-cmd.c svn/propget-cmd.c

2011-05-17 Thread Johan Corveleyn
On Tue, May 17, 2011 at 11:49 AM, Daniel Shahaf wrote: > Hyrum K Wright wrote on Tue, May 17, 2011 at 07:21:43 +: >> On Tue, May 17, 2011 at 7:51 AM, Daniel Shahaf >> wrote: >> > hwri...@apache.org wrote on Mon, May 16, 2011 at 15:36:24 -: >> >> Author: hwright >> >> Date: Mon May 16 15:

Re: [PATCH] -r { DATE } with words

2011-05-17 Thread Stefan Sperling
On Tue, May 17, 2011 at 12:45:50AM +0200, Stefan Sperling wrote: > Any comments or objections? Neels didn't like the arbitrary "round to 00:00 of next day" rules and everyone in the hackathon room seems to agree. So "one day ago" is now the same as "24 hours ago". I also dropped the "yesterday" k

Re: Fwd: [Daniel Shahaf: Re: Properties lost on checkin]

2011-05-17 Thread Daniel Shahaf
Added an XFail test, merge_foreign_repos(), to special_tests. Daniel Shahaf wrote on Tue, May 17, 2011 at 12:03:01 +0200: > Merging a symlink-add from a foreign repository loses the special status. > > There doesn't seem to be an open issue for that... > > - Forwarded message from Daniel Sha

Re: [PATCH] -r { DATE } with words

2011-05-17 Thread Daniel Shahaf
Offline I advocated for 'N days ago' to be rounded up/down to the full day. Stefan Sperling wrote on Tue, May 17, 2011 at 11:36:55 +0200: > On Tue, May 17, 2011 at 12:45:50AM +0200, Stefan Sperling wrote: > > Any comments or objections? > > Neels didn't like the arbitrary "round to 00:00 of next

Re: svn commit: r1103749 - /subversion/trunk/subversion/libsvn_wc/wc_db_wcroot.c

2011-05-17 Thread Stefan Fuhrmann
On 17.05.2011 10:11, Greg Stein wrote: On May 16, 2011 10:29 AM, wrote: Author: stefan2 Date: Mon May 16 14:28:45 2011 New Revision: 1103749 URL: http://svn.apache.org/viewvc?rev=1103749&view=rev Log: SVN status will try to read the .format file for every folder in the working copy. That is v

Re: svn commit: r1103671 - in /subversion/trunk/subversion/libsvn_wc: wc_db.c wc_db_pristine.c wc_db_private.h wc_db_wcroot.c

2011-05-17 Thread Stefan Fuhrmann
On 17.05.2011 10:11, Greg Stein wrote: On May 16, 2011 12:13 PM, wrote: Author: stefan2 Date: Mon May 16 10:13:25 2011 New Revision: 1103671 URL: http://svn.apache.org/viewvc?rev=1103671&view=rev Log: Reverse merged revision(s) 1103589 from subversion/trunk after discussion with Bert. Maybe I

Re: svn commit: r1104124 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/deprecated.c libsvn_subr/io.c

2011-05-17 Thread Julian Foad
Not directly related to your change, but I notice the impl. allows the passed-in string to be null if not wanted. Maybe the doc string should promise that, otherwise why bother? - Julian On Tue, 2011-05-17 at 10:55 +, danie...@apache.org wrote: > Author: danielsh > Date: Tue May 17 10:55:51

Re: svn commit: r1104124 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/deprecated.c libsvn_subr/io.c

2011-05-17 Thread Greg Stein
On Tue, May 17, 2011 at 06:55, wrote: >... > +++ subversion/trunk/subversion/libsvn_subr/deprecated.c Tue May 17 10:55:51 > 2011 > @@ -630,6 +630,17 @@ svn_opt_print_generic_help(const char *h > >  /*** From io.c ***/ >  svn_error_t * > +svn_io_file_create(const char *file, > +                  

Re: svn commit: r1104124 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/deprecated.c libsvn_subr/io.c

2011-05-17 Thread Hyrum K Wright
Are there still valid use cases for the normal cstring case? If so, we shouldn't be deprecating the old API, but rather adding a distinct API. -Hyrum On Tue, May 17, 2011 at 10:55 AM, wrote: > Author: danielsh > Date: Tue May 17 10:55:51 2011 > New Revision: 1104124 > > URL: http://svn.apache.

Re: [PATCH] -r { DATE } with words

2011-05-17 Thread Stefan Sperling
On Tue, May 17, 2011 at 01:13:31PM +0200, Daniel Shahaf wrote: > Offline I advocated for 'N days ago' to be rounded up/down to the full day. I'll commit it now without rounding and without the "now" keyword. We can then bikeshed about extending it.

Re: svn commit: r1104160 - /subversion/trunk/subversion/libsvn_subr/utf.c

2011-05-17 Thread Hyrum K Wright
On Tue, May 17, 2011 at 11:27 AM, wrote: > Author: stefan2 > Date: Tue May 17 11:27:25 2011 > New Revision: 1104160 > > URL: http://svn.apache.org/viewvc?rev=1104160&view=rev > Log: > Speed up UTF8 conversion, especially if APR_HAS_THREADS. > Provide global global ... ? > ... -Hyrum

Re: svn commit: r1104124 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/deprecated.c libsvn_subr/io.c

2011-05-17 Thread Daniel Shahaf
Julian Foad wrote on Tue, May 17, 2011 at 12:00:25 +0100: > Not directly related to your change, but I notice the impl. allows the > passed-in string to be null if not wanted. Maybe the doc string should > promise that, /me nods > otherwise why bother? > Because the existing code allowed NULLs

Re: svn commit: r1104160 - /subversion/trunk/subversion/libsvn_subr/utf.c

2011-05-17 Thread Ivan Zhakov
On Tue, May 17, 2011 at 13:27, wrote: > Author: stefan2 > Date: Tue May 17 11:27:25 2011 > New Revision: 1104160 > > URL: http://svn.apache.org/viewvc?rev=1104160&view=rev > Log: > Speed up UTF8 conversion, especially if APR_HAS_THREADS. > Provide global > > * subversion/libsvn_subr/utf.c >  (SVN

Re: svn commit: r1104124 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/deprecated.c libsvn_subr/io.c

2011-05-17 Thread Daniel Shahaf
Don't know; I haven't examined existing callers. It also turns out that I may not need the new (revv'd) API at all --- went a different way in the patch I'm working on --- so I may, after all, not add a user of the new API today (as I'd planned to). Hyrum K Wright wrote on Tue, May 17, 2011 at 11

Re: [PATCH] -r { DATE } with words

2011-05-17 Thread Daniel Shahaf
Stefan Sperling wrote on Tue, May 17, 2011 at 13:21:20 +0200: > On Tue, May 17, 2011 at 01:13:31PM +0200, Daniel Shahaf wrote: > > Offline I advocated for 'N days ago' to be rounded up/down to the full day. > > I'll commit it now without rounding and without the "now" keyword. > We can then bikesh

Re: svn commit: r1104124 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/deprecated.c libsvn_subr/io.c

2011-05-17 Thread Daniel Shahaf
Greg Stein wrote on Tue, May 17, 2011 at 07:12:58 -0400: > On Tue, May 17, 2011 at 06:55, wrote: > >... > > +++ subversion/trunk/subversion/libsvn_subr/deprecated.c Tue May 17 > > 10:55:51 2011 > > @@ -630,6 +630,17 @@ svn_opt_print_generic_help(const char *h > > > >  /*** From io.c ***/ > >  sv

Re: svn commit: r1104160 - /subversion/trunk/subversion/libsvn_subr/utf.c

2011-05-17 Thread Hyrum K Wright
apr_atomic_xchgptr() and friends are not available on APR 0.9. (This is causing a buildbot build failure.) -Hyrum On Tue, May 17, 2011 at 11:27 AM, wrote: > Author: stefan2 > Date: Tue May 17 11:27:25 2011 > New Revision: 1104160 > > URL: http://svn.apache.org/viewvc?rev=1104160&view=rev > Log

Re: [RFC] let old svn's error properly in some 'svn1.7 checkout && svn1.6 status' scenarios

2011-05-17 Thread Daniel Shahaf
r1104192, with thanks to Bert for pointing out the easiest place to add the upgrade codepath in.

Re: JavaHL - setConfigDirectory() method working?

2011-05-17 Thread Mark Phippard
On Mon, May 16, 2011 at 6:11 PM, Konstantin Kolinko wrote: > 2011/5/16 Mark Phippard : >> Looking at the code in trunk, it seems like this is coded properly and >> should be working.  I am seeing unexpected behavior.  Maybe I just do >> not understand how it works? >> >> In Subclipse we expose UI

Re: svn commit: r1104192 - in /subversion/trunk/subversion/libsvn_wc: adm_files.c wc.h workqueue.c

2011-05-17 Thread Greg Stein
On Tue, May 17, 2011 at 08:30, wrote: >... > +++ subversion/trunk/subversion/libsvn_wc/wc.h Tue May 17 12:30:03 2011 > @@ -166,6 +166,11 @@ extern "C" { >    rules. See issue #2475. */ >  #define SVN_WC__CHANGED_CANONICAL_URLS 10 > > +/* The format number written to wc-ng working copies so that o

Re: svn commit: r1104192 - in /subversion/trunk/subversion/libsvn_wc: adm_files.c wc.h workqueue.c

2011-05-17 Thread Greg Stein
On Tue, May 17, 2011 at 08:37, Greg Stein wrote: > On Tue, May 17, 2011 at 08:30,   wrote: >>... >> +++ subversion/trunk/subversion/libsvn_wc/wc.h Tue May 17 12:30:03 2011 >> @@ -166,6 +166,11 @@ extern "C" { >>    rules. See issue #2475. */ >>  #define SVN_WC__CHANGED_CANONICAL_URLS 10 >> >> +/*

Re: svn commit: r1104192 - in /subversion/trunk/subversion/libsvn_wc: adm_files.c wc.h workqueue.c

2011-05-17 Thread Daniel Shahaf
I'll fix both, thanks. Greg Stein wrote on Tue, May 17, 2011 at 08:38:15 -0400: > On Tue, May 17, 2011 at 08:37, Greg Stein wrote: > > On Tue, May 17, 2011 at 08:30,   wrote: > >>... > >> +++ subversion/trunk/subversion/libsvn_wc/wc.h Tue May 17 12:30:03 2011 > >> @@ -166,6 +166,11 @@ extern "C"

Re: svn commit: r1104209 - /subversion/trunk/subversion/libsvn_subr/utf.c

2011-05-17 Thread Ivan Zhakov
On Tue, May 17, 2011 at 14:54, wrote: > Author: stefan2 > Date: Tue May 17 12:54:57 2011 > New Revision: 1104209 > > URL: http://svn.apache.org/viewvc?rev=1104209&view=rev > Log: > Fix breakage with pre-1.3 APRs, introduced in r1104160. > Introduce a utility function that checks for APR  version

Re: svn commit: r1104208 - /subversion/trunk/subversion/tests/cmdline/lock_tests.py

2011-05-17 Thread Stephen Butler
I just mentioned to Johann that this is a duplicate of update_locked_deleted() in update_tests.py. Thanks to the test decorators, rgrep is useful for checking if an issue already has a test: ./lock_tests.py:1654:@Issue(3525) ./update_tests.py:5116:@Issue(3525) Steve On May 17, 2011, at 14:54 ,

op-depth-test 23 failure

2011-05-17 Thread Hyrum K Wright
I'm seeing the following failure on my Mac OS box, with trunk@1104228 [[[ dhcp207:libsvn_wc Hyrum$ ./op-depth-test 23 subversion/tests/libsvn_wc/op-depth-test.c:3431: (apr_err=150002) subversion/libsvn_client/copy.c:2443: (apr_err=150002) subversion/libsvn_client/copy.c:2268: (apr_err=150002) subv

Vetos in 1.6.x branch -- and how they impact trunk

2011-05-17 Thread Mark Phippard
There are some vetos in the 1.6.x branch that seem like they are questioning the change, not just whether it was a candidate for backport. What does that mean for trunk and 1.7? Here are the items I am thinking of (leaving out the items that were vetoed only because they were not considered appro

Re: svn commit: r1104209 - /subversion/trunk/subversion/libsvn_subr/utf.c

2011-05-17 Thread Stefan Fuhrmann
On 17.05.2011 15:01, Ivan Zhakov wrote: On Tue, May 17, 2011 at 14:54, wrote: Author: stefan2 Date: Tue May 17 12:54:57 2011 New Revision: 1104209 URL: http://svn.apache.org/viewvc?rev=1104209&view=rev Log: Fix breakage with pre-1.3 APRs, introduced in r1104160. Introduce a utility function th

Re: op-depth-test 23 failure

2011-05-17 Thread Stephen Butler
On May 17, 2011, at 15:28 , Hyrum K Wright wrote: > I'm seeing the following failure on my Mac OS box, with trunk@1104228 > > [[[ > dhcp207:libsvn_wc Hyrum$ ./op-depth-test 23 > subversion/tests/libsvn_wc/op-depth-test.c:3431: (apr_err=150002) > subversion/libsvn_client/copy.c:2443: (apr_err=150

Re: svn commit: r1101738 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

2011-05-17 Thread Daniel Shahaf
gst...@apache.org wrote on Wed, May 11, 2011 at 04:06:57 -: > +static svn_error_t * > +with_finalization(void *baton, @a BATON is unused. Could you add a docstring please? It seems that you call TXN_CB within a txn, then call WORK_CB (odd name IMO) with NOTIFY_FUNC, then run the FINALIZE_IDX

Re: JavaHL - setConfigDirectory() method working?

2011-05-17 Thread Konstantin Kolinko
2011/5/17 Mark Phippard : > On Mon, May 16, 2011 at 6:11 PM, Konstantin Kolinko > wrote: >> 2011/5/16 Mark Phippard : >>> Looking at the code in trunk, it seems like this is coded properly and >>> should be working.  I am seeing unexpected behavior.  Maybe I just do >>> not understand how it works

Re: svn commit: r1103578 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_client/update.c libsvn_wc/deprecated.c libsvn_wc/update_editor.c

2011-05-17 Thread Stefan Fuhrmann
On 17.05.2011 09:51, Daniel Shahaf wrote: stef...@apache.org wrote on Mon, May 16, 2011 at 00:02:06 -: Author: stefan2 Date: Mon May 16 00:02:05 2011 New Revision: 1103578 URL: http://svn.apache.org/viewvc?rev=1103578&view=rev Log: Eliminate unnecessary stat calls during checkout, part 1 of

Re: svn commit: r1104308 - in /subversion/trunk/subversion: libsvn_wc/wc_db.c tests/cmdline/revert_tests.py

2011-05-17 Thread Greg Stein
Philip: can you review my approach here? On Tue, May 17, 2011 at 10:59, wrote: > Author: gstein > Date: Tue May 17 14:59:21 2011 > New Revision: 1104308 > > URL: http://svn.apache.org/viewvc?rev=1104308&view=rev > Log: > Fix issue #3859 by rearranging the order of database operations, so that >

Re: svn commit: r1103413 - /subversion/trunk/subversion/libsvn_subr/cache-membuffer.c

2011-05-17 Thread Stefan Fuhrmann
On 16.05.2011 13:49, Daniel Shahaf wrote: stef...@apache.org wrote on Sun, May 15, 2011 at 14:52:22 -: Author: stefan2 Date: Sun May 15 14:52:22 2011 New Revision: 1103413 URL: http://svn.apache.org/viewvc?rev=1103413&view=rev Log: If an in-place modification of some cache entry failed, we

Re: Vetos in 1.6.x branch -- and how they impact trunk

2011-05-17 Thread Stefan Sperling
On Tue, May 17, 2011 at 09:48:07AM -0400, Mark Phippard wrote: > There are some vetos in the 1.6.x branch that seem like they are > questioning the change, not just whether it was a candidate for > backport. What does that mean for trunk and 1.7? Here are the items > I am thinking of (leaving out

Failure of --diff-cmd silently ignored

2011-05-17 Thread Daniel Shahaf
[[[ % $svn di --diff-cmd =false Index: subversion/include/svn_cache_config.h === Index: subversion/libsvn_subr/deprecated.c === Index: subversion/libsvn_wc/wc_db.c ===

Re: svn commit: r1101738 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

2011-05-17 Thread Greg Stein
On Tue, May 17, 2011 at 10:46, Daniel Shahaf wrote: > gst...@apache.org wrote on Wed, May 11, 2011 at 04:06:57 -: >> +static svn_error_t * >> +with_finalization(void *baton, > > @a BATON is unused. Yeah. I put it in there simply based on precedent and our consistent pattern for stuff like thi

Re: svn commit: r1103578 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_client/update.c libsvn_wc/deprecated.c libsvn_wc/update_editor.c

2011-05-17 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Tue, May 17, 2011 at 17:01:03 +0200: > On 17.05.2011 09:51, Daniel Shahaf wrote: >> stef...@apache.org wrote on Mon, May 16, 2011 at 00:02:06 -: >>> Author: stefan2 >>> Date: Mon May 16 00:02:05 2011 >>> New Revision: 1103578 >>> >>> URL: http://svn.apache.org/viewvc?re

Re: svn commit: r1101738 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

2011-05-17 Thread Daniel Shahaf
Greg Stein wrote on Tue, May 17, 2011 at 11:19:40 -0400: > On Tue, May 17, 2011 at 10:46, Daniel Shahaf wrote: > > gst...@apache.org wrote on Wed, May 11, 2011 at 04:06:57 -: > >> +static svn_error_t * > >> +with_finalization(void *baton, > > > > @a BATON is unused. > > Yeah. I put it in ther

Re: svn commit: r1094150 - in /subversion/trunk/subversion/libsvn_fs_fs: caching.c fs.h fs_fs.c fs_fs.h tree.c

2011-05-17 Thread Stefan Fuhrmann
On 16.05.2011 12:37, Daniel Shahaf wrote: Stefan Fuhrmann wrote on Sun, May 15, 2011 at 18:17:22 +0200: On 14.05.2011 03:54, Daniel Shahaf wrote: stef...@apache.org wrote on Sun, Apr 17, 2011 at 14:48:34 -: Author: stefan2 Date: Sun Apr 17 14:48:33 2011 New Revision: 1094150 URL: http://s

Re: svn commit: r1101738 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

2011-05-17 Thread Greg Stein
On Tue, May 17, 2011 at 11:26, Daniel Shahaf wrote: > Greg Stein wrote on Tue, May 17, 2011 at 11:19:40 -0400: >> On Tue, May 17, 2011 at 10:46, Daniel Shahaf wrote: >> > gst...@apache.org wrote on Wed, May 11, 2011 at 04:06:57 -: >> >> +static svn_error_t * >> >> +with_finalization(void *bat

Newly noticed 'svn revert' bug -- failure to obtain WC-NG lock

2011-05-17 Thread C. Michael Pilato
Just came across this while trying to get some work done. I present the following fairly minimal recipe: #!/bin/sh set -x REPOS=revert-lock-failure-repos WC=revert-lock-failure-wc rm -rf ${REPOS} ${WC} svnadmin create ${REPOS} svn c

Re: svn commit: r1101738 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

2011-05-17 Thread Greg Stein
On Tue, May 17, 2011 at 11:29, Greg Stein wrote: > On Tue, May 17, 2011 at 11:26, Daniel Shahaf wrote: >> Greg Stein wrote on Tue, May 17, 2011 at 11:19:40 -0400: >>> On Tue, May 17, 2011 at 10:46, Daniel Shahaf >>> wrote: >>> > gst...@apache.org wrote on Wed, May 11, 2011 at 04:06:57 -: >>

Re: svn commit: r1104356 - /subversion/trunk/CHANGES

2011-05-17 Thread Daniel Shahaf
s...@apache.org wrote on Tue, May 17, 2011 at 15:56:23 -: > Author: stsp > Date: Tue May 17 15:56:23 2011 > New Revision: 1104356 > > URL: http://svn.apache.org/viewvc?rev=1104356&view=rev > Log: > * CHANGES: Bring up-to-date with changes merged into 1.6.x. > > Modified: > subversion/trun

Re: buildbot failure in ASF Buildbot on svn-debian-x64-32-shared-gcc

2011-05-17 Thread Greg Stein
This op-depth-test failure is caused by my change to wc_db.c in r1104308. Looking into it... On Tue, May 17, 2011 at 11:52, wrote: > The Buildbot has detected a new failure on builder > svn-debian-x64-32-shared-gcc while building ASF Buildbot. > Full details are available at: >  http://ci.apach

Re: svn commit: r1104367 - /subversion/branches/1.6.x/STATUS

2011-05-17 Thread Daniel Shahaf
Shouldn't you include in the backport nomination the "subsequent revision" mention in r1104309's log message? [[[ NOTE: There is a remaining 3525-related test that is still failing (update_tests.py 53), but that's because of out-of-date expectations in the WC-NG world. (That will be fixed in a s

Re: svn commit: r1104367 - /subversion/branches/1.6.x/STATUS

2011-05-17 Thread C. Michael Pilato
On 05/17/2011 06:09 PM, Daniel Shahaf wrote: > Shouldn't you include in the backport nomination the "subsequent > revision" mention in r1104309's log message? > > [[[ > NOTE: There is a remaining 3525-related test that is still failing > (update_tests.py 53), but that's because of out-of-date exp

Re: svn commit: r1104309 - in /subversion/trunk/subversion: libsvn_repos/reporter.c tests/cmdline/lock_tests.py tests/cmdline/update_tests.py

2011-05-17 Thread Johan Corveleyn
On Tue, May 17, 2011 at 5:02 PM, wrote: > Author: cmpilato > Date: Tue May 17 15:02:05 2011 > New Revision: 1104309 > > URL: http://svn.apache.org/viewvc?rev=1104309&view=rev > Log: > With rhuijben, avoid transmitting entry props for unmodified, locked > files when the client-provided lock token

Re: svn commit: r1104308 - in /subversion/trunk/subversion: libsvn_wc/wc_db.c tests/cmdline/revert_tests.py

2011-05-17 Thread Greg Stein
I think that I'd like to try a SELECT/INSERT directly into revert_list, rather than using triggers. Thoughts? On Tue, May 17, 2011 at 11:02, Greg Stein wrote: > Philip: can you review my approach here? > > > On Tue, May 17, 2011 at 10:59,   wrote: >> Author: gstein >> Date: Tue May 17 14:59:21 20

svn_cache_config_t

2011-05-17 Thread Daniel Shahaf
Per our discussion, could you please move the cache_fulltexts and cache_txdeltas members of svn_cache_config_t into the FS config hash. (The reason being keeping the svn_cache interface neutral of its use.) P.S. This is an API change so it has to be done before 1.7.0. Thanks, -- [[[ typedef s

Re: svn commit: r1104408 - /subversion/trunk/subversion/tests/cmdline/prop_tests.py

2011-05-17 Thread Hyrum K Wright
For the record, proplist has been broken for a while. :) This test verifies that we fetch the right thing for a given node. My recent changes only changed which nodes the information is fetched on. In other words, I'm not really looking at this right now. -Hyrum On Tue, May 17, 2011 at 5:02 PM

Re: svn commit: r1104309 - in /subversion/trunk/subversion: libsvn_repos/reporter.c tests/cmdline/lock_tests.py tests/cmdline/update_tests.py

2011-05-17 Thread C. Michael Pilato
On 05/17/2011 06:34 PM, Johan Corveleyn wrote: > On Tue, May 17, 2011 at 5:02 PM, wrote: >> URL: >> http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_repos/reporter.c?rev=1104309&r1=1104308&r2=1104309&view=diff >>

enhancements for error reporting

2011-05-17 Thread Stefan Küng
Hi, Currently the svn command line client prints out (sometimes, if it's possible) some helpful messages telling the user what to do, e.g., run a cleanup or try an update. The problem I have in TSVN is that in most situations, the error code that's returned is not specific enough. For exampl

Re: svn commit: r1104323 - /subversion/trunk/subversion/tests/libsvn_wc/op-depth-test.c

2011-05-17 Thread Blair Zajac
On May 17, 2011, at 8:18 AM, rhuij...@apache.org wrote: > Author: rhuijben > Date: Tue May 17 15:18:19 2011 > New Revision: 1104323 > > URL: http://svn.apache.org/viewvc?rev=1104323&view=rev > Log: > * subversion/tests/libsvn_wc/op-derhuijben@apache.orgpth-test.c > (test_list): Mark test_case_r

r916286

2011-05-17 Thread Paul Burba
> Author: kameshj > Date: Thu Feb 25 13:40:22 2010 > New Revision: 916286 > > URL: http://svn.apache.org/viewvc?rev=916286&view=rev > Log: > With the below apache configuration(See the trailing slash at the end > of '/svn/'). > > > DAV svn > SVNParentPath /repositories > #See the trailing slash

Re: enhancements for error reporting

2011-05-17 Thread C. Michael Pilato
On 05/17/2011 08:54 PM, Stefan Küng wrote: > Hi, > > Currently the svn command line client prints out (sometimes, if it's > possible) some helpful messages telling the user what to do, e.g., run a > cleanup or try an update. > > The problem I have in TSVN is that in most situations, the error cod

Re: svn commit: r1104610 - in /subversion/trunk/subversion/libsvn_wc: props.c wc_db.c wc_db.h

2011-05-17 Thread Hyrum K Wright
I understand the desire to get the buildbots green again, and I'm sorry these revisions which I committed broke the bots, but a little patience might have been useful here. We have a long tradition of allowing folks to attempt to fix problems, rather than reverting their commits without consultati

RE: svn commit: r1104610 - in /subversion/trunk/subversion/libsvn_wc: props.c wc_db.c wc_db.h

2011-05-17 Thread Bert Huijben
> -Original Message- > From: Hyrum K Wright [mailto:hy...@hyrumwright.org] > Sent: woensdag 18 mei 2011 1:11 > To: dev@subversion.apache.org > Cc: comm...@subversion.apache.org > Subject: Re: svn commit: r1104610 - in > /subversion/trunk/subversion/libsvn_wc: props.c wc_db.c wc_db.h > > I

Re: svn commit: r1104620 - in /subversion/trunk/subversion/libsvn_ra_neon: commit.c fetch.c file_revs.c get_deleted_rev.c get_location_segments.c get_locations.c lock.c log.c mergeinfo.c props.c ra_ne

2011-05-17 Thread C. Michael Pilato
On 05/18/2011 01:06 AM, i...@apache.org wrote: > Author: ivan > Date: Tue May 17 23:06:37 2011 > New Revision: 1104620 > > URL: http://svn.apache.org/viewvc?rev=1104620&view=rev > Log: > Simplify ra_neon code a bit. > > * subversion/libsvn_ra_neon/props.c > * subversion/libsvn_ra_neon/ra_neon.h >

Re: enhancements for error reporting

2011-05-17 Thread Stefan Küng
On Tue, May 17, 2011 at 22:55, C. Michael Pilato wrote: > On 05/17/2011 08:54 PM, Stefan Küng wrote: >> Hi, >> >> Currently the svn command line client prints out (sometimes, if it's >> possible) some helpful messages telling the user what to do, e.g., run a >> cleanup or try an update. >> >> The

[PATCH] Speed-up of libsvn_diff using token counts

2011-05-17 Thread Morten Kloster
Log message: Speed-up of libsvn_diff using token counts By using indices, not node pointers, to refer to tokens, and counting the number of each token, the longest common subsequence (lcs) algorithm at the heart of libsvn_diff becomes much faster in many situations by skipping tokens that are uniq

Re: svn commit: r1104309 - in /subversion/trunk/subversion: libsvn_repos/reporter.c tests/cmdline/lock_tests.py tests/cmdline/update_tests.py

2011-05-17 Thread Johan Corveleyn
On Tue, May 17, 2011 at 7:13 PM, C. Michael Pilato wrote: > On 05/17/2011 06:34 PM, Johan Corveleyn wrote: >> On Tue, May 17, 2011 at 5:02 PM,   wrote: >>> URL: >>> http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_repos/reporter.c?rev=1104309&r1=1104308&r2=1104309&view=diff >>> ===

Re: [PATCH] Speed-up of libsvn_diff using token counts

2011-05-17 Thread Johan Corveleyn
On Wed, May 18, 2011 at 1:56 AM, Morten Kloster wrote: > Log message: > > Speed-up of libsvn_diff using token counts > By using indices, not node pointers, to refer to tokens, and counting > the number of each token, the longest common subsequence (lcs) > algorithm at the heart of libsvn_diff beco

[random line of thought] Hiding svn:mergeinfo

2011-05-17 Thread Daniel Shahaf
Mike remarked that svn:mergeinfo should never have been user-visible... So: what if we made svn_property_kind(NULL, SVN_PROP_MERGEINFO) return a value other than svn_prop_regular_kind, at least when both server and client were ≥1.7? Would that have any useful side-effects? [I suspect it might,