On Mon, May 16, 2011 at 7:06 PM, Mark Phippard <markp...@gmail.com> wrote: > On Mon, May 16, 2011 at 2:50 PM, <markp...@apache.org> wrote: >> Author: markphip >> Date: Mon May 16 18:50:40 2011 >> New Revision: 1103838 >> >> URL: http://svn.apache.org/viewvc?rev=1103838&view=rev >> Log: >> JavaHL: Fixed JNI code to look for the new UserPasswordCallback class >> in place of the old PromptUserPasswordN classes. Also removed/updated >> code comments that referenced the old class. >> >> Our test suite does not exercise this code unless you run the JavaHL >> tests against https:// repository (which no one does). >> >> [ in subversion/bindings/javahl/ ] >> >> * native/Prompter.cpp >> Replaced references to PromptUserPasswordN with UserPasswordCallback. >> Also removed and updated stale comments. >> >> * native/Prompter.h >> Removed stale comments. > > Hyrum, > > I did a simple audit of the JavaHL C++ code after this. Basically I > grepped for: > > "env->FindClass(JAVA_PACKAGE" > > These are the only two remaining suspicious items. Could you take a look? > > Revision.cpp (line 161): > > JNIEnv *env = JNIUtil::getEnv(); > jclass clazz = env->FindClass(JAVA_PACKAGE "/Revision"); > if (JNIUtil::isJavaExceptionThrown()) > return NULL; > > > And SVNRepos.cpp (line 638): > > JNIEnv *env = JNIUtil::getEnv(); > jclass clazz = env->FindClass(JAVA_PACKAGE"/Lock"); > if (JNIUtil::isJavaExceptionThrown()) > return NULL; > > In both cases, those items are now in the "types" package. Attaching > a patch to change those.
Thanks for the audit, it was needed. The patch looks good and it passes the tests locally. +1 to commit (not that you need it...) -Hyrum
