[PATCH] Fix for issue 3799 - exporting file should not overwrite

2011-02-15 Thread Noorul Islam K M
More details about the issue can be found here. http://subversion.tigris.org/issues/show_bug.cgi?id=3799 Using trunk when exporting a file, if the file already exists at target location then operation overwrites the file without giving any warning. But in the case of directory it throws an error

Re: Further diff optimization ideas

2011-02-15 Thread Branko Čibej
On 15.02.2011 01:42, Johan Corveleyn wrote: > 2) Faster hash function for hashing lines. [ Quick win ] > > - Currently, we use adler32 (after the line has been normalized). > > - GNU diff uses some simple bit shifting scheme, which seems to be a > lot faster (maybe it has more hash-collisions, but

Re: Patches pending review

2011-02-15 Thread Daniel Becroft
On Tue, Feb 15, 2011 at 9:48 AM, Hyrum K Wright wrote: > On Mon, Feb 14, 2011 at 11:33 AM, Noorul Islam K M > wrote: > > > > See below in line more information about the patches. > > > > Noorul Islam K M writes: > ... > >> 3. Issue 3690 > >> > >>http://svn.haxx.se/dev/archive-2011-01/0414.sh

Re: Patches pending review

2011-02-15 Thread Noorul Islam K M
Daniel Becroft writes: > On Tue, Feb 15, 2011 at 9:48 AM, Hyrum K Wright < > hy...@hyrumwright.org> wrote: > > On Mon, Feb 14, 2011 at 11:33 AM, Noorul Islam K M < > noo...@collab.net> wrote: > > > > See below in line more information about the patches. > > > > Noorul Isla

Re: [Proposal] Remove DAV properties cache in ra_serf

2011-02-15 Thread Justin Erenkrantz
On Mon, Feb 14, 2011 at 7:57 PM, Ivan Zhakov wrote: > Of course these problems can be fixed, but I'm not sure that we need > this code. Since in svn 1.7 we have HTTPv2 which doesn't use so many > PROPFIND requests that we tried to reduce using DAV properties cache. > > So I'm propose just to remov

Re: [Proposal] Remove DAV properties cache in ra_serf

2011-02-15 Thread Hyrum K Wright
On Tue, Feb 15, 2011 at 6:42 AM, Greg Stein wrote: > On Mon, Feb 14, 2011 at 14:14, C. Michael Pilato wrote: >> On 02/14/2011 01:57 PM, Ivan Zhakov wrote: >>> Hi, >>> >>> Currently ra_serf caches *all* DAV properties retrieved using PROPFIND >>> in session pool. This was attempt to reduce number

RE: [Proposal] Remove DAV properties cache in ra_serf

2011-02-15 Thread Bert Huijben
> -Original Message- > From: Hyrum K Wright [mailto:hy...@hyrumwright.org] > Sent: dinsdag 15 februari 2011 11:44 > To: Greg Stein > Cc: C. Michael Pilato; Ivan Zhakov; dev@subversion.apache.org > Subject: Re: [Proposal] Remove DAV properties cache in ra_serf > > On Tue, Feb 15, 2011 at

Re: [Proposal] Remove DAV properties cache in ra_serf

2011-02-15 Thread Hyrum K Wright
On Tue, Feb 15, 2011 at 10:47 AM, Bert Huijben wrote: > > >> -Original Message- >> From: Hyrum K Wright [mailto:hy...@hyrumwright.org] >> Sent: dinsdag 15 februari 2011 11:44 >> To: Greg Stein >> Cc: C. Michael Pilato; Ivan Zhakov; dev@subversion.apache.org >> Subject: Re: [Proposal] Remov

Re: Further diff optimization ideas

2011-02-15 Thread Johan Corveleyn
2011/2/15 Branko Čibej : > On 15.02.2011 01:42, Johan Corveleyn wrote: >> 2) Faster hash function for hashing lines. [ Quick win ] >> >> - Currently, we use adler32 (after the line has been normalized). >> >> - GNU diff uses some simple bit shifting scheme, which seems to be a >> lot faster (maybe

Re: [Proposal] Remove DAV properties cache in ra_serf

2011-02-15 Thread Ivan Zhakov
On Tue, Feb 15, 2011 at 11:23, Justin Erenkrantz wrote: > On Mon, Feb 14, 2011 at 7:57 PM, Ivan Zhakov wrote: >> Of course these problems can be fixed, but I'm not sure that we need >> this code. Since in svn 1.7 we have HTTPv2 which doesn't use so many >> PROPFIND requests that we tried to reduc

Re: [Proposal] Remove DAV properties cache in ra_serf

2011-02-15 Thread Mark Phippard
On Tue, Feb 15, 2011 at 7:21 AM, Ivan Zhakov wrote: > Thanks for feedback! > > I removed DAV properties cache from ra_serf in r1070861. Does this improve the memory usage on checkout that others have brought up? -- Thanks Mark Phippard http://markphip.blogspot.com/

Re: SQLite and callbacks

2011-02-15 Thread Stefan Sperling
On Mon, Feb 14, 2011 at 09:48:35PM +0100, Branko Čibej wrote: > On 14.02.2011 13:37, Stefan Sperling wrote: > > On Tue, Feb 08, 2011 at 11:50:36PM +0100, Branko Čibej wrote: > >> Well, here it is, I fixed the thinko in the actual_props query and got > >> all prop_tests to pass with this version. >

Re: [Proposal] Remove DAV properties cache in ra_serf

2011-02-15 Thread Ivan Zhakov
On Tue, Feb 15, 2011 at 14:26, Mark Phippard wrote: > On Tue, Feb 15, 2011 at 7:21 AM, Ivan Zhakov wrote: > >> Thanks for feedback! >> >> I removed DAV properties cache from ra_serf in r1070861. > > Does this improve the memory usage on checkout that others have brought up? > It improves memory u

[PATCH] New test - Follow-up to r1070508 - add with multiple targets.

2011-02-15 Thread Noorul Islam K M
Log [[[ Follow-up to r1070508. Add new test for 'svn add' with multiple targets. * subversion/tests/cmdline/basic_tests.py (add_multiple_targets): New test (test_list): Add reference to new test. Patch by: Noorul Islam K M ]]] Index: subversion/tests/cmdline/basic_tests.py ===

Re: SQLite and callbacks

2011-02-15 Thread Stefan Sperling
On Tue, Feb 15, 2011 at 01:30:45PM +0100, Stefan Sperling wrote: > On Mon, Feb 14, 2011 at 09:48:35PM +0100, Branko Čibej wrote: > > On 14.02.2011 13:37, Stefan Sperling wrote: > > > On Tue, Feb 08, 2011 at 11:50:36PM +0100, Branko Čibej wrote: > > >> Well, here it is, I fixed the thinko in the act

Re: [PATCH] New test - Follow-up to r1070508 - add with multiple targets.

2011-02-15 Thread Stefan Sperling
On Tue, Feb 15, 2011 at 08:07:10PM +0530, Noorul Islam K M wrote: > > Log > [[[ > > Follow-up to r1070508. Add new test for 'svn add' with multiple targets. > > * subversion/tests/cmdline/basic_tests.py > (add_multiple_targets): New test > (test_list): Add reference to new test. > > Patch b

Pristine store - spec

2011-02-15 Thread Julian Foad
Would anyone be able to review this spec please? I'm trying to get straight what locking / access control rules need to be. /* * THE PRISTINE STORE * == * * === Introduction === * * The Pristine Store is the part of the Working Copy metadata that holds * a local copy of the

Re: Patches pending review

2011-02-15 Thread Stefan Sperling
On Tue, Feb 15, 2011 at 02:49:12PM +0530, Noorul Islam K M wrote: > Daniel Becroft writes: > > > On Tue, Feb 15, 2011 at 9:48 AM, Hyrum K Wright < > > hy...@hyrumwright.org> wrote: > > > > On Mon, Feb 14, 2011 at 11:33 AM, Noorul Islam K M < > > noo...@collab.net> wrote: > > > > >

Re: Patches pending review

2011-02-15 Thread Stefan Sperling
On Tue, Feb 15, 2011 at 04:27:16PM +0100, Stefan Sperling wrote: > In the meantime, there are quite a number of issues with milestones > 1.7.0 and 1.7-consider. Those are likely to catch more attention at > the moment, since everyone is focused on getting the release done. > > See these two links:

Re: SQLite and callbacks

2011-02-15 Thread Hyrum K Wright
On Tue, Feb 15, 2011 at 2:53 PM, Stefan Sperling wrote: > On Tue, Feb 15, 2011 at 01:30:45PM +0100, Stefan Sperling wrote: >> On Mon, Feb 14, 2011 at 09:48:35PM +0100, Branko Čibej wrote: >> > On 14.02.2011 13:37, Stefan Sperling wrote: >> > > On Tue, Feb 08, 2011 at 11:50:36PM +0100, Branko Čibej

Re: SQLite and callbacks

2011-02-15 Thread Stefan Sperling
On Tue, Feb 15, 2011 at 03:35:43PM +, Hyrum K Wright wrote: > I've not reviewed the patch, but to the question about bumping the wc > format, I think you're safe to do so (so long as the upgrade code is > properly implemented / tested, etc). > > The current working copy much more gracefully ha

Re: Further diff optimization ideas

2011-02-15 Thread Branko Čibej
On 15.02.2011 13:04, Johan Corveleyn wrote: >> In other news, why do we need our own hash function anyway? Or our own >> table or tree or whatever? NIH syndrome? > No idea, really. I'm probably not the guy you're expecting an answer > from :-), but: > - apr_hashfunc_default could be very useful her

Re: Pristine store - spec

2011-02-15 Thread Greg Stein
On Tue, Feb 15, 2011 at 10:06, Julian Foad wrote: >... >  * Operating Procedures >  * >  * The steps should be carried out in the order specified.  (See rationale.) >  * >  * * To add a pristine, do the following inside an SDB txn: >  *      * Add the table row, and set the refcount as d

Re: Patches pending review

2011-02-15 Thread Noorul Islam K M
Stefan Sperling writes: > On Tue, Feb 15, 2011 at 02:49:12PM +0530, Noorul Islam K M wrote: > >> Daniel Becroft writes: >> >> > On Tue, Feb 15, 2011 at 9:48 AM, Hyrum K Wright < >> > hy...@hyrumwright.org> wrote: >> > >> > On Mon, Feb 14, 2011 at 11:33 AM, Noorul Islam K M < >> > noo...

[PATCH] New tests for 'svn info' with multiple targets.

2011-02-15 Thread Noorul Islam K M
Log [[[ Add new tests for 'svn info' with multiple targets. * subversion/tests/cmdline/info_tests.py (info_multiple_wc_targets, info_multiple_url_targets): New tests. (test_list): Add reference to new test. Patch by: Noorul Islam K M ]]] Index: subversion/tests/cmdline/info_tests.py =

Is the svn:// protocol secure when encrypted via SASL?

2011-02-15 Thread Keith Palmer Jr.
We'd like to use the svn:// protocol to check out some code over a WAN, but we want to make sure that the code isn't traveling over the WAN in plain-text. If we set up the repo to require min-compression 128 via SASL, does that encrypt *just the authentication* or does that *encrypt the actual

Re: Is the svn:// protocol secure when encrypted via SASL?

2011-02-15 Thread Mark Phippard
On Tue, Feb 15, 2011 at 4:11 PM, Keith Palmer Jr. wrote: > > We'd like to use the svn:// protocol to check out some code over a WAN, but > we want to make sure that the code isn't traveling over the WAN in plain-text. > > If we set up the repo to require min-compression 128 via SASL, does that >

Re: Is the svn:// protocol secure when encrypted via SASL?

2011-02-15 Thread Keith Palmer Jr.
I tried to capture the traffic with Wireshark, but it appears that everything is compressed over the wire anyway... so I can't tell if I'm looking at just compressed data, or compressed+encrypted data. --- - Keith Palmer ConsoliBYTE, LLC Ask for a quote! - QuickBooks Integration and Sof

Re: Is the svn:// protocol secure when encrypted via SASL?

2011-02-15 Thread Daniel Shahaf
Keith Palmer Jr. wrote on Tue, Feb 15, 2011 at 16:26:19 -0500: > > I tried to capture the traffic with Wireshark, but it appears that > everything is compressed over the wire anyway... so I can't tell if > I'm looking at just compressed data, or compressed+encrypted data. Decompress it then?

Re: Is the svn:// protocol secure when encrypted via SASL?

2011-02-15 Thread Daniel Shahaf
Keith Palmer Jr. wrote on Tue, Feb 15, 2011 at 16:11:48 -0500: > I've asked just about everywhere else and can't seem to get a straight > answer out of anyone- some people say yes, some people say no. Mark's advice said, I think the correct answer is "it depends on the SASL module being used" ---

Re: svn commit: r1070980 - /subversion/trunk/subversion/svnrdump/load_editor.c

2011-02-15 Thread Daniel Shahaf
CC += artagnon Ramkumar, I think the lesson from Mike and I's recent fixes is: "Mark unreachable code with a run-time assertion, not with a source comment". i.e., if those places were marked with SVN__NOT_IMPLEMENTED(), debugging would have been easier. (Tests pass if I add a SVN__NOT_IMPLEMENTE

Re: svn commit: r1070980 - /subversion/trunk/subversion/svnrdump/load_editor.c

2011-02-15 Thread Daniel Shahaf
Daniel Shahaf wrote on Wed, Feb 16, 2011 at 05:29:58 +0200: > (Tests pass if I add a SVN__NOT_IMPLEMENTED() to that function.) > On the other hand, some tests fail if I add SVN__NOT_IMPLEMENTED() to remove_node_props(). Another one for the todo list... > cmpil...@apache.org wrote on Tue, Feb 15

contribute for subversion project

2011-02-15 Thread Kapila Witharana
Hi, I'm Kapila, a student of Post Graduate Division of University of Colombo School of Computing (UCSC), University of Colombo, Sri Lanka. I'm now looking for a research level project (1 year) for my final year project. Could you please let me know, whether there are any opportunity to contribute

[PATCH] Fix for issue 3742

2011-02-15 Thread Noorul Islam K M
Issue description: 'svn status' should reported nested working copies as unversioned regardless of the format of their working copies. Issue link: http://subversion.tigris.org/issues/show_bug.cgi?id=3742 All tests pass using 'make check' Log [[[ Make 'svn status' report nested working copies