Re: svn_fs_lock multiple paths

2014-02-07 Thread Julian Foad
Branko Čibej wrote: > On 07.02.2014 12:55, Julian Foad wrote: >> I don't know why the FS API allows non-canonical paths in the first place >> but (assuming the whole FS API is fairly consistent about this, which I >> haven't checked) > > Because we realized some time ago that sanitizing data only

Re: svn_fs_lock multiple paths

2014-02-07 Thread Branko Čibej
On 07.02.2014 12:55, Julian Foad wrote: > I don't know why the FS API allows non-canonical paths in the first > place but (assuming the whole FS API is fairly consistent about this, > which I haven't checked) Because we realized some time ago that sanitizing data only in the client or repos layers

Re: svn_fs_lock multiple paths

2014-02-07 Thread Julian Foad
Philip Martin wrote: >> I'm working on a new svn_fs_lock that allows multiple paths to be >> locked.  This is to avoid the inefficiency of writing the large digest >> files multiple times when locking multiple paths one at a time.  I have >> the low level file handling written but the plumbing to c

Re: svn_fs_lock multiple paths

2014-02-07 Thread Philip Martin
Philip Martin writes: > I'm working on a new svn_fs_lock that allows multiple paths to be > locked. This is to avoid the inefficiency of writing the large digest > files multiple times when locking multiple paths one at a time. I have > the low level file handling written but the plumbing to co

Re: svn_fs_lock multiple paths

2014-02-06 Thread Bert Huijben
I think swallowing (and logging) the post lock error is the best thing we can do for the old api. I think anything else would require extending the Ra layer api (or moving further away from using multiple path at the same time), The callback handles any error as 'the lock failed’. Given all th

Re: svn_fs_lock multiple paths

2014-02-06 Thread Philip Martin
Philip Martin writes: > The current behaviour is not very good. Since the low level svn_fs_lock > only handles one path there is currently a post-lock for each path, so > we need to return both the post-lock error and the lock token for each > path. > > How should it work when we have an svn_fs_

Re: svn_fs_lock multiple paths

2014-02-06 Thread Philip Martin
Philip Martin writes: > On a related note, the post-lock is weird. It gets the username as a > parameter and multiple paths on stdin. The comments in the hook > template refer to using svnlook to examine the lock, but that won't work > reliably since the post-lock is asynchronous. So the only

svn_fs_lock multiple paths

2014-02-06 Thread Philip Martin
I'm working on a new svn_fs_lock that allows multiple paths to be locked. This is to avoid the inefficiency of writing the large digest files multiple times when locking multiple paths one at a time. I have the low level file handling written but the plumbing to connect it all up is a bit tricky.