Re: svn commit: r1757532 - /subversion/trunk/subversion/mod_dav_svn/repos.c

2016-08-26 Thread Ivan Zhakov
On 26 August 2016 at 14:27, Evgeny Kotkov wrote: > Ivan Zhakov writes: > >>> @@ -3266,15 +3264,13 @@ static svn_error_t * __attribute__((war >>> close_filter(void *baton) >>> { >>>diff_ctx_t *dc = baton; >>> - apr_bucket_brigade *bb; >>>apr_bucket *bkt; >>>apr_status_t status; >>>

Re: svn commit: r1757532 - /subversion/trunk/subversion/mod_dav_svn/repos.c

2016-08-26 Thread Evgeny Kotkov
Ivan Zhakov writes: >> @@ -3266,15 +3264,13 @@ static svn_error_t * __attribute__((war >> close_filter(void *baton) >> { >>diff_ctx_t *dc = baton; >> - apr_bucket_brigade *bb; >>apr_bucket *bkt; >>apr_status_t status; >> >>/* done with the file. write an EOS bucket now. */ >>

Re: svn commit: r1757532 - /subversion/trunk/subversion/mod_dav_svn/repos.c

2016-08-26 Thread Ivan Zhakov
On 24 August 2016 at 17:43, wrote: > Author: kotkov > Date: Wed Aug 24 14:43:21 2016 > New Revision: 1757532 > > URL: http://svn.apache.org/viewvc?rev=1757532&view=rev > Log: > In mod_dav_svn, rewrite the code responsible for answering to GET requests > with a specified delta base, so that it wou

Re: svn commit: r1757532 - /subversion/trunk/subversion/mod_dav_svn/repos.c

2016-08-24 Thread Evgeny Kotkov
Stefan Hett writes: > Would this (and your other two commits) be something which should be > considered to backport to 1.9 (and maybe even 1.8)? As far as I was > following the history of this, it sounds like a reasonable improvement > worth for a backport, no? Sure, I'll nominate them tomorrow.

Re: svn commit: r1757532 - /subversion/trunk/subversion/mod_dav_svn/repos.c

2016-08-24 Thread Stefan
On 8/24/2016 20:07, Evgeny Kotkov wrote: > Bert Huijben writes: > >> Nice fix :-) >> >> Do you have any numbers on the resulting memory usage compared to the >> previous version. I would imagine that this could really help on updates >> with a lot of files, especially on threaded apache. > Thanks!

Re: svn commit: r1757532 - /subversion/trunk/subversion/mod_dav_svn/repos.c

2016-08-24 Thread Evgeny Kotkov
Bert Huijben writes: > Nice fix :-) > > Do you have any numbers on the resulting memory usage compared to the > previous version. I would imagine that this could really help on updates > with a lot of files, especially on threaded apache. Thanks! The difference is 32 bytes per every svn_stream_

RE: svn commit: r1757532 - /subversion/trunk/subversion/mod_dav_svn/repos.c

2016-08-24 Thread Bert Huijben
> -Original Message- > From: kot...@apache.org [mailto:kot...@apache.org] > Sent: woensdag 24 augustus 2016 16:43 > To: comm...@subversion.apache.org > Subject: svn commit: r1757532 - > /subversion/trunk/subversion/mod_dav_svn/repos.c > > Author: kotkov > Dat