Re: multi-wc-format: svn_wc__format_from_version()

2022-03-17 Thread Julian Foad
Daniel Shahaf wrote: > It doesn't seem to be an old function; the docstring says (in a part I > snipped) it's new in 1.15. However, I don't think that changes the answer. > Done in r1899004. Oh, just older than my involvement then! Thanks. - Julian

Re: multi-wc-format: svn_wc__format_from_version()

2022-03-17 Thread Daniel Shahaf
Julian Foad wrote on Thu, 17 Mar 2022 20:33 +00:00: > That's an old function. "Characteristic" previously meant the only > format supported by a given client version. We should change the word > now. What should the function return now? The newest, I think: its > callers are upgrade and checkout

Re: multi-wc-format: svn_wc__format_from_version()

2022-03-17 Thread Julian Foad
That's an old function. "Characteristic" previously meant the only format supported by a given client version. We should change the word now. What should the function return now? The newest, I think: its callers are upgrade and checkout; essentially it is used to implement the --bikeshed=1.15 op

multi-wc-format: svn_wc__format_from_version()

2022-03-17 Thread Daniel Shahaf
Here's the docstring: [[[ /** * Convert @a version to that version's characteristic working copy * format, returned in @a format. * * A NULL @a version translates to the library's default version. ⋮ */ svn_error_t * svn_wc__format_from_version(int *format, const s