Re: svn commit: r999785 - /subversion/trunk/subversion/libsvn_subr/svn_string.c

2010-09-22 Thread Daniel Shahaf
Stefan Sperling wrote on Wed, Sep 22, 2010 at 14:15:52 +0200: > On Wed, Sep 22, 2010 at 12:59:49PM +0200, Daniel Shahaf wrote: > > Philip Martin wrote on Wed, Sep 22, 2010 at 11:47:19 +0100: > > > Daniel Shahaf writes: > > > > minval is an apr_uint64_t, so shouldn't the format string use > > > >

Re: svn commit: r999785 - /subversion/trunk/subversion/libsvn_subr/svn_string.c

2010-09-22 Thread Philip Martin
Julian Foad writes: > It might be worth adding a pool parameter so that any of the > print-into-a-substing variants can be used. Perhaps we can avoid these complications in the code. Could we invoke the C pre-processor during the po-update stuff? Perhaps on the output of gettext? -- Philip

Re: svn commit: r999785 - /subversion/trunk/subversion/libsvn_subr/svn_string.c

2010-09-22 Thread Stefan Sperling
On Wed, Sep 22, 2010 at 12:59:49PM +0200, Daniel Shahaf wrote: > Philip Martin wrote on Wed, Sep 22, 2010 at 11:47:19 +0100: > > Daniel Shahaf writes: > > > minval is an apr_uint64_t, so shouldn't the format string use > > > APR_UINT64_FMT? > > > > See this thread > > > > http://svn.haxx.se/dev

Re: svn commit: r999785 - /subversion/trunk/subversion/libsvn_subr/svn_string.c

2010-09-22 Thread Julian Foad
Philip Martin wrote: > Daniel Shahaf writes: > > > Philip Martin wrote on Wed, Sep 22, 2010 at 11:47:19 +0100: > >> Daniel Shahaf writes: > >> > minval is an apr_uint64_t, so shouldn't the format string use > >> > APR_UINT64_FMT? > >> > >> See this thread > >> > >> http://svn.haxx.se/dev/arch

Re: svn commit: r999785 - /subversion/trunk/subversion/libsvn_subr/svn_string.c

2010-09-22 Thread Julian Foad
Daniel Shahaf wrote: > Philip Martin wrote on Wed, Sep 22, 2010 at 11:47:19 +0100: > > Daniel Shahaf writes: > > > minval is an apr_uint64_t, so shouldn't the format string use > > > APR_UINT64_FMT? > > > > See this thread > > > > http://svn.haxx.se/dev/archive-2010-09/0295.shtml > > and subve

Re: svn commit: r999785 - /subversion/trunk/subversion/libsvn_subr/svn_string.c

2010-09-22 Thread Philip Martin
Daniel Shahaf writes: > Philip Martin wrote on Wed, Sep 22, 2010 at 11:47:19 +0100: >> Daniel Shahaf writes: >> > minval is an apr_uint64_t, so shouldn't the format string use >> > APR_UINT64_FMT? >> >> See this thread >> >> http://svn.haxx.se/dev/archive-2010-09/0295.shtml >> > > and subver

Re: svn commit: r999785 - /subversion/trunk/subversion/libsvn_subr/svn_string.c

2010-09-22 Thread Daniel Shahaf
Philip Martin wrote on Wed, Sep 22, 2010 at 11:47:19 +0100: > Daniel Shahaf writes: > > minval is an apr_uint64_t, so shouldn't the format string use > > APR_UINT64_FMT? > > See this thread > > http://svn.haxx.se/dev/archive-2010-09/0295.shtml > and subversion/libsvn_fs_fs/rep-cache.c:153

Re: svn commit: r999785 - /subversion/trunk/subversion/libsvn_subr/svn_string.c

2010-09-22 Thread Philip Martin
Daniel Shahaf writes: >> return svn_error_return( >> svn_error_createf(SVN_ERR_INCORRECT_PARAMS, NULL, >> - _("Number '%s' is out of range '[%lu, >> %lu]'"), >> + _("Number '%s' is out of range '[%llu, >> %llu]'"),

Re: svn commit: r999785 - /subversion/trunk/subversion/libsvn_subr/svn_string.c

2010-09-22 Thread Daniel Shahaf
style...@apache.org wrote on Wed, Sep 22, 2010 at 07:17:51 -: > Author: stylesen > Date: Wed Sep 22 07:17:51 2010 > New Revision: 999785 > > URL: http://svn.apache.org/viewvc?rev=999785&view=rev > Log: > Fix a warning. > > * subversion/libsvn_subr/svn_string.c > (svn_cstring_strtoui64, svn_