Philip Martin wrote: > Daniel Shahaf <d...@daniel.shahaf.name> writes: > > > Philip Martin wrote on Wed, Sep 22, 2010 at 11:47:19 +0100: > >> Daniel Shahaf <d...@daniel.shahaf.name> writes: > >> > minval is an apr_uint64_t, so shouldn't the format string use > >> > APR_UINT64_FMT? > >> > >> See this thread > >> > >> http://svn.haxx.se/dev/archive-2010-09/0295.shtml > >> > > > > and subversion/libsvn_fs_fs/rep-cache.c:153 > > Yes, that would be another way to do it. I think it will defeat the > compiler's compile-time printf parameter checking, only the inner > printf would get checked.
It might be worth adding a pool parameter so that any of the print-into-a-substing variants can be used. - Julian
