Re: svn commit: r1203687 - /subversion/trunk/subversion/svn/status.c

2011-11-18 Thread Daniel Shahaf
On Friday, November 18, 2011 10:36 AM, "C. Michael Pilato" wrote: > On 11/18/2011 10:26 AM, Daniel Shahaf wrote: > > If we add a status->foo flag (like we added the status->changelist bit > > in 1.4), we would have to explicitly add it to this if() too --- which is > > too easy to forget. > > Do

Re: svn commit: r1203687 - /subversion/trunk/subversion/svn/status.c

2011-11-18 Thread C. Michael Pilato
On 11/18/2011 10:26 AM, Daniel Shahaf wrote: > If we add a status->foo flag (like we added the status->changelist bit > in 1.4), we would have to explicitly add it to this if() too --- which is > too easy to forget. Do you have a concrete suggestion for making this future-proof? If not, we'll sim

Re: svn commit: r1203687 - /subversion/trunk/subversion/svn/status.c

2011-11-18 Thread Daniel Shahaf
On Friday, November 18, 2011 3:12 PM, cmpil...@apache.org wrote: > Author: cmpilato > Date: Fri Nov 18 15:12:03 2011 > New Revision: 1203687 > > URL: http://svn.apache.org/viewvc?rev=1203687&view=rev > Log: > For issue #1935 ("svn status too verbose with svn:externals > definitions"), continue t