Re: svn commit: r1146452 - /subversion/branches/1.7.x/STATUS

2011-07-14 Thread Julian Foad
Daniel Shahaf wrote: > The backport proposal now includes a fix of the original callsite > (r1146708). > > Thus, 1.7.x the semantics of these API's are unchanged and the backport > entry for the problematic caller has been patched. For 1.8.x, given > that I'm juiced out by this thread, I'll go ah

Re: svn commit: r1146452 - /subversion/branches/1.7.x/STATUS

2011-07-14 Thread Daniel Shahaf
The backport proposal now includes a fix of the original callsite (r1146708). Thus, 1.7.x the semantics of these API's are unchanged and the backport entry for the problematic caller has been patched. For 1.8.x, given that I'm juiced out by this thread, I'll go ahead and implement on trunk whatev

Re: svn commit: r1146452 - /subversion/branches/1.7.x/STATUS

2011-07-14 Thread Julian Foad
Daniel Shahaf wrote: > Oh. And I realized that svn_checksum_to_cstring() only started to > accept NULL in 1.7. Which means that, currently, in 1.7.x, > > * svn_checksum_to_cstring(NULL) returns NULL > * svn_checksum_to_cstring_display(NULL) segfaults The essential and original difference betwee

Re: svn commit: r1146452 - /subversion/branches/1.7.x/STATUS

2011-07-13 Thread Daniel Shahaf
Oh. And I realized that svn_checksum_to_cstring() only started to accept NULL in 1.7. Which means that, currently, in 1.7.x, * svn_checksum_to_cstring(NULL) returns NULL * svn_checksum_to_cstring_display(NULL) segfaults Generally I prefer consistency before I prefer that My Way gets chosen... w

Re: svn commit: r1146452 - /subversion/branches/1.7.x/STATUS

2011-07-13 Thread Daniel Shahaf
Just adding two facts to the mix: The use case I had was representation_string() trying to stringify md5_checksum, which is NULL for reps retrieved from the cache. Looking at the other callers, most of them seem to pass the checksum to 'info' or to an editor function documented as ignoring the ch

Re: svn commit: r1146452 - /subversion/branches/1.7.x/STATUS

2011-07-13 Thread Greg Stein
On Wed, Jul 13, 2011 at 17:08, Daniel Shahaf wrote: > gst...@apache.org wrote on Wed, Jul 13, 2011 at 20:51:17 -: >> Author: gstein >> Date: Wed Jul 13 20:51:17 2011 >> New Revision: 1146452 >> >> URL: http://svn.apache.org/viewvc?rev=1146452&view=rev >> Log: >> votes! >> >> Modified: >>     s

Re: svn commit: r1146452 - /subversion/branches/1.7.x/STATUS

2011-07-13 Thread Daniel Shahaf
gst...@apache.org wrote on Wed, Jul 13, 2011 at 20:51:17 -: > Author: gstein > Date: Wed Jul 13 20:51:17 2011 > New Revision: 1146452 > > URL: http://svn.apache.org/viewvc?rev=1146452&view=rev > Log: > votes! > > Modified: > subversion/branches/1.7.x/STATUS > > Modified: subversion/branc