Re: Subversion Exception - assertion failed

2023-09-14 Thread Daniel Sahlberg
Den tis 12 sep. 2023 kl 12:19 skrev Matthias Klose : > Hi, > > I want to list a failing assertion. > > What have I done?: > Preparing a merge on a directory with Doxygen configuration files (maybe > not usefull, but I did it). > choosing options: Merge a range of revisions / all revisions / Compar

Re: Subversion Exception svn_relpath_is_canonical in ra_loader.c

2019-05-03 Thread Julian Foad
Branko Čibej wrote: All I can say is that there is no way for our canonicalisation functions to produce the correct result for *every* possible input. The new variants that return errors instead of aborting are an improvement, We should mention the new variants in http://subversion.apache.org/d

Re: Subversion Exception svn_relpath_is_canonical in ra_loader.c

2019-05-03 Thread Branko Čibej
On 02.05.2019 12:16, Johan Corveleyn wrote: > On Thu, May 2, 2019 at 10:34 AM Johan Corveleyn wrote: >> On Tue, Apr 30, 2019 at 9:28 PM Eliot, Christopher >> wrote: >>> I am not subscribed to this mailing list. If you need to reach me, please >>> CC me explicitly at christopher.el...@nagrastar.

Re: Subversion Exception svn_relpath_is_canonical in ra_loader.c

2019-05-02 Thread Johan Corveleyn
On Thu, May 2, 2019 at 10:34 AM Johan Corveleyn wrote: > > On Tue, Apr 30, 2019 at 9:28 PM Eliot, Christopher > wrote: > > I am not subscribed to this mailing list. If you need to reach me, please > > CC me explicitly at christopher.el...@nagrastar.com > > Hi Christopher, > > > Running Tortoise

Re: Subversion Exception!

2018-12-28 Thread Branko Čibej
On 28.12.2018 11:19, Branko Čibej wrote: > On 28.12.2018 11:05, Bert Huijben wrote: >> +svn_error_t * >> +svn_error__malfunction_f(svn_boolean_t can_return, >> + const char *file, int line, >> + const char *fmt, ...) >> +{ >> + apr_pool_t *pool = svn

Re: Subversion Exception!

2018-12-28 Thread Branko Čibej
On 28.12.2018 11:05, Bert Huijben wrote: > +svn_error_t * > +svn_error__malfunction_f(svn_boolean_t can_return, > + const char *file, int line, > + const char *fmt, ...) > +{ > + apr_pool_t *pool = svn_pool_create(NULL); > + va_list ap; > + const c

Re: Subversion Exception!

2018-12-28 Thread Bert Huijben
+svn_error_t * +svn_error__malfunction_f(svn_boolean_t can_return, + const char *file, int line, + const char *fmt, ...) +{ + apr_pool_t *pool = svn_pool_create(NULL); + va_list ap; + const char *expr; + + va_start(ap, fmt); + expr = apr_pvsprint

Re: Subversion Exception!

2018-12-14 Thread Branko Čibej
On Fri, 14 Dec 2018, 05:41 Nathan Hartman On Thu, Dec 13, 2018 at 11:59 AM Branko Čibej wrote: > >> I never said that it's a good idea to abort in a library. We made a >> mistake in the early days of this project to allow such patterns. > > >> >> I am quite angry at the contrariness and stubbornn

Re: Subversion Exception!

2018-12-13 Thread Nathan Hartman
On Thu, Dec 13, 2018 at 11:59 AM Branko Čibej wrote: > I never said that it's a good idea to abort in a library. We made a > mistake in the early days of this project to allow such patterns. > > I am quite angry at the contrariness and stubbornness of one TSVN > developer, who is *also* a Subve

Re: Subversion Exception!

2018-12-13 Thread Branko Čibej
On 13.12.2018 17:39, Mark Phippard wrote: >> On Dec 13, 2018, at 11:26 AM, Branko Čibej wrote: >> >> On 13.12.2018 17:09, Mark Phippard wrote: On Dec 13, 2018, at 10:53 AM, Michael Pilato wrote: > On 12/13/18 10:45 AM, Branko Čibej wrote: > Uh. I forgot about the malfunction han

Re: Subversion Exception!

2018-12-13 Thread Mark Phippard
> On Dec 13, 2018, at 11:30 AM, Daniel Shahaf wrote: > > Mark Phippard wrote on Thu, 13 Dec 2018 11:09 -0500: >> FWIW, I agree with Stefan on all of this. We should not be doing abort >> from a library. Whether TSVN could do more to avoid it seems like a >> separate issue. I do not see why

Re: Subversion Exception!

2018-12-13 Thread Mark Phippard
> On Dec 13, 2018, at 11:26 AM, Branko Čibej wrote: > > On 13.12.2018 17:09, Mark Phippard wrote: >>> On Dec 13, 2018, at 10:53 AM, Michael Pilato wrote: >>> On 12/13/18 10:45 AM, Branko Čibej wrote: Uh. I forgot about the malfunction handler. However this doesn't really help,

Re: Subversion Exception!

2018-12-13 Thread Julian Foad
Daniel Shahaf wrote: > At the same time, I think Brane had a valid point. It is not > users@subversion's job to triage TortoiseSVN error reports; It's a valid point of view but please let's stop pushing that point, especially don't ask Stefan to go over it again. Please let's concentrate on what

Re: Subversion Exception!

2018-12-13 Thread Daniel Shahaf
Mark Phippard wrote on Thu, 13 Dec 2018 11:09 -0500: > FWIW, I agree with Stefan on all of this. We should not be doing abort > from a library. Whether TSVN could do more to avoid it seems like a > separate issue. I do not see why the library cannot just return a > useful error and allow the

Re: Subversion Exception!

2018-12-13 Thread Julian Foad
Daniel Shahaf wrote: > [...] If you have > found a value for which svn_foo_is_canonical(svn_foo_canonicalize(value)) > returns false, please tell us what that value is. Daniel, some examples: path = "foo"; -> assertion 'svn_uri_is_canonical(svn_uri_canonicalize(f, pool), pool)' failed #define S

Re: Subversion Exception!

2018-12-13 Thread Branko Čibej
On 13.12.2018 17:09, Mark Phippard wrote: >> On Dec 13, 2018, at 10:53 AM, Michael Pilato wrote: >> >>> On 12/13/18 10:45 AM, Branko Čibej wrote: >>> Uh. I forgot about the malfunction handler. However this doesn't really >>> help, other than putting possibly sensitive paths into the crash handler

Re: Subversion Exception!

2018-12-13 Thread Daniel Shahaf
Branko Čibej wrote on Thu, 13 Dec 2018 17:00 +0100: > On 13.12.2018 16:53, Michael Pilato wrote: > > On 12/13/18 10:45 AM, Branko Čibej wrote: > >> Uh. I forgot about the malfunction handler. However this doesn't really > >> help, other than putting possibly sensitive paths into the crash handler >

Re: Subversion Exception!

2018-12-13 Thread Mark Phippard
> On Dec 13, 2018, at 10:53 AM, Michael Pilato wrote: > >> On 12/13/18 10:45 AM, Branko Čibej wrote: >> Uh. I forgot about the malfunction handler. However this doesn't really >> help, other than putting possibly sensitive paths into the crash handler >> info? We really shouldn't do it this way

Re: Subversion Exception!

2018-12-13 Thread Branko Čibej
On 13.12.2018 16:53, Michael Pilato wrote: > On 12/13/18 10:45 AM, Branko Čibej wrote: >> Uh. I forgot about the malfunction handler. However this doesn't really >> help, other than putting possibly sensitive paths into the crash handler >> info? We really shouldn't do it this way, users *will* jus

Re: Subversion Exception!

2018-12-13 Thread Michael Pilato
On 12/13/18 10:45 AM, Branko Čibej wrote: > Uh. I forgot about the malfunction handler. However this doesn't really > help, other than putting possibly sensitive paths into the crash handler > info? We really shouldn't do it this way, users *will* just copy and > paste the output tot he 'net. Ahem

Re: Subversion Exception!

2018-12-13 Thread Julian Foad
Branko Čibej wrote: > On 13.12.2018 16:42, Johan Corveleyn wrote: > >> [...] assertion failed > >> (svn_dirent_is_absolute(local_abspath='C:ImNotAbsolute')) > > Nice :-). I'm not sure what others think, but IMHO that would make > > these error reports a lot more useful ... > > [...] this doesn't

Re: Subversion Exception!

2018-12-13 Thread Branko Čibej
On 13.12.2018 16:42, Johan Corveleyn wrote: > On Thu, Dec 13, 2018 at 4:05 PM Julian Foad wrote: >> Johan Corveleyn wrote: >>> Just thinking out loud here, but could we perhaps log the >>> non-canonical value as part of the assertion output? >>> [...] >>> something like >>> >>> line 10238: assert

Re: Subversion Exception!

2018-12-13 Thread Johan Corveleyn
On Thu, Dec 13, 2018 at 4:05 PM Julian Foad wrote: > > Johan Corveleyn wrote: > > Just thinking out loud here, but could we perhaps log the > > non-canonical value as part of the assertion output? > > [...] > > something like > > > > line 10238: assertion failed > > (svn_dirent_is_absolute(local_

Re: Subversion Exception!

2018-12-13 Thread Julian Foad
Johan Corveleyn wrote: > Just thinking out loud here, but could we perhaps log the > non-canonical value as part of the assertion output? > [...] > something like > > line 10238: assertion failed > (svn_dirent_is_absolute(local_abspath='C:ImNotCanonical')) Yes, Johan, we could do that. The atta

Re: Subversion Exception!

2018-12-13 Thread Branko Čibej
On 13.12.2018 14:15, Johan Corveleyn wrote: > On Wed, Dec 12, 2018 at 10:23 PM Daniel Shahaf > wrote: >> Stefan Kueng wrote on Wed, 12 Dec 2018 21:16 +0100: >>> And as I repeatedly said: TSVN does validate the input as good as it >>> can. But if svn does neither describe the *exact* specs in the

Re: Subversion Exception!

2018-12-13 Thread Johan Corveleyn
On Wed, Dec 12, 2018 at 10:23 PM Daniel Shahaf wrote: > Stefan Kueng wrote on Wed, 12 Dec 2018 21:16 +0100: > > And as I repeatedly said: TSVN does validate the input as good as it > > can. But if svn does neither describe the *exact* specs in the docs nor > > provide any APIs that do that, then T

Re: Subversion Exception!

2018-12-12 Thread Daniel Shahaf
Stefan Kueng wrote on Wed, 12 Dec 2018 21:16 +0100: > And as I repeatedly said: TSVN does validate the input as good as it > can. But if svn does neither describe the *exact* specs in the docs nor > provide any APIs that do that, then TSVN has to guess. > And no: specifying that paths/uris have t

Re: Subversion Exception!

2018-12-12 Thread Branko Čibej
On 12.12.2018 21:16, Stefan Kueng wrote: > > > On 12.12.2018 21:12, Branko Čibej wrote: >> On 12.12.2018 19:07, Stefan Kueng wrote: >>> >>> >>> On 12.12.2018 13:55, TortoiseSVN-dev on behalf of Julian Foad wrote: >> Subversion encountered a serious problem. >> Please take the time to report

Re: Subversion Exception!

2018-12-12 Thread Stefan Kueng
On 12.12.2018 21:12, Branko Čibej wrote: On 12.12.2018 19:07, Stefan Kueng wrote: On 12.12.2018 13:55, TortoiseSVN-dev on behalf of Julian Foad wrote: Subversion encountered a serious problem. Please take the time to report this on the Subversion mailing list […] https://subversion.apach

Re: Subversion Exception!

2018-12-12 Thread Branko Čibej
On 12.12.2018 19:07, Stefan Kueng wrote: > > > On 12.12.2018 13:55, TortoiseSVN-dev on behalf of Julian Foad wrote: Subversion encountered a serious problem. Please take the time to report this on the Subversion mailing list >> […] https://subversion.apache.org/mailing-lists.html >>

Re: Subversion Exception!

2018-12-12 Thread Stefan Kueng
On 12.12.2018 13:55, TortoiseSVN-dev on behalf of Julian Foad wrote: Subversion encountered a serious problem. Please take the time to report this on the Subversion mailing list […] https://subversion.apache.org/mailing-lists.html It is likely that this is a problem specific to TortoiseSV

Re: Subversion Exception!

2018-12-12 Thread Julian Foad
>> Subversion encountered a serious problem. >> Please take the time to report this on the Subversion mailing list […] >> https://subversion.apache.org/mailing-lists.html >It is likely that this is a problem specific to TortoiseSVN, and not >to core SVN. TortoiseSVN has its own mailinglists, so yo

Re: Subversion Exception!

2018-12-12 Thread Johan Corveleyn
On Mon, Dec 10, 2018 at 9:47 AM Peta Miller wrote: > > Hello, > > > > i got following exception at trying to start the tortoisesvn Project Monitor > with a doubleclick on the tray icon. > > System: WIN 10, Build 15063 > > --- > Subversion Exception! > -

Re: Subversion Exception on commit wirth pathfile

2018-10-18 Thread Bert Huijben
Could you try this same operation with the disk names capitalized? If this resolves the issue, please let us and the TortoiseSVN developers know, as in that case there is an issue in (their) path canonicalization api. Bert On Thu, Oct 18, 2018 at 12:13 PM Johan Corveleyn wrote: > On Thu, Oc

Re: Subversion Exception on commit wirth pathfile

2018-10-18 Thread Johan Corveleyn
On Thu, Oct 18, 2018 at 11:34 AM Yakov Maryanov wrote: > > Hello! > > I execute command: > > "C:\Program Files\TortoiseSVN\bin\TortoiseProc.exe" /command:commit > /pathfile:"d:\SVN\Work\Source\Project\f2.txt" > > File f2.txt contains two strings: > > d:\SVN\Work\Source\Source\Project.Client > d:\

Re: Subversion Exception!

2018-03-10 Thread Branko Čibej
[Top-posting on purpose] Would it make sense to require other clients, such as TortoiseSVN, to change the text and links in this exception message? It would be better for everyone if the authors of the distro (in this case, TSVN) were the first to get these error reports. This particular one look

Re: Subversion Exception!

2016-09-13 Thread Alfred Ultsch
Dear Andreas if someone should encounter this error, point to the eventual existence of the zepto virus which has encrypted some of my .svn files Alfred On 9/13/2016 1:55 PM, Andreas Stieger wrote: Hi, Alfred Ultsch wrote: In file 'D:\Development\SVN\Releases\TortoiseSVN-1.9.3\ext\s

Re: Subversion Exception!

2016-09-13 Thread Andreas Stieger
Hi, Alfred Ultsch wrote: > In file > > 'D:\Development\SVN\Releases\TortoiseSVN-1.9.3\ext\subversion\subversion\libsvn_client\cleanup.c' > line 227: assertion failed (svn_dirent_is_absolute(dir_abspath)) Upgrade to 1.9.4 and try again. Andreas