Re: Deletion revision in Ev2

2012-05-07 Thread Greg Stein
On Mon, May 7, 2012 at 3:02 PM, Hyrum K Wright wrote: > On Mon, May 7, 2012 at 1:43 PM, Greg Stein wrote: >... >>>... >>> Simply eliminating the check in editor.c:delete_cb(), and also >>> changing can_modify() to allow invalid revision to act as a wildcard >>> (i.e., "don't bother checking, I kn

Re: Deletion revision in Ev2

2012-05-07 Thread Hyrum K Wright
On Mon, May 7, 2012 at 1:43 PM, Greg Stein wrote: > On Mon, May 7, 2012 at 12:37 PM, Hyrum K Wright > wrote: >>... >> In this case, we are legitimately deleting B/C, but the "revision this >> thing is being deleted from" doesn't exist until commit finalization. > > True. I figured as the FS, we a

Re: Deletion revision in Ev2

2012-05-07 Thread Greg Stein
On Mon, May 7, 2012 at 12:37 PM, Hyrum K Wright wrote: >... > In this case, we are legitimately deleting B/C, but the "revision this > thing is being deleted from" doesn't exist until commit finalization. True. I figured as the FS, we always had a revision... but that's not true :-P >... > Simpl