On Mon, May 7, 2012 at 1:43 PM, Greg Stein <gst...@gmail.com> wrote: > On Mon, May 7, 2012 at 12:37 PM, Hyrum K Wright > <hyrum.wri...@wandisco.com> wrote: >>... >> In this case, we are legitimately deleting B/C, but the "revision this >> thing is being deleted from" doesn't exist until commit finalization. > > True. I figured as the FS, we always had a revision... but that's not true :-P
Yep. I'm going mostly off test failures here; there may be other (pathologic) cases which are still valid, but are not captured in the tests. >>... >> Simply eliminating the check in editor.c:delete_cb(), and also >> changing can_modify() to allow invalid revision to act as a wildcard >> (i.e., "don't bother checking, I know this should be modifiable") >> makes the test pass, but I don't know that that's the generally >> correct solution. > > It is valid. I'll make the necessary changes. Thanks! -Hyrum -- uberSVN: Apache Subversion Made Easy http://www.uberSVN.com/
