Re: API review - svn_dirent_uri.h

2011-06-15 Thread Greg Stein
On Wed, Jun 15, 2011 at 12:56, Julian Foad wrote: > On Wed, 2011-06-15, Greg Stein wrote: >> On Wed, Jun 15, 2011 at 12:32, Julian Foad wrote: >> > On Fri, 2011-06-10 at 09:06 +0100, Julian Foad wrote: >> >> I (Julian Foad) wrote: >> >> > On Thu, 2011-06-09, I (Julian Foad) wrote: >> >> > > svn_d

Re: API review - svn_dirent_uri.h

2011-06-15 Thread Julian Foad
On Wed, 2011-06-15, Greg Stein wrote: > On Wed, Jun 15, 2011 at 12:32, Julian Foad wrote: > > On Fri, 2011-06-10 at 09:06 +0100, Julian Foad wrote: > >> I (Julian Foad) wrote: > >> > On Thu, 2011-06-09, I (Julian Foad) wrote: > >> > > svn_dirent_uri.h > >> > > svn_relpath_internal_style() > >> >

Re: API review - svn_dirent_uri.h

2011-06-15 Thread Greg Stein
On Wed, Jun 15, 2011 at 12:52, Julian Foad wrote: > On Wed, 2011-06-15 at 12:42 -0400, Greg Stein wrote: >... > And this step of splitting _dirent_skip_ancestor into two variants with > the two different semantic meanings which are currently conflated - does > that now make sense to you as it does

Re: API review - svn_dirent_uri.h

2011-06-15 Thread Julian Foad
On Wed, 2011-06-15 at 12:42 -0400, Greg Stein wrote: > On Wed, Jun 15, 2011 at 12:32, Julian Foad wrote: > > On Fri, 2011-06-10 at 09:06 +0100, Julian Foad wrote: > >> I (Julian Foad) wrote: > >> > On Thu, 2011-06-09, I (Julian Foad) wrote: > >> > > svn_dirent_uri.h > >> > > svn_relpath_internal

Re: API review - svn_dirent_uri.h

2011-06-15 Thread C. Michael Pilato
On 06/15/2011 12:42 PM, Greg Stein wrote: > On Wed, Jun 15, 2011 at 12:32, Julian Foad wrote: >> Many callers of svn_dirent_skip_ancestor(), on the other hand, expect >> the 'child' input to be returned if it is not in fact a child. I am >> splitting the function into two: >> >> svn_dirent_skip_

Re: API review - svn_dirent_uri.h

2011-06-15 Thread Greg Stein
On Wed, Jun 15, 2011 at 12:32, Julian Foad wrote: > On Fri, 2011-06-10 at 09:06 +0100, Julian Foad wrote: >> I (Julian Foad) wrote: >> > On Thu, 2011-06-09, I (Julian Foad) wrote: >> > > svn_dirent_uri.h >> > >   svn_relpath_internal_style() >> > >   svn_relpath_local_style() >> > >     # These tw

Re: API review - svn_dirent_uri.h

2011-06-15 Thread Julian Foad
On Fri, 2011-06-10 at 09:06 +0100, Julian Foad wrote: > I (Julian Foad) wrote: > > On Thu, 2011-06-09, I (Julian Foad) wrote: > > > svn_dirent_uri.h > > > svn_relpath_internal_style() > > > svn_relpath_local_style() > > > # These two are inappropriate: only dirents have a 'local' style. > >

Re: API review - svn_dirent_uri.h

2011-06-10 Thread Julian Foad
I (Julian Foad) wrote: > On Thu, 2011-06-09, I (Julian Foad) wrote: > > svn_dirent_uri.h > > svn_relpath_internal_style() > > svn_relpath_local_style() > > # These two are inappropriate: only dirents have a 'local' style. > > I removed the former and made the latter private in r1133964. >

Re: API review - svn_dirent_uri.h

2011-06-10 Thread Julian Foad
On Thu, 2011-06-09, I (Julian Foad) wrote: > svn_dirent_uri.h > svn_relpath_internal_style() > svn_relpath_local_style() > # These two are inappropriate: only dirents have a 'local' style. I removed the former and made the latter private in r1133964. > svn_dirent_skip_ancestor() > #