On 06/15/2011 12:42 PM, Greg Stein wrote: > On Wed, Jun 15, 2011 at 12:32, Julian Foad <julian.f...@wandisco.com> wrote: >> Many callers of svn_dirent_skip_ancestor(), on the other hand, expect >> the 'child' input to be returned if it is not in fact a child. I am >> splitting the function into two: >> >> svn_dirent_skip_ancestor() - return NULL if not a child >> [some other function name] - return 'child' input if not a child > > PLEASE not another function.
Indeed. Can these many callers not just do: result = svn_dirent_skip_ancestor(parent, child) || child; ? -- C. Michael Pilato <cmpil...@collab.net> CollabNet <> www.collab.net <> Distributed Development On Demand
signature.asc
Description: OpenPGP digital signature
