Re: [PATCH] implement keywords substitution in mod_dav_svn

2013-03-08 Thread Vladimir Berezniker
On Fri, Mar 8, 2013 at 2:24 PM, Ben Reser wrote: > On Fri, Mar 8, 2013 at 11:12 AM, Vladimir Berezniker > wrote: > > If someone does not mind explaining. What would be the benefit of having > > this decision be made by the server vs the client having to request that > via > > a explicit paramet

Re: [PATCH] implement keywords substitution in mod_dav_svn

2013-03-08 Thread Ben Reser
On Fri, Mar 8, 2013 at 11:12 AM, Vladimir Berezniker wrote: > If someone does not mind explaining. What would be the benefit of having > this decision be made by the server vs the client having to request that via > a explicit parameter on the request? It's not so much of a benefit as it is a co

Re: [PATCH] implement keywords substitution in mod_dav_svn

2013-03-08 Thread Vladimir Berezniker
If someone does not mind explaining. What would be the benefit of having this decision be made by the server vs the client having to request that via a explicit parameter on the request? Thank you, Vladimir On Thu, Mar 7, 2013 at 3:41 PM, Daniel Shahaf wrote: > C. Michael Pilato wrote on Thu,

Re: [PATCH] implement keywords substitution in mod_dav_svn

2013-03-07 Thread Daniel Shahaf
C. Michael Pilato wrote on Thu, Mar 07, 2013 at 13:55:15 -0500: > [1] What happens if [a DAV] client screws up our "repository normal > format" -- expanding keywords or futzing with newlines -- when > PUTting a new version today? The non-RNF form gets committed, I think. Or did we install

Re: [PATCH] implement keywords substitution in mod_dav_svn

2013-03-07 Thread C. Michael Pilato
On 03/07/2013 12:21 PM, Bert Huijben wrote: >> Then those proxy servers are already interfering with existing clients, >> and preventing those clients from reporting capabilities, from storing >> and fetch file lock metadata correctly, etc. > > I think we use different headers for the user agent a

RE: [PATCH] implement keywords substitution in mod_dav_svn

2013-03-07 Thread Bert Huijben
> -Original Message- > From: C. Michael Pilato [mailto:cmpil...@collab.net] > Sent: donderdag 7 maart 2013 17:32 > To: Bert Huijben > Cc: 'Gavin Baumanis'; 'jinfroster'; dev@subversion.apache.org > Subject: Re: [PATCH] implement keywords substitutio

Re: [PATCH] implement keywords substitution in mod_dav_svn

2013-03-07 Thread C. Michael Pilato
On 03/07/2013 11:27 AM, Bert Huijben wrote: >> Yeah, I *think* using the "is_svn_client" flag is acceptable. I can't >> remember now how much weight we attributed to that flag (which is set >> based on a grep of the User-Agent string). The downside here is that >> if there happens to be a Subve

RE: [PATCH] implement keywords substitution in mod_dav_svn

2013-03-07 Thread Bert Huijben
> -Original Message- > From: C. Michael Pilato [mailto:cmpil...@collab.net] > Sent: donderdag 7 maart 2013 17:23 > To: Gavin Baumanis > Cc: 'jinfroster'; dev@subversion.apache.org > Subject: Re: [PATCH] implement keywords substitution in mod_dav_svn >

Re: [PATCH] implement keywords substitution in mod_dav_svn

2013-03-07 Thread C. Michael Pilato
On 03/07/2013 09:58 AM, Gavin Baumanis wrote: > Ping. > This thread has received no new comments. (Thanks, Gavin.) >> You are right! With this patch SVN client complains on bad checksums... >> Sorry, didn't test that well. >> But SVN clients do keywords substitution themselves. The idea was to >>

Re: [PATCH] implement keywords substitution in mod_dav_svn

2013-02-04 Thread C. Michael Pilato
On 02/04/2013 09:55 AM, C. Michael Pilato wrote: > On 02/04/2013 06:30 AM, Philip Martin wrote: >> jinfroster writes: >> >>> Add "SVNKeywordSubstitution" per-directory (repository) mod_dav_svn >>> configuration parameter (default is "Off"). Implement keywords >>> substitution. >> >>> * subversion/

Re: [PATCH] implement keywords substitution in mod_dav_svn

2013-02-04 Thread C. Michael Pilato
On 02/04/2013 06:30 AM, Philip Martin wrote: > jinfroster writes: > >> Add "SVNKeywordSubstitution" per-directory (repository) mod_dav_svn >> configuration parameter (default is "Off"). Implement keywords >> substitution. > >> * subversion/mod_dav_svn/repos.c >> (set_headers): >> If parame

Re: [PATCH] implement keywords substitution in mod_dav_svn

2013-02-04 Thread Philip Martin
jinfroster writes: > Add "SVNKeywordSubstitution" per-directory (repository) mod_dav_svn > configuration parameter (default is "Off"). Implement keywords > substitution. > * subversion/mod_dav_svn/repos.c > (set_headers): > If parameter SVNKeywordSubstitution is On, don't send > "Conte