On 03/07/2013 09:58 AM, Gavin Baumanis wrote: > Ping. > This thread has received no new comments.
(Thanks, Gavin.)
>> You are right! With this patch SVN client complains on bad checksums...
>> Sorry, didn't test that well.
>> But SVN clients do keywords substitution themselves. The idea was to
>> implement substitution for dumb HTTP clients which are missing it.
>>
>> Would it be sufficent to check 'is_svn_client'?
>>
>> if (dav_svn__get_keyword_substitution_flag(resource->info->r)
>> && !resource->info->repos->is_svn_client)
>> {
>> ...
>>
>> If there are more troubles/questions, please point on them to me.
>> I'm willing to work on this patch if it has chances to be accepted :)
Yeah, I *think* using the "is_svn_client" flag is acceptable. I can't
remember now how much weight we attributed to that flag (which is set based
on a grep of the User-Agent string). The downside here is that if there
happens to be a Subversion client that doesn't report itself as such in this
way, it will presumably run into the same sorts of issues we've already
discussed. But I know of no such client, and maybe we as a community are
willing to say, "Look, if you are to be a well-behaved Subversion client,
you've gotta slap those four characters "SVN/" in your User-Agent header value.
--
C. Michael Pilato <cmpil...@collab.net>
CollabNet <> www.collab.net <> Enterprise Cloud Development
signature.asc
Description: OpenPGP digital signature
