Re: [PATCH] Make svn_apply_autoprops.py Windows-compatible

2024-04-27 Thread Khairul Azhar Kasmiran
> I've committed the patch in r1917382. Thanks! Best regards, Khairul On Sat, Apr 27, 2024 at 8:44 PM Daniel Sahlberg wrote: > > Den lör 27 apr. 2024 kl 03:18 skrev Khairul Azhar Kasmiran > : >> >> Can this patch be committed first before further changes are made? >> >> -- Khairul > > > Brane

Re: [PATCH] Make svn_apply_autoprops.py Windows-compatible

2024-04-27 Thread Daniel Sahlberg
> > > Brane has a valid comment that Subversion can store configuration also in > the registry. > Sorry, it was Jun Omae who made this observation - thank you Jun! Kind regards, Daniel However I don't think we should let perfect stand in the way of progress, > this is in contrib so it is not o

Re: [PATCH] Make svn_apply_autoprops.py Windows-compatible

2024-04-27 Thread Daniel Sahlberg
Den lör 27 apr. 2024 kl 03:18 skrev Khairul Azhar Kasmiran < kaza...@gmail.com>: > Can this patch be committed first before further changes are made? > > -- Khairul > Brane has a valid comment that Subversion can store configuration also in the registry. However I don't think we should let perfec

Re: [PATCH] Make svn_apply_autoprops.py Windows-compatible

2024-04-26 Thread Khairul Azhar Kasmiran
Can this patch be committed first before further changes are made? -- Khairul On Thu, Apr 25, 2024 at 8:58 PM Khairul Azhar Kasmiran wrote: > > > Would you care to send that one as well? > > Yes, but there's another (probably routine) fix that I'd like to make > in a separate unrelated patch and

Re: [PATCH] Make svn_apply_autoprops.py Windows-compatible

2024-04-25 Thread Khairul Azhar Kasmiran
> Would you care to send that one as well? Yes, but there's another (probably routine) fix that I'd like to make in a separate unrelated patch and then I'll send that one in. -- Khairul On Thu, Apr 25, 2024 at 8:42 PM Daniel Sahlberg wrote: > > Den tors 25 apr. 2024 kl 14:03 skrev Khairul Azhar

Re: [PATCH] Make svn_apply_autoprops.py Windows-compatible

2024-04-25 Thread Daniel Sahlberg
Den tors 25 apr. 2024 kl 14:03 skrev Khairul Azhar Kasmiran < kaza...@gmail.com>: > > Any reason to keep it at this version instead of making the necessary > changes to support Python 3? > > I have already made the necessary changes for Python 3 locally (and I > just found out today that the chang

Re: [PATCH] Make svn_apply_autoprops.py Windows-compatible

2024-04-25 Thread Khairul Azhar Kasmiran
> Any reason to keep it at this version instead of making the necessary changes > to support Python 3? I have already made the necessary changes for Python 3 locally (and I just found out today that the changes are compatible with both Python 2 and 3 afaik), but I'm adhering to "A patch submissio

Re: [PATCH] Make svn_apply_autoprops.py Windows-compatible

2024-04-25 Thread Daniel Sahlberg
Den tors 25 apr. 2024 kl 12:30 skrev Khairul Azhar Kasmiran < kaza...@gmail.com>: > Oops sorry I should have used a raw string. Patch reattached. > > [[[ > Make svn_apply_autoprops.py Windows-compatible. > > * contrib/client-side/svn_apply_autoprops.py: Add default Windows > Subversion configurati

Re: [PATCH] Make svn_apply_autoprops.py Windows-compatible

2024-04-25 Thread Khairul Azhar Kasmiran
Oops sorry I should have used a raw string. Patch reattached. [[[ Make svn_apply_autoprops.py Windows-compatible. * contrib/client-side/svn_apply_autoprops.py: Add default Windows Subversion configuration path. (process_autoprop_lines): Use `ON` instead of `*` for boolean properties. (filter_walk

Re: [PATCH] Make svn_apply_autoprops.py Windows-compatible

2024-04-25 Thread Khairul Azhar Kasmiran
Thanks everyone for the comments! > * HKEY_CURRENT_USER\Software\Tigris.org\Subversion\Config I think reading from this registry key should be done in a different patch (probably not done by me) since it significantly complicates matters. > To make the script compatible with Windows needs to cha

Re: [PATCH] Make svn_apply_autoprops.py Windows-compatible

2024-04-25 Thread Branko Čibej
On 25. 04. 24 00:29, Jun Omae wrote: Hi, On Tue, Apr 23, 2024 at 8:42 PM Khairul Azhar Kasmiran wrote: I've reattached the patch as a .txt file. On 2024/04/23 10:46:41 Khairul Azhar Kasmiran wrote: Hi everyone! This is a patch to make `contrib/client-side/svn_apply_autoprops.py` Windows-co

Re: [PATCH] Make svn_apply_autoprops.py Windows-compatible

2024-04-24 Thread Jun Omae
Hi, On Tue, Apr 23, 2024 at 8:42 PM Khairul Azhar Kasmiran wrote: > > I've reattached the patch as a .txt file. > > On 2024/04/23 10:46:41 Khairul Azhar Kasmiran wrote: > > Hi everyone! > > > > This is a patch to make `contrib/client-side/svn_apply_autoprops.py` > > Windows-compatible -- I have j

Re: [PATCH] Make svn_apply_autoprops.py Windows-compatible

2024-04-24 Thread Yasuhito FUTATSUKI
On 2024/04/24 6:33, Branko Čibej wrote: > On 23. 04. 24 20:29, Yasuhito FUTATSUKI wrote: >> On 2024/04/24 1:30, Branko Čibej wrote: >>> On 23. 04. 24 17:24, Yasuhito FUTATSUKI wrote: Hello, On 2024/04/23 20:42, Khairul Azhar Kasmiran wrote: > I've reattached the patch as a .txt f

Re: [PATCH] Make svn_apply_autoprops.py Windows-compatible

2024-04-23 Thread Branko Čibej
On 23. 04. 24 20:29, Yasuhito FUTATSUKI wrote: On 2024/04/24 1:30, Branko Čibej wrote: On 23. 04. 24 17:24, Yasuhito FUTATSUKI wrote: Hello, On 2024/04/23 20:42, Khairul Azhar Kasmiran wrote: I've reattached the patch as a .txt file. On 2024/04/23 10:46:41 Khairul Azhar Kasmiran wrote:   

Re: [PATCH] Make svn_apply_autoprops.py Windows-compatible

2024-04-23 Thread Yasuhito FUTATSUKI
On 2024/04/24 1:30, Branko Čibej wrote: > On 23. 04. 24 17:24, Yasuhito FUTATSUKI wrote: >> Hello, >> >> On 2024/04/23 20:42, Khairul Azhar Kasmiran wrote: >>> I've reattached the patch as a .txt file. >>> >>> On 2024/04/23 10:46:41 Khairul Azhar Kasmiran wrote:    2. Using `ON` instead of `*`

Re: [PATCH] Make svn_apply_autoprops.py Windows-compatible

2024-04-23 Thread Branko Čibej
On 23. 04. 24 17:24, Yasuhito FUTATSUKI wrote: Hello, On 2024/04/23 20:42, Khairul Azhar Kasmiran wrote: I've reattached the patch as a .txt file. On 2024/04/23 10:46:41 Khairul Azhar Kasmiran wrote: 2. Using `ON` instead of `*` for boolean properties like `svn:executable` since for some r

Re: [PATCH] Make svn_apply_autoprops.py Windows-compatible

2024-04-23 Thread Yasuhito FUTATSUKI
Hello, On 2024/04/23 20:42, Khairul Azhar Kasmiran wrote: > I've reattached the patch as a .txt file. > > On 2024/04/23 10:46:41 Khairul Azhar Kasmiran wrote: >> 2. Using `ON` instead of `*` for boolean properties like >> `svn:executable` since for some reason, `*` becomes a wildcard on >> Win

RE: [PATCH] Make svn_apply_autoprops.py Windows-compatible

2024-04-23 Thread Khairul Azhar Kasmiran
I've reattached the patch as a .txt file. On 2024/04/23 10:46:41 Khairul Azhar Kasmiran wrote: > Hi everyone! > > This is a patch to make `contrib/client-side/svn_apply_autoprops.py` > Windows-compatible -- I have just found out that `git svn` doesn't > honor autoprops. > > The changes are: > 1.