On 23. 04. 24 20:29, Yasuhito FUTATSUKI wrote:
On 2024/04/24 1:30, Branko Čibej wrote:
On 23. 04. 24 17:24, Yasuhito FUTATSUKI wrote:
Hello,
On 2024/04/23 20:42, Khairul Azhar Kasmiran wrote:
I've reattached the patch as a .txt file.
On 2024/04/23 10:46:41 Khairul Azhar Kasmiran wrote:
2. Using `ON` instead of `*` for boolean properties like
`svn:executable` since for some reason, `*` becomes a wildcard on
Windows.
Just a question (not checked on Windows). What part of the code
does treat '*' as a wildcard? Even if subprocess.call() is
called with shell=False (it is default), did it expand '*'?
Subversion does the expansion. We link the executables with setargv.obj,
because the Windows shell doesn't expand wildcards.
http://svn.apache.org/viewvc/subversion/trunk/build.conf?view=markup#l154
https://learn.microsoft.com/en-us/cpp/c-language/expanding-wildcard-arguments?view=msvc-170
Thank you for the explanation. I could understand that we need
to use -F option and file (or stdin) to pass '*' or '?" as a
(part of) property value on Windows.
There's no need to complicate things: we do use '*' for boolean property
values, but 'yes' and 'on' and '1' will work as well; the propery value
is converted to '*' within Subversion.
