Re: [PATCH] Introduce per-instance filesystem UUIDs

2014-09-08 Thread Evgeny Kotkov
Evgeny Kotkov writes: > Ben Reser writes: > >>> I think part of the problem here has been we (as in WANdisco folks) have >>> discussed the idea of an instance ID for repositories in the past to solve >>> the range of replacing the repository without clearing the cache issues. >>> But this change

Re: [PATCH] Introduce per-instance filesystem UUIDs

2014-09-02 Thread Evgeny Kotkov
Ben Reser writes: >> I think part of the problem here has been we (as in WANdisco folks) have >> discussed the idea of an instance ID for repositories in the past to solve >> the range of replacing the repository without clearing the cache issues. >> But this change is being added for a very diff

Re: [PATCH] Introduce per-instance filesystem UUIDs

2014-09-02 Thread Ben Reser
On 8/20/14 9:13 AM, Ben Reser wrote: > I think part of the problem here has been we (as in WANdisco folks) have > discussed the idea of an instance ID for repositories in the past to solve the > range of replacing the repository without clearing the cache issues. But this > change is being added f

Re: [PATCH] Introduce per-instance filesystem UUIDs

2014-08-20 Thread Ben Reser
On 8/19/14 12:07 AM, Branko Čibej wrote: > I think it's not that simple. > > Consider the case where an administrator decides to not use 'svnadmin hotcopy' > to back up a repository, but instead creates a (LVM) snapshot of the volume > and > uses 'tar' (or 'cp -a') to create the backup. > > When

Re: [PATCH] Introduce per-instance filesystem UUIDs

2014-08-18 Thread Branko Čibej
On 18.08.2014 21:43, Evgeny Kotkov wrote: > What I am really concerned about is that this internal little fix > could ultimately become an unnecessary complicated, full-stack and > user-visible feature. I doubt that we want users to know something > about the way we solve our *internal* problems. W

Re: [PATCH] Introduce per-instance filesystem UUIDs

2014-08-18 Thread Evgeny Kotkov
Hi Stefan, > Here at the SHF hackathon, we briefly talked about how to proceed. I quite > happy with the current implementation wrt to its technical approach. However, > we identified another operation that should bump the instance ID, fs_recover. > And there might be more. > > None of that is com

Re: [PATCH] Introduce per-instance filesystem UUIDs

2014-08-18 Thread Stefan Fuhrmann
On Fri, Aug 15, 2014 at 12:15 PM, Evgeny Kotkov wrote: > > To be constructive, I implemented the feature in the db/uuid > > instead of db/format - taking your code and commentary > > where possible. That automatically covered the dump / load > > issue and shortened the patch quite a bit. Cache ke

Re: [PATCH] Introduce per-instance filesystem UUIDs

2014-08-15 Thread Evgeny Kotkov
> To be constructive, I implemented the feature in the db/uuid > instead of db/format - taking your code and commentary > where possible. That automatically covered the dump / load > issue and shortened the patch quite a bit. Cache keying > and structure description update are also addressed. > > I

Re: [PATCH] Introduce per-instance filesystem UUIDs

2014-08-12 Thread Stefan Fuhrmann
On Tue, Aug 12, 2014 at 11:47 PM, Stefan Fuhrmann < stefan.fuhrm...@wandisco.com> wrote: > Arrgs!! Random key combo made me sent the mail before completing it ... > > > On Tue, Aug 12, 2014 at 11:29 PM, Stefan Fuhrmann < > stefan.fuhrm...@wandisco.com> wrote: > >> >> On Sun, Aug 10, 2014 at 3:56 P

Re: [PATCH] Introduce per-instance filesystem UUIDs

2014-08-12 Thread Stefan Fuhrmann
Arrgs!! Random key combo made me sent the mail before completing it ... On Tue, Aug 12, 2014 at 11:29 PM, Stefan Fuhrmann < stefan.fuhrm...@wandisco.com> wrote: > > On Sun, Aug 10, 2014 at 3:56 PM, Evgeny Kotkov < > evgeny.kot...@visualsvn.com> wrote: > >> Hi Stefan, >> >> > Thanks for having a

Re: [PATCH] Introduce per-instance filesystem UUIDs

2014-08-12 Thread Stefan Fuhrmann
On Sun, Aug 10, 2014 at 3:56 PM, Evgeny Kotkov wrote: > Hi Stefan, > > > Thanks for having a the (missing) instance ID issue. > > From initial review, I have 1 objection and 2 issues > > that your patch does not address, yet. > > Thank you for reviewing this patch. I did my best, but I cannot re

Re: [PATCH] Introduce per-instance filesystem UUIDs

2014-08-10 Thread Evgeny Kotkov
Hi Stefan, > Thanks for having a the (missing) instance ID issue. > From initial review, I have 1 objection and 2 issues > that your patch does not address, yet. Thank you for reviewing this patch. I did my best, but I cannot really tell, which of these points are objections, and which of them a

Re: [PATCH] Introduce per-instance filesystem UUIDs

2014-08-10 Thread Ivan Zhakov
On 8 August 2014 21:24, Evgeny Kotkov wrote: > Hi, > > I would like to propose a patch for the problem discussed in > http://svn.haxx.se/dev/archive-2014-04/0245.shtml > > Please see the details below. > > Log message: > [[[ > Avoid shared data clashes between repositories duplicated using 'hotcop

Re: [PATCH] Introduce per-instance filesystem UUIDs

2014-08-09 Thread Branko Čibej
On 09.08.2014 21:53, Evgeny Kotkov wrote: >> The idea of introducing a separate repository UUID that is "guaranteed" to >> be unique has been discussed a couple times, tough maybe not on-list. I >> agree that we need something like this, for the reasons you state below. > [...] > >> I suggest you c

Re: [PATCH] Introduce per-instance filesystem UUIDs

2014-08-09 Thread Stefan Fuhrmann
On Fri, Aug 8, 2014 at 7:24 PM, Evgeny Kotkov wrote: > Hi, > > I would like to propose a patch for the problem discussed in > http://svn.haxx.se/dev/archive-2014-04/0245.shtml > > Please see the details below. > [...] Hi Evgeny, Thanks for having a the (missing) instance ID issue. >From initia

Re: [PATCH] Introduce per-instance filesystem UUIDs

2014-08-09 Thread Evgeny Kotkov
> The idea of introducing a separate repository UUID that is "guaranteed" to > be unique has been discussed a couple times, tough maybe not on-list. I > agree that we need something like this, for the reasons you state below. [...] > I suggest you create a branch and commit this there, so that pe

Re: [PATCH] Introduce per-instance filesystem UUIDs

2014-08-08 Thread Branko Čibej
On 08.08.2014 19:24, Evgeny Kotkov wrote: > Hi, > > I would like to propose a patch for the problem discussed in > http://svn.haxx.se/dev/archive-2014-04/0245.shtml > > Please see the details below. > > Log message: > [[[ > Avoid shared data clashes between repositories duplicated using 'hotcopy',