On Fri, Aug 8, 2014 at 7:24 PM, Evgeny Kotkov <evgeny.kot...@visualsvn.com> wrote:
> Hi, > > I would like to propose a patch for the problem discussed in > http://svn.haxx.se/dev/archive-2014-04/0245.shtml > > Please see the details below. > [...] Hi Evgeny, Thanks for having a the (missing) instance ID issue. >From initial review, I have 1 objection and 2 issues that your patch does not address, yet. * Ideally, we would store the instance UUID as a separate file next to uuid and friends. Presumably trying to not increase the fs_open latency low, you merged that info into the format file - causing various ripple effects. I think it should be put into the UUID file (or a separate file altogether) and update places where we rewrite this file (e.g. svnadmin load). * The instance ID must become part of the cache key. This is for the hot-restore-from-backup use-case where a repository gets replaced with an older version of itself while the server process is kept alive (caches are still hot). * svnadmin should have a means to bump the instance ID. Again, the restore-from-backup use-case. All these bit can be developed and reviewed neatly on a branch. -- Stefan^2.
