Re: [PATCH] Infrastructure to exclude comparing lines

2010-09-22 Thread Daniel Shahaf
Thanks for the explanation. Given that svnrdump's output, as is, is semantically correct, and the only issue here is consistency with svnadmin (which produces a different output with the same semantics), and that it's more than a trivial bit of work to get the consistency, +1 for leaving svnrdump

Re: [PATCH] Infrastructure to exclude comparing lines

2010-09-22 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > Ramkumar Ramachandra wrote on Wed, Sep 22, 2010 at 22:24:10 +0530: > > Ok, I think you've misunderstood this. Both of them DO dump the exact > > same properties. Think of the Prop-delta header as just an extra > > cosmetic line. In dumpfile v3, everything is a de

Re: [PATCH] Infrastructure to exclude comparing lines

2010-09-22 Thread Daniel Shahaf
Ramkumar Ramachandra wrote on Wed, Sep 22, 2010 at 22:24:10 +0530: > Hi Daniel, > > Daniel Shahaf writes: > > Ramkumar Ramachandra wrote on Mon, Sep 20, 2010 at 09:39:57 +0530: > > > Daniel Shahaf writes: > > > > * ignore Prop-delta... why? > > > > > > This is because svnrdump outputs "Prop-delta

Re: [PATCH] Infrastructure to exclude comparing lines

2010-09-22 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > Ramkumar Ramachandra wrote on Mon, Sep 20, 2010 at 09:39:57 +0530: > > Daniel Shahaf writes: > > > * ignore Prop-delta... why? > > > > This is because svnrdump outputs "Prop-delta: true" everytime, whether > > it's really a delta or a delta from /dev/null. This

Re: [PATCH] Infrastructure to exclude comparing lines

2010-09-22 Thread Daniel Shahaf
Ramkumar Ramachandra wrote on Mon, Sep 20, 2010 at 09:39:57 +0530: > Daniel Shahaf writes: > > * ignore Prop-delta... why? > > This is because svnrdump outputs "Prop-delta: true" everytime, whether > it's really a delta or a delta from /dev/null. This is quite harmless, > and the logic for omittin

Re: [PATCH] Infrastructure to exclude comparing lines

2010-09-19 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > > +# Mismatched headers during dumping operation > > +mismatched_headers_re = \ > > +"Prop-delta: |Text-content-sha1: |Text-copy-source-md5: |" \ > > +"Text-copy-source-sha1: |Text-delta-base-sha1: .*" > > + > > So: > > * ignore sha1 because RA doesn't

Re: [PATCH] Infrastructure to exclude comparing lines

2010-09-19 Thread Daniel Shahaf
Ramkumar Ramachandra wrote on Sun, Sep 19, 2010 at 17:53:12 +0530: > Hi, > > I thought this patch might need a little bit of special attention. Let > me know quickly if something is obviously wrong with it- as far as I > know, all tests pass and this patch works as expected. I'm going ahead > and

Re: [PATCH] Infrastructure to exclude comparing lines

2010-09-19 Thread Ramkumar Ramachandra
Hi, I've committed this to r998661, but the Subversion bot reports some breakages. I'm not sure what to make of them though. -- Ram