Hi Daniel, Daniel Shahaf writes: > Ramkumar Ramachandra wrote on Mon, Sep 20, 2010 at 09:39:57 +0530: > > Daniel Shahaf writes: > > > * ignore Prop-delta... why? > > > > This is because svnrdump outputs "Prop-delta: true" everytime, whether > > it's really a delta or a delta from /dev/null. This is quite harmless, > > and the logic for omitting it when it's a delta from /dev/null can be > > fairly non-trivial and unnecessary. Again, svnadmin dump does it > > "right". > > Okay, but if the Prop-delta: header is generated by one but not by the > other, then the rest of the dump'd props hash should be different too.
Huh? Why? > i.e., if the tests ignore difference in the Prop-delta: header, they > should also be finding more differences later in the props hash --- and > should "somehow" be ignoring those correctly... Ok, I think you've misunderstood this. Both of them DO dump the exact same properties. Think of the Prop-delta header as just an extra cosmetic line. In dumpfile v3, everything is a delta against the previous revision including props. When the Prop-delta header is absent, it doesn't mean that the full props are being listed- it just means that the file or directory didn't exist in a previous revision. For a file or directory that didn't exist in a previous revision- * [Prop-delta missing] is a cosmetic way of saying: "Here's a new file or directory along with it's properties." * Prop-delta: true is a cosmetic way of saying: "Here's a file or directory. If it's new, the delta is against nothing. If it's old, the delta is against a previous version. Check it for yourself- information about whether the file or directory is new is already present in the dumpfile." I hope that clears it up? -- Ram
