hahaf
> >> Cc: Julian Foad; Subversion; Bert Huijben
> >> Subject: Re: [PATCH] Fix for issue 3813
> >>
> >> Daniel Shahaf writes:
> >>
> >> > Looks like Bert committed a functionally equivalent fix as part of
> > r1138474.
> >>
Stefan Sperling writes:
> On Thu, Jun 23, 2011 at 03:25:37PM +0530, Noorul Islam K M wrote:
>
>> I thought if the patch was incorrect, I might be getting some feedback.
>
> Sorry, sometimes things just fall through the cracks :(
>
> Please don't take this as something personal.
Nothing personal
On Thu, Jun 23, 2011 at 03:25:37PM +0530, Noorul Islam K M wrote:
> I thought if the patch was incorrect, I might be getting some feedback.
Sorry, sometimes things just fall through the cracks :(
Please don't take this as something personal.
Communications can be delayed or simply get lost since
"Bert Huijben" writes:
>> -Original Message-
>> From: Noorul Islam K M [mailto:noo...@collab.net]
>> Sent: donderdag 23 juni 2011 5:44
>> To: Daniel Shahaf
>> Cc: Julian Foad; Subversion; Bert Huijben
>> Subject: Re: [PATCH] Fix for issue 381
> -Original Message-
> From: Noorul Islam K M [mailto:noo...@collab.net]
> Sent: donderdag 23 juni 2011 5:44
> To: Daniel Shahaf
> Cc: Julian Foad; Subversion; Bert Huijben
> Subject: Re: [PATCH] Fix for issue 3813
>
> Daniel Shahaf writes:
>
> > Looks l
Daniel Shahaf writes:
> Looks like Bert committed a functionally equivalent fix as part of r1138474.
>
Bert,
May I know why this patch was not considered? Looking at the commit I
could not see any difference.
Thanks and Regards
Noorul
> Noorul Islam K M wrote on Wed, Jun 22, 2011 at 16:40:50
Looks like Bert committed a functionally equivalent fix as part of r1138474.
Noorul Islam K M wrote on Wed, Jun 22, 2011 at 16:40:50 +0530:
> +++ subversion/libsvn_wc/diff_editor.c(working copy)
> @@ -1532,13 +1531,8 @@
>
>
>
> - /* This is the file that will contain the pristine re
Greg Hudson wrote on Wed, Jun 22, 2011 at 11:01:05 -0400:
> On Wed, 2011-06-22 at 02:29 -0400, Daniel Shahaf wrote:
> > From looking at the code, svn_io_open_unique_file3() would force the
> > file to have a mode of 0600|umask() instead of just 0600
>
> The umask removes file permissions from the
On Wed, 2011-06-22 at 02:29 -0400, Daniel Shahaf wrote:
> From looking at the code, svn_io_open_unique_file3() would force the
> file to have a mode of 0600|umask() instead of just 0600
The umask removes file permissions from the mode argument to open(); it
doesn't add permissions. (Unless there'
Julian Foad writes:
> Noorul Islam K M wrote:
>
>> Subject: Re: [PATCH] Fix for issue 3813
> [...]
>> [[[
>> Fix for issue 3813.
>> [...]
>> ]]]
>
> Hi Noorul. Please always include a brief description of the issue in
> the email subject line
Noorul Islam K M wrote:
> Subject: Re: [PATCH] Fix for issue 3813
[...]
> [[[
> Fix for issue 3813.
> [...]
> ]]]
Hi Noorul. Please always include a brief description of the issue in
the email subject line and in the log message. Anyone reading the text
should be able to quickly
On Wed, Jun 22, 2011 at 09:29:29AM +0300, Daniel Shahaf wrote:
> Noorul Islam K M wrote on Wed, Jun 22, 2011 at 11:37:13 +0530:
> >
> > I am not really sure whether this patch is correct one since the comment
> > in diff_editor.c says this
> >
> > /* This is the file that will contain the prist
Noorul Islam K M wrote on Wed, Jun 22, 2011 at 11:37:13 +0530:
>
> I am not really sure whether this patch is correct one since the comment
> in diff_editor.c says this
>
> /* This is the file that will contain the pristine repository version. It
> is created in the admin temporary area. T
13 matches
Mail list logo
