Re: [PATCH] Add platform information to user agent string

2012-11-05 Thread Branko Čibej
On 05.11.2012 15:43, Ivan Zhakov wrote: > On Mon, Nov 5, 2012 at 6:30 PM, Branko Čibej wrote: >> On 05.11.2012 15:10, Ivan Zhakov wrote: >>> Here is updated patch: >>> [[[ >>> Add target platform information to user agent string. >>> >>> * subversion/libsvn_ra_serf/ra_serf.h >>> (USER_AGENT): Ad

Re: [PATCH] Add platform information to user agent string

2012-11-05 Thread Ivan Zhakov
On Mon, Nov 5, 2012 at 6:34 PM, Ben Reser wrote: > On Mon, Nov 5, 2012 at 6:10 AM, Ivan Zhakov wrote: >> Here is updated patch: >> [[[ >> Add target platform information to user agent string. >> >> * subversion/libsvn_ra_serf/ra_serf.h >> (USER_AGENT): Add target platform information. >> * subv

Re: [PATCH] Add platform information to user agent string

2012-11-05 Thread Ivan Zhakov
On Mon, Nov 5, 2012 at 7:05 PM, Bert Huijben wrote: > > >> -Original Message- >> From: Ivan Zhakov [mailto:i...@visualsvn.com] >> Sent: maandag 5 november 2012 15:10 >> To: Branko Čibej >> Cc: dev@subversion.apache.org >> Subject: Re: [PATCH] Add

RE: [PATCH] Add platform information to user agent string

2012-11-05 Thread Bert Huijben
> -Original Message- > From: Branko Čibej [mailto:br...@wandisco.com] > Sent: maandag 5 november 2012 15:31 > To: dev@subversion.apache.org > Subject: Re: [PATCH] Add platform information to user agent string > > On 05.11.2012 15:10, Ivan Zhakov wrote: >

RE: [PATCH] Add platform information to user agent string

2012-11-05 Thread Bert Huijben
> -Original Message- > From: Ivan Zhakov [mailto:i...@visualsvn.com] > Sent: maandag 5 november 2012 15:10 > To: Branko Čibej > Cc: dev@subversion.apache.org > Subject: Re: [PATCH] Add platform information to user agent string > > On Fri, Nov 2, 2012 at 10:4

Re: [PATCH] Add platform information to user agent string

2012-11-05 Thread Ivan Zhakov
On Mon, Nov 5, 2012 at 6:30 PM, Branko Čibej wrote: > On 05.11.2012 15:10, Ivan Zhakov wrote: >> Here is updated patch: >> [[[ >> Add target platform information to user agent string. >> >> * subversion/libsvn_ra_serf/ra_serf.h >> (USER_AGENT): Add target platform information. >> * subversion/li

Re: [PATCH] Add platform information to user agent string

2012-11-05 Thread Ben Reser
On Mon, Nov 5, 2012 at 6:10 AM, Ivan Zhakov wrote: > Here is updated patch: > [[[ > Add target platform information to user agent string. > > * subversion/libsvn_ra_serf/ra_serf.h > (USER_AGENT): Add target platform information. > * subversion/libsvn_ra_serf/ra_svn.h > (SVN_RA_SVN__DEFAULT_USE

Re: [PATCH] Add platform information to user agent string

2012-11-05 Thread Branko Čibej
On 05.11.2012 15:10, Ivan Zhakov wrote: > Here is updated patch: > [[[ > Add target platform information to user agent string. > > * subversion/libsvn_ra_serf/ra_serf.h > (USER_AGENT): Add target platform information. > * subversion/libsvn_ra_serf/ra_svn.h > (SVN_RA_SVN__DEFAULT_USERAGENT): Add

Re: [PATCH] Add platform information to user agent string

2012-11-05 Thread Ivan Zhakov
On Fri, Nov 2, 2012 at 10:40 PM, Ivan Zhakov wrote: > On Fri, Nov 2, 2012 at 9:04 PM, Branko Čibej wrote: >> >> On 02.11.2012 17:30, Ivan Zhakov wrote: >> > On Fri, Nov 2, 2012 at 5:12 PM, Branko Čibej wrote: >> >> On 02.11.2012 12:36, Ivan Zhakov wrote: >> >>> On Wed, Oct 31, 2012 at 2:04 AM, B

Re: [PATCH] Add platform information to user agent string

2012-11-02 Thread Ivan Zhakov
On Fri, Nov 2, 2012 at 9:04 PM, Branko Čibej wrote: > > On 02.11.2012 17:30, Ivan Zhakov wrote: > > On Fri, Nov 2, 2012 at 5:12 PM, Branko Čibej wrote: > >> On 02.11.2012 12:36, Ivan Zhakov wrote: > >>> On Wed, Oct 31, 2012 at 2:04 AM, Branko Čibej wrote: > >>> [..] > The sysinfo bits have

Re: [PATCH] Add platform information to user agent string

2012-11-02 Thread Branko Čibej
On 02.11.2012 17:30, Ivan Zhakov wrote: > On Fri, Nov 2, 2012 at 5:12 PM, Branko Čibej wrote: >> On 02.11.2012 12:36, Ivan Zhakov wrote: >>> On Wed, Oct 31, 2012 at 2:04 AM, Branko Čibej wrote: >>> [..] The sysinfo bits have static (build-time) info and dynamic (runtime) info. Presumabl

Re: [PATCH] Add platform information to user agent string

2012-11-02 Thread Ivan Zhakov
On Fri, Nov 2, 2012 at 5:12 PM, Branko Čibej wrote: > On 02.11.2012 12:36, Ivan Zhakov wrote: >> On Wed, Oct 31, 2012 at 2:04 AM, Branko Čibej wrote: >> [..] >>> The sysinfo bits have static (build-time) info and dynamic (runtime) >>> info. Presumably the only difference will be noticing when you

Re: [PATCH] Add platform information to user agent string

2012-11-02 Thread C. Michael Pilato
On 11/02/2012 09:28 AM, Branko Čibej wrote: > On 02.11.2012 14:21, Ivan Zhakov wrote: >> Using $target or $host is not important question for me. More >> important question which components use in user-agent string: all >> triplet or only OS? > > I suggest using the same string that's displayed by

Re: [PATCH] Add platform information to user agent string

2012-11-02 Thread Ivan Zhakov
On Fri, Nov 2, 2012 at 5:28 PM, Branko Čibej wrote: > On 02.11.2012 14:21, Ivan Zhakov wrote: >> On Fri, Nov 2, 2012 at 5:12 PM, Branko Čibej wrote: >>> On 02.11.2012 12:36, Ivan Zhakov wrote: On Wed, Oct 31, 2012 at 2:04 AM, Branko Čibej wrote: [..] > The sysinfo bits have static

Re: [PATCH] Add platform information to user agent string

2012-11-02 Thread Branko Čibej
On 02.11.2012 14:21, Ivan Zhakov wrote: > On Fri, Nov 2, 2012 at 5:12 PM, Branko Čibej wrote: >> On 02.11.2012 12:36, Ivan Zhakov wrote: >>> On Wed, Oct 31, 2012 at 2:04 AM, Branko Čibej wrote: >>> [..] The sysinfo bits have static (build-time) info and dynamic (runtime) info. Presumabl

Re: [PATCH] Add platform information to user agent string

2012-11-02 Thread Ivan Zhakov
On Fri, Nov 2, 2012 at 5:12 PM, Branko Čibej wrote: > On 02.11.2012 12:36, Ivan Zhakov wrote: >> On Wed, Oct 31, 2012 at 2:04 AM, Branko Čibej wrote: >> [..] >>> The sysinfo bits have static (build-time) info and dynamic (runtime) >>> info. Presumably the only difference will be noticing when you

Re: [PATCH] Add platform information to user agent string

2012-11-02 Thread Branko Čibej
On 02.11.2012 12:36, Ivan Zhakov wrote: > On Wed, Oct 31, 2012 at 2:04 AM, Branko Čibej wrote: > [..] >> The sysinfo bits have static (build-time) info and dynamic (runtime) >> info. Presumably the only difference will be noticing when you're >> running the program on a different "size" of OS, e.g

Re: [PATCH] Add platform information to user agent string

2012-11-02 Thread Ivan Zhakov
On Wed, Oct 31, 2012 at 2:04 AM, Branko Čibej wrote: [..] > > The sysinfo bits have static (build-time) info and dynamic (runtime) > info. Presumably the only difference will be noticing when you're > running the program on a different "size" of OS, e.g., running 32-bit > code on a 64-bit OS (hope

Re: [PATCH] Add platform information to user agent string

2012-11-02 Thread Ivan Zhakov
On Wed, Oct 31, 2012 at 1:46 AM, Stefan Sperling wrote: > On Wed, Oct 31, 2012 at 12:25:43AM +0400, Ivan Zhakov wrote: >> I completely agree that it would be great to have one code to get >> platform information. But current svn_sysinfo* implementation provides >> detailed information which very e

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread Branko Čibej
On 30.10.2012 21:25, Ivan Zhakov wrote: > On Tue, Oct 30, 2012 at 10:42 PM, C. Michael Pilato > wrote: >> On 10/30/2012 02:15 PM, Julian Foad wrote: >>> Ivan Zhakov wrote: >>> On Tue, Oct 30, 2012 at 8:07 PM, Ben Reser wrote: > On Tue, Oct 30, 2012 at 8:28 AM, Ivan Zhakov wrote: >> I

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread Stefan Sperling
On Wed, Oct 31, 2012 at 12:25:43AM +0400, Ivan Zhakov wrote: > I completely agree that it would be great to have one code to get > platform information. But current svn_sysinfo* implementation provides > detailed information which very expensive to obtain. In some codepath > we have to execute exte

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread Ivan Zhakov
On Tue, Oct 30, 2012 at 10:42 PM, C. Michael Pilato wrote: > On 10/30/2012 02:15 PM, Julian Foad wrote: >> Ivan Zhakov wrote: >> >>> On Tue, Oct 30, 2012 at 8:07 PM, Ben Reser wrote: On Tue, Oct 30, 2012 at 8:28 AM, Ivan Zhakov wrote: > I think it will be useful to add client platform inf

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread C. Michael Pilato
[ THIS WAS AN EARLIER DRAFT OF MY INTENDED MAIL. NOT SURE ] [ HOW IT HIT THE LIST. PLEASE IGNORE. ] On 10/30/2012 02:39 PM, C. Michael Pilato wrote: > On 10/30/2012 02:15 PM, Julian Foad wrote: >> Ivan Zhakov wrote: >> >>> On Tue, Oct 30, 2012 at 8:07 PM, Ben Rese

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread C. Michael Pilato
On 10/30/2012 02:15 PM, Julian Foad wrote: > Ivan Zhakov wrote: > >> On Tue, Oct 30, 2012 at 8:07 PM, Ben Reser wrote: >>> On Tue, Oct 30, 2012 at 8:28 AM, Ivan Zhakov wrote: I think it will be useful to add client platform information to user agent string, to use it Apache HTTP Server c

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread C. Michael Pilato
On 10/30/2012 02:15 PM, Julian Foad wrote: > Ivan Zhakov wrote: > >> On Tue, Oct 30, 2012 at 8:07 PM, Ben Reser wrote: >>> On Tue, Oct 30, 2012 at 8:28 AM, Ivan Zhakov wrote: I think it will be useful to add client platform information to user agent string, to use it Apache HTTP Server c

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread Julian Foad
Ivan Zhakov wrote: > On Tue, Oct 30, 2012 at 8:07 PM, Ben Reser wrote: >> On Tue, Oct 30, 2012 at 8:28 AM, Ivan Zhakov wrote: >>> I think it will be useful to add client platform information to user >>> agent string, to use it Apache HTTP Server configuration or Subversion >>> hooks. Within my

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread Ivan Zhakov
On Tue, Oct 30, 2012 at 8:07 PM, Ben Reser wrote: > On Tue, Oct 30, 2012 at 8:28 AM, Ivan Zhakov wrote: >> I think it will be useful to add client platform information to user >> agent string, to use it Apache HTTP Server configuration or Subversion >> hooks. Within my patch applied user agent wi

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread Stefan Sperling
On Tue, Oct 30, 2012 at 08:00:00PM +0400, Ivan Zhakov wrote: > You already broadcast this information when browsing the Internet :) Not with a custom user agent string a browser allows me to set :) > Also we already broadcast SVN version information. So I don't see big > issue here. Of course it

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread Ben Reser
On Tue, Oct 30, 2012 at 8:28 AM, Ivan Zhakov wrote: > I think it will be useful to add client platform information to user > agent string, to use it Apache HTTP Server configuration or Subversion > hooks. Within my patch applied user agent will be like this: > SVN/1.8.0 (Windows) serf/1.1.1 Tortoi

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread Ivan Zhakov
On Tue, Oct 30, 2012 at 7:49 PM, Stefan Sperling wrote: > On Tue, Oct 30, 2012 at 07:28:27PM +0400, Ivan Zhakov wrote: >> Hi, >> >> I think it will be useful to add client platform information to user >> agent string, to use it Apache HTTP Server configuration or Subversion >> hooks. Within my pat

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread Stefan Sperling
On Tue, Oct 30, 2012 at 07:28:27PM +0400, Ivan Zhakov wrote: > Hi, > > I think it will be useful to add client platform information to user > agent string, to use it Apache HTTP Server configuration or Subversion > hooks. Within my patch applied user agent will be like this: > SVN/1.8.0 (Windows)