Re: [PATCH]: Encoding fix mailer.py

2012-11-13 Thread C. Michael Pilato
On 11/13/2012 03:19 AM, Igor Galić wrote: >>> >>> Igor, I took a look at your patch. I was confused by one aspect: >>> why split >>> the from_addr into words an encode each one individually, rather >>> than >>> encoding the whole header value like we do for the Subject: header? >>> I dug >>> aroun

Re: [PATCH]: Encoding fix mailer.py

2012-11-13 Thread Igor Galić
> > > > Igor, I took a look at your patch. I was confused by one aspect: > > why split > > the from_addr into words an encode each one individually, rather > > than > > encoding the whole header value like we do for the Subject: header? > > I dug > > around in the related RFCs, and if I'm reading

Re: [PATCH]: Encoding fix mailer.py

2012-11-09 Thread C. Michael Pilato
On 11/09/2012 09:31 AM, C. Michael Pilato wrote: > On 09/04/2012 12:58 PM, Igor Galić wrote: >> Hey folks, >> >> I've patched up my local mailer.py[1] to correctly encode >> "From: " Headers. >> >> The attached patch *works* but it's not pretty. >> >> Someone who actually knows Python might want to

Re: [PATCH]: Encoding fix mailer.py

2012-11-09 Thread C. Michael Pilato
On 09/04/2012 12:58 PM, Igor Galić wrote: > Hey folks, > > I've patched up my local mailer.py[1] to correctly encode > "From: " Headers. > > The attached patch *works* but it's not pretty. > > Someone who actually knows Python might want to encapsulate > my changes in a function. > > n.b.: I am