Re: 'svn log --diff' foils log output parsers

2011-06-24 Thread C. Michael Pilato
On 06/24/2011 01:35 PM, Branko Čibej wrote: > On 24.06.2011 17:50, C. Michael Pilato wrote: >> Having read and considered the replies received thus far, I'm dubbing this a >> non-issue and moving on. Thanks for the feedback, all who provided it. > > Just for the record, this same issue has existe

Re: 'svn log --diff' foils log output parsers

2011-06-24 Thread Daniel Shahaf
Branko Čibej wrote on Fri, Jun 24, 2011 at 19:35:14 +0200: > On 24.06.2011 17:50, C. Michael Pilato wrote: > > Having read and considered the replies received thus far, I'm dubbing this a > > non-issue and moving on. Thanks for the feedback, all who provided it. > > Just for the record, this same

Re: 'svn log --diff' foils log output parsers

2011-06-24 Thread Branko Čibej
On 24.06.2011 17:50, C. Michael Pilato wrote: > Having read and considered the replies received thus far, I'm dubbing this a > non-issue and moving on. Thanks for the feedback, all who provided it. Just for the record, this same issue has existed since "svn log" first accepted the --verbose flag.

Re: 'svn log --diff' foils log output parsers

2011-06-24 Thread C. Michael Pilato
Having read and considered the replies received thus far, I'm dubbing this a non-issue and moving on. Thanks for the feedback, all who provided it. On 06/23/2011 03:15 PM, C. Michael Pilato wrote: > When we designed 'svn log' many moons ago, we added the "N lines" header > information to aid par

Re: 'svn log --diff' foils log output parsers

2011-06-23 Thread Peter Samuelson
[C. Michael Pilato] > - spool the diff, count the lines in it, and provide that count in > some fashion > - indent the diff by a single column > - wrap the whole diff in some start/end markers ("[[[" and "]]]", e.g.) I like the last option, except that I'd use "\n" as the end marker, an

Re: 'svn log --diff' foils log output parsers

2011-06-23 Thread Stefan Sperling
On Thu, Jun 23, 2011 at 03:32:37PM -0400, C. Michael Pilato wrote: > On 06/23/2011 03:18 PM, Mark Phippard wrote: > > Why do we have to do anything? There is no danger of breaking > > existing scripts here because this requires adding an additional > > option. Do we just feel like it would be imp

Re: 'svn log --diff' foils log output parsers

2011-06-23 Thread C. Michael Pilato
On 06/23/2011 03:18 PM, Mark Phippard wrote: > Why do we have to do anything? There is no danger of breaking > existing scripts here because this requires adding an additional > option. Do we just feel like it would be impossible to parse the > current output? Can't --xml be used? The current o

Re: 'svn log --diff' foils log output parsers

2011-06-23 Thread Daniel Shahaf
C. Michael Pilato wrote on Thu, Jun 23, 2011 at 15:15:08 -0400: > We discussed in IRC some solutions: > > - spool the diff, count the lines in it, and provide that count in > some fashion > - indent the diff by a single column > - wrap the whole diff in some start/end markers ("[[[" and

Re: 'svn log --diff' foils log output parsers

2011-06-23 Thread Mark Phippard
On Thu, Jun 23, 2011 at 3:15 PM, C. Michael Pilato wrote: > When we designed 'svn log' many moons ago, we added the "N lines" header > information to aid parsers of the output.  Most of us had had poor > experiences with parsers looking for sentinel lines which could themselves > appear inside the