Re: Pristines-on-demand: fix disabled tests (#4891)

2022-04-07 Thread Johan Corveleyn
Okay, with --wc-format-version=1.8, I now get these (X)FAILs and XPASSes (fails_wc-format-version1.8.log in attachment): [[[ XFAIL: diff-diff3-test 18: 3-way merge, double add XFAIL: dirent_uri-test 47: test match with RFC 6125 s. 6.4.3 Rule 3 XFAIL: op-depth-test 42: mixed_rev_move [[needs

Re: Pristines-on-demand: fix disabled tests (#4891)

2022-04-07 Thread Julian Foad
Johan Corveleyn wrote: >Should be fixed now, with r1899654. Great! Thanks. >I suppose not passing the option uses wc-format-version=1.15 No... >automatically? Or what is the default? Is format 1.8 the same as 1.14 >and anything in between? Default would be the format '31' which is 1.8 through

Re: Pristines-on-demand: fix disabled tests (#4891)

2022-04-07 Thread Johan Corveleyn
On Thu, Apr 7, 2022 at 11:31 AM Julian Foad wrote: > Now can you run the test suite with --wc-format-version=1.15? On Unixy > systems that is done by, for example: > > $ make svnserveautocheck WC_FORMAT_VERSION=1.15 ... Okay, passing that option to win-tests.py (the test runner on Windows) failed

Re: Pristines-on-demand: fix disabled tests (#4891)

2022-04-07 Thread Johan Corveleyn
On Thu, Apr 7, 2022 at 11:31 AM Julian Foad wrote: > Jun Omae wrote: > >> FAIL: diff_tests.py 48: svn diff --diff-cmd provides the correct arguments > > > > I've posted patch for the failure. > > See https://lists.apache.org/thread/2o0xtqfzy9xg8wzxscj2wb641p2kyo9c > > Thank you, Jun Omae. Sorry,

Re: Pristines-on-demand: fix disabled tests (#4891)

2022-04-07 Thread Julian Foad
Johan, that's a great start, thanks. Now can you run the test suite with --wc-format-version=1.15? On Unixy systems that is done by, for example: $ make svnserveautocheck WC_FORMAT_VERSION=1.15 ... Jun Omae wrote: >> FAIL: diff_tests.py 48: svn diff --diff-cmd provides the correct arguments >

Re: Pristines-on-demand: fix disabled tests (#4891)

2022-04-06 Thread Jun Omae
On Thu, Apr 7, 2022 at 2:47 PM Johan Corveleyn wrote: > This is in fails.log for that one FAIL: > [[[ > ... > File "C:\Python39\lib\sre_parse.py", line 426, in _escape > raise source.error("bad escape %s" % escape, len(escape)) > re.error: bad escape \c at position 32 (line 1, column 33) > F

Re: Pristines-on-demand: fix disabled tests (#4891)

2022-04-06 Thread Johan Corveleyn
On Wed, Apr 6, 2022 at 5:12 PM Julian Foad wrote: > Johan Corveleyn wrote: > >> A few of these are Windows-specific. I can't very well investigate those > >> myself. Who could volunteer to look at those? They are: > >> > >> externals_tests.py ... ... ...: > >> update_modify_file_external

Re: Pristines-on-demand: fix disabled tests (#4891)

2022-04-06 Thread Julian Foad
Today I have done a quick review/fix/postpone cycle on the 'upgrade', 'update', and 'trans' tests. Details in https://subversion.apache.org/issue/4891 . - Julian

Re: Pristines-on-demand: fix disabled tests (#4891)

2022-04-06 Thread Julian Foad
Johan Corveleyn wrote: >> A few of these are Windows-specific. I can't very well investigate those >> myself. Who could volunteer to look at those? They are: >> >> externals_tests.py ... ... ...: >> update_modify_file_external(), >> remap_file_external_with_prop_del(), >> fil

Re: Pristines-on-demand: fix disabled tests (#4891)

2022-04-06 Thread Johan Corveleyn
On Wed, Apr 6, 2022 at 4:02 PM Julian Foad wrote: > === Windows-specific issues > > A few of these are Windows-specific. I can't very well investigate those > myself. Who could volunteer to look at those? They are: > > externals_tests.py ... ... ...: > update_modify_file_external(), >

Pristines-on-demand: fix disabled tests (#4891)

2022-04-06 Thread Julian Foad
One of the main things blocking pristines-on-demand now is a few edge case test failures. It would be great if we could get some further eyes on these. On the branch, these failures have been converted to XFAIL by adding '@Wimp' decorators. Some of them seem to fail even when run against the old