Stefan Sperling wrote on Wed, Apr 03, 2013 at 13:12:12 +0200:
> On Wed, Apr 03, 2013 at 02:58:56PM +0400, Ivan Zhakov wrote:
> > On Wed, Apr 3, 2013 at 2:56 PM, Stefan Sperling wrote:
> > > On Wed, Apr 03, 2013 at 02:03:32PM +0400, Ivan Zhakov wrote:
> > >> I'm still not happy with svn_repos_hooks
Branko Čibej writes:
> I thihk there has to be a way to say all of the following:
>
> 1. do not use a hooks-env file at all
> 2. use the default hooks-env file
> 3. use a specific, non-default hooks-env file
Do we need option 2, the default path?
The hooks-env path is specified in apache con
On 03.04.2013 13:01, Philip Martin wrote:
> Ivan Zhakov writes:
>
>> On Wed, Apr 3, 2013 at 4:38 AM, Ben Reser wrote:
>>> I've gone ahead and moved the default hooks-env to hooks-env.tmpl.
>>> We'll still try to open the file but we won't bother to read it in or
>>> parse a completely commented o
Stefan Sperling writes:
> On Wed, Apr 03, 2013 at 02:58:56PM +0400, Ivan Zhakov wrote:
>> I think result_pool parameter should be replaced with pool member in
>> svn_repos_t structure.
>
> Or, as Philip suggested, we could replace the svn_repos_hooks_setenv()
> function with a new 'hooks_env_path
On Wed, Apr 03, 2013 at 02:58:56PM +0400, Ivan Zhakov wrote:
> On Wed, Apr 3, 2013 at 2:56 PM, Stefan Sperling wrote:
> > On Wed, Apr 03, 2013 at 02:03:32PM +0400, Ivan Zhakov wrote:
> >> I'm still not happy with svn_repos_hooks_setenv() API, but this is
> >> separate issue.
> >
> > Why aren't you
Ivan Zhakov writes:
> On Wed, Apr 3, 2013 at 4:38 AM, Ben Reser wrote:
>> I've gone ahead and moved the default hooks-env to hooks-env.tmpl.
>> We'll still try to open the file but we won't bother to read it in or
>> parse a completely commented out file unless the user puts a file in
>> place.
On Wed, Apr 3, 2013 at 2:56 PM, Stefan Sperling wrote:
> On Wed, Apr 03, 2013 at 02:03:32PM +0400, Ivan Zhakov wrote:
>> I'm still not happy with svn_repos_hooks_setenv() API, but this is
>> separate issue.
>
> Why aren't you happy with it?
>
> It's a new API that has to be called in order to acti
On Wed, Apr 03, 2013 at 02:03:32PM +0400, Ivan Zhakov wrote:
> I'm still not happy with svn_repos_hooks_setenv() API, but this is
> separate issue.
Why aren't you happy with it?
It's a new API that has to be called in order to activate the hooks-env
feature. Server-side tools written against 1.7
On Wed, Apr 3, 2013 at 1:48 PM, Ivan Zhakov wrote:
> On Wed, Apr 3, 2013 at 4:38 AM, Ben Reser wrote:
>> I've gone ahead and moved the default hooks-env to hooks-env.tmpl.
>> We'll still try to open the file but we won't bother to read it in or
>> parse a completely commented out file unless the
On Wed, Apr 3, 2013 at 4:38 AM, Ben Reser wrote:
> I've gone ahead and moved the default hooks-env to hooks-env.tmpl.
> We'll still try to open the file but we won't bother to read it in or
> parse a completely commented out file unless the user puts a file in
> place. The .tmpl is a common patte
confusion.
On Thu, Mar 28, 2013 at 2:33 PM, Bert Huijben wrote:
>
>
>> -Original Message-
>> From: Branko Čibej [mailto:br...@wandisco.com]
>> Sent: donderdag 28 maart 2013 22:06
>> To: dev@subversion.apache.org
>> Subject: Re: Opening the reposito
Bert Huijben wrote on Thu, Mar 28, 2013 at 22:33:09 +0100:
> I don't say that we should stop reading fsfs.conf, but why should we
> introduce a 'fs.conf' at the repos level for things that don't belong
> at that level and most likely 99% of our users will never use?
>
fs.conf will be going away.
> -Original Message-
> From: Branko Čibej [mailto:br...@wandisco.com]
> Sent: donderdag 28 maart 2013 22:06
> To: dev@subversion.apache.org
> Subject: Re: Opening the repository hooks environment file
>
> On 28.03.2013 21:50, Bert Huijben wrote:
> >
On 28.03.2013 21:50, Bert Huijben wrote:
>
>> -Original Message-
>> From: MARTIN PHILIP [mailto:codematt...@ntlworld.com] On Behalf Of
>> Philip Martin
>> Sent: donderdag 28 maart 2013 19:32
>> To: Bert Huijben
>> Cc: dev@subversion.apache.org
&
> -Original Message-
> From: MARTIN PHILIP [mailto:codematt...@ntlworld.com] On Behalf Of
> Philip Martin
> Sent: donderdag 28 maart 2013 19:32
> To: Bert Huijben
> Cc: dev@subversion.apache.org
> Subject: Opening the repository hooks environment file
>
On Thu, Mar 28, 2013 at 1:02 PM, Ivan Zhakov wrote:
> Sorry, it seems I missed something important: what is the hooks
> environment file? But I agree that we need explicit mod_dav_svn option
> to enable this functionality if this new in svn 1.8.
http://svn.apache.org/r1380608
On Thu, Mar 28, 2013 at 10:31 PM, Philip Martin
wrote:
> "Bert Huijben" writes:
>
>> The reading of one file for each access to the repository is a more
>> than measurable slowdown when profiling operations. (Reading fsfs.conf
>> over and over again is one of the most expensive things apache work
"Bert Huijben" writes:
> The reading of one file for each access to the repository is a more
> than measurable slowdown when profiling operations. (Reading fsfs.conf
> over and over again is one of the most expensive things apache worker
> processes do when I profiled them. I think stefan2 optimi
18 matches
Mail list logo
