Re: Move change revision parser to libsvn_subr

2024-05-31 Thread Nathan Hartman
On Thu, May 30, 2024 at 1:43 PM Timofey Zhakov wrote: > > Hi Nathan! > > Thank you for the review. > > I agree with your recommendations. Could you please commit the "v7" patch? Committed in r1918076. Thanks! Nathan

Re: Move change revision parser to libsvn_subr

2024-05-30 Thread Timofey Zhakov
Hi Nathan! Thank you for the review. I agree with your recommendations. Could you please commit the "v7" patch? [...] > > Hi Timofei, > > I recommend two minor changes. > > Rather than describe them inline, I'll just attach a modified patch > for convenience ("v7"). > > Please let me know if the

Re: Move change revision parser to libsvn_subr

2024-05-30 Thread Nathan Hartman
On Sun, May 26, 2024 at 2:34 PM Timofey Zhakov wrote: > > On Wed, May 22, 2024 at 10:26 PM Timofey Zhakov wrote: > > > > Hi Nathan, > > > > On Wed, May 22, 2024 at 4:06 PM Nathan Hartman > > wrote: > > > > > > On Tue, May 21, 2024 at 10:31 AM Timofey Zhakov wrote: > > [...] > > > Hi Timofei, >

Re: Move change revision parser to libsvn_subr

2024-05-26 Thread Timofey Zhakov
On Wed, May 22, 2024 at 10:26 PM Timofey Zhakov wrote: > > Hi Nathan, > > On Wed, May 22, 2024 at 4:06 PM Nathan Hartman > wrote: > > > > On Tue, May 21, 2024 at 10:31 AM Timofey Zhakov wrote: > [...] > > Hi Timofei, > > > > I haven't looked at the code yet, but I'd like to say that > > concept

Re: Move change revision parser to libsvn_subr

2024-05-22 Thread Timofey Zhakov
Hi Nathan, On Wed, May 22, 2024 at 4:06 PM Nathan Hartman wrote: > > On Tue, May 21, 2024 at 10:31 AM Timofey Zhakov wrote: [...] > Hi Timofei, > > I haven't looked at the code yet, but I'd like to say that > conceptually a refactor with improved unit testing sounds good. > > It's a shame that m

Re: Move change revision parser to libsvn_subr

2024-05-22 Thread Nathan Hartman
On Tue, May 21, 2024 at 10:31 AM Timofey Zhakov wrote: > > Hi, > > When I was fixing a bug related to the change revision argument (-c), > I noticed that the function which parses the change revision argument > is implemented implicitly in the sub_main (in file svn.c) [1], while > other revision p

Move change revision parser to libsvn_subr

2024-05-21 Thread Timofey Zhakov
Hi, When I was fixing a bug related to the change revision argument (-c), I noticed that the function which parses the change revision argument is implemented implicitly in the sub_main (in file svn.c) [1], while other revision parsers such as svn_opt_parse_revision_to_range are implemented in the