Hi Nathan!
Thank you for the review.
I agree with your recommendations. Could you please commit the "v7" patch?
[...]
>
> Hi Timofei,
>
> I recommend two minor changes.
>
> Rather than describe them inline, I'll just attach a modified patch
> for convenience ("v7").
>
> Please let me know if these are agreeable to you, and I'll go ahead
> and commit...
>
> The changes are:
>
> (1) Adding comments: Previously, when the --change parsing was in
> svn.c::sub_main(), the text of the individual error messages helped
> understand the various checks for zero, negative, non-numeric, etc. As
> the error texts are no longer mixed with the parsing code, the checks
> are less obvious, so I added those texts as comments.
I didn't think about it before, but I think it is a good idea.
> (2) Minor mistake in docstring: In svn_opt.h the docstring for
> svn_opt_parse_change_to_range() referred to parameter "pool" but it is
> actually called "result_pool".
Oops, I forgot to change it when renaming the argument.
> Otherwise, looks good.
>
> Thanks for helping!
Thanks!
--
Timofei Zhakov
