Re: Hook scripts start with an empty environment

2010-04-10 Thread Alan Barrett
On Wed, 24 Mar 2010, Tim Starling wrote: > Hook scripts start with an empty environment instead of inheriting it > from svnserve or whatever. > > This is inconvenient, not least for the case where you want to commit > something to an svn+ssh server via a local pushmi mirror on file

Re: Hook scripts start with an empty environment

2010-03-24 Thread Greg Hudson
On Wed, 2010-03-24 at 16:45 -0400, Tim Starling wrote: > But like I said, I'm happy with it being configurable. Do you want a > patch for that too? It's a fair bit more complicated than the one I > already did so I didn't want to try it without at least in-principle > approval. I haven't been acti

Re: Hook scripts start with an empty environment

2010-03-24 Thread Tim Starling
Greg Hudson wrote: > It might be reasonable to have said from the start, "if you're in the > third situation, then your hook scripts should clear their own > environments," but we can't start saying that in release 1.7. We can > detect a setuid or setgid bit, but we cannot detect a restricted shel

Re: Hook scripts start with an empty environment

2010-03-24 Thread Greg Hudson
Although I've always been aware of the design intent behind empty hook script environments, I'll echo Tim's complaint that it's sometimes inconvenient. The problem most commonly crops up in svn+ssh:// or file:// deployments where you want to run some action with user credentials: updating a bug da

Re: Hook scripts start with an empty environment

2010-03-24 Thread Tim Starling
Bert Huijben wrote: > >> -Original Message- >> From: Tim Starling [mailto:tstarl...@wikimedia.org] >> Sent: woensdag 24 maart 2010 7:19 >> To: dev@subversion.apache.org >> Subject: Hook scripts start with an empty environment >> >> Hook scrip

RE: Hook scripts start with an empty environment

2010-03-24 Thread Bert Huijben
> -Original Message- > From: Tim Starling [mailto:tstarl...@wikimedia.org] > Sent: woensdag 24 maart 2010 7:19 > To: dev@subversion.apache.org > Subject: Hook scripts start with an empty environment > > Hook scripts start with an empty environment instead of

Hook scripts start with an empty environment

2010-03-23 Thread Tim Starling
Hook scripts start with an empty environment instead of inheriting it from svnserve or whatever. This is inconvenient, not least for the case where you want to commit something to an svn+ssh server via a local pushmi mirror on file:/// and your SSH_AUTH_SOCK is lost so you have to type your