Re: Deletion revision in Ev2

On Mon, May 7, 2012 at 3:02 PM, Hyrum K Wright wrote: > On Mon, May 7, 2012 at 1:43 PM, Greg Stein wrote: >... >>>... >>> Simply eliminating the check in editor.c:delete_cb(), and also >>> changing can_modify() to allow invalid revision to act as a wildcard >>> (i.e., "don't bother checking, I kn

Re: Deletion revision in Ev2

On Mon, May 7, 2012 at 1:43 PM, Greg Stein wrote: > On Mon, May 7, 2012 at 12:37 PM, Hyrum K Wright > wrote: >>... >> In this case, we are legitimately deleting B/C, but the "revision this >> thing is being deleted from" doesn't exist until commit finalization. > > True. I figured as the FS, we a

Re: Deletion revision in Ev2

On Mon, May 7, 2012 at 12:37 PM, Hyrum K Wright wrote: >... > In this case, we are legitimately deleting B/C, but the "revision this > thing is being deleted from" doesn't exist until commit finalization. True. I figured as the FS, we always had a revision... but that's not true :-P >... > Simpl

Deletion revision in Ev2

Greg, I noticed there is a check in the filesystem editor implementation to ensure we have a valid revision during delete. Unfortunately, we don't always have such a revision a priori, which means this check is not always valid. Consider the following: $ svn cp A B $ svn rm B/C $ svn ci In this