Re: Choice of constant in libsvn_fs_base

2011-11-27 Thread Branko Čibej
On 25.11.2011 16:24, Julian Foad wrote: > Daniel Shahaf wrote: > >> While reviewing r1205726 I came across this pearl: >> >> reps-strings.c- /* Make a list of all the rep's we need to undeltify this >> range. >> reps-strings.c- We'll have to read them within this trail anyway, so we >> might

Re: Choice of constant in libsvn_fs_base

2011-11-25 Thread Julian Foad
Daniel Shahaf wrote: > While reviewing r1205726 I came across this pearl: > > reps-strings.c-  /* Make a list of all the rep's we need to undeltify this > range. > reps-strings.c-    We'll have to read them within this trail anyway, so we > might > reps-strings.c-    as well do it once and up

Re: Choice of constant in libsvn_fs_base

2011-11-24 Thread Hyrum K Wright
On Thu, Nov 24, 2011 at 4:00 PM, Daniel Shahaf wrote: > While reviewing r1205726 I came across this pearl: > > reps-strings.c- /* Make a list of all the rep's we need to > undeltify this range. > reps-strings.c- We'll have to read them within this trail > anyway, so we might

Choice of constant in libsvn_fs_base

2011-11-24 Thread Daniel Shahaf
While reviewing r1205726 I came across this pearl: reps-strings.c- /* Make a list of all the rep's we need to undeltify this range. reps-strings.c- We'll have to read them within this trail anyway, so we might reps-strings.c- as well do it once and up front. */ r