While reviewing r1205726 I came across this pearl:

reps-strings.c-          /* Make a list of all the rep's we need to undeltify 
this range.
reps-strings.c-             We'll have to read them within this trail anyway, 
so we might
reps-strings.c-             as well do it once and up front. */
reps-strings.c-          apr_array_header_t *reps =  /* ### what constant here? 
*/
reps-strings.c:            apr_array_make(pool, 666, sizeof(rep));

Isn't that constant a little too large?  Will any existing repository
ever need a chain of deltas that contains >600 elements?  Can we set the
constant to 30?

Reply via email to