Re: [Patch] (swig-py) accept core.svn_stream_t object for svn_stream_t *

On 12/11/18 6:12 AM, Jun Omae wrote: > On 2018/12/10 22:37, Michael Pilato wrote: >> Most of the patch is fine.  Besides some minor code formatting tweaks, >> there's only one bit I really changed when committing (as r1848577): > > Thanks for the reviewing and tweaking. > > Reconsidering the chec

Re: [Patch] (swig-py) accept core.svn_stream_t object for svn_stream_t *

Hi, On 2018/12/10 22:37, Michael Pilato wrote: Most of the patch is fine. Besides some minor code formatting tweaks, there's only one bit I really changed when committing (as r1848577): Thanks for the reviewing and tweaking. Reconsidering the checking instance of svn_stream_t in svn_swig_py

Re: [Patch] (swig-py) accept core.svn_stream_t object for svn_stream_t *

On 12/8/18 3:57 AM, Yasuhito FUTATSUKI wrote: > On 12/6/18 5:06 PM, Yasuhito FUTATSUKI wrote: > Jun Omae kindly reviewed and rewrote my patch to move code to check object > type into svn_swig_py_make_stream() in swigutil_py.c to minimize expansion > of typemap, and added test for parse_fns3_invalid

Re: [Patch] (swig-py) accept core.svn_stream_t object for svn_stream_t *

On 12/10/18 7:03 AM, Branko Čibej wrote: > On 09.12.2018 17:52, Yasuhito FUTATSUKI wrote: >> Ah, former patch has already been commited. Thank you. >> I'm sorry I didn't watch trunk. > > That's fine! And thank you for your contribution. > > If you think your second patch is better, please conside

Re: [Patch] (swig-py) accept core.svn_stream_t object for svn_stream_t *

On 09.12.2018 17:52, Yasuhito FUTATSUKI wrote: > Ah, former patch has already been commited. Thank you. > I'm sorry I didn't watch trunk. That's fine! And thank you for your contribution. If you think your second patch is better, please consider updating it so that it applies to current trunk. -

Re: [Patch] (swig-py) accept core.svn_stream_t object for svn_stream_t *

Ah, former patch has already been commited. Thank you. I'm sorry I didn't watch trunk. -- Yasuhito FUTATSUKI

Re: [Patch] (swig-py) accept core.svn_stream_t object for svn_stream_t *

On 12/6/18 5:06 PM, Yasuhito FUTATSUKI wrote: Hi, I found SWIP Python bindings of APIs using svn_stream_t * in _client, _delta, _diff, _fs, _ra and _repos don't accept core.svn_stream_t proxy objects, so I modified %typemap(in) svn_stream_t *WRAPPED_STRAM to accept them as well as file like objec

[Patch] (swig-py) accept core.svn_stream_t object for svn_stream_t *

Hi, I found SWIP Python bindings of APIs using svn_stream_t * in _client, _delta, _diff, _fs, _ra and _repos don't accept core.svn_stream_t proxy objects, so I modified %typemap(in) svn_stream_t *WRAPPED_STRAM to accept them as well as file like objects. The patch below is destined to trunk@18480