On 12/11/18 6:12 AM, Jun Omae wrote: > On 2018/12/10 22:37, Michael Pilato wrote: >> Most of the patch is fine. Besides some minor code formatting tweaks, >> there's only one bit I really changed when committing (as r1848577): > > Thanks for the reviewing and tweaking. > > Reconsidering the checking instance of svn_stream_t in > svn_swig_py_make_stream(), > I think the code is redundant. Using svn_swig_py_convert_ptr() would > simplify > the converting the given py_io parameter to a svn_stream_t pointer. > > Thoughts?
I agree that we can avoid doing the same sort of stuff that SWIG_ConvertPtr() would do on our behalf. The patch makes our code much tighter (and easy to read). Committed as-is in r1848763. Thanks!
