Re: [PR] mod_dav_svn: Use mod_dav's DAVBasePath setting [subversion]

2025-06-24 Thread via GitHub
asfgit closed pull request #28: mod_dav_svn: Use mod_dav's DAVBasePath setting URL: https://github.com/apache/subversion/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] mod_dav_svn: Use mod_dav's DAVBasePath setting [subversion]

2025-06-02 Thread via GitHub
notroj commented on PR #28: URL: https://github.com/apache/subversion/pull/28#issuecomment-2931443469 Rebased to use the 2.4.x MMN as a minimum, now that c43d8e949b8dfd68cd050f193a5552f1c1ee8e93 is merged -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] mod_dav_svn: Use mod_dav's DAVBasePath setting [subversion]

2025-05-02 Thread via GitHub
dsahlberg-apache-org commented on code in PR #28: URL: https://github.com/apache/subversion/pull/28#discussion_r2071841462 ## subversion/mod_dav_svn/mod_dav_svn.c: ## @@ -781,6 +781,15 @@ const char * dav_svn__get_root_dir(request_rec *r) { dir_conf_t *conf; + const char *

Re: [PR] mod_dav_svn: Use mod_dav's DAVBasePath setting [subversion]

2025-05-02 Thread via GitHub
notroj commented on PR #28: URL: https://github.com/apache/subversion/pull/28#issuecomment-2847561930 Getting there... the tests against httpd trunk were failing because of a regression in httpd trunk. So that's a nice success :partying_face: Fixed in https://github.com/apache/httpd

Re: [PR] mod_dav_svn: Use mod_dav's DAVBasePath setting [subversion]

2025-05-02 Thread via GitHub
MarsrockEarth commented on PR #28: URL: https://github.com/apache/subversion/pull/28#issuecomment-2847563160 您的来信已收到 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] mod_dav_svn: Use mod_dav's DAVBasePath setting [subversion]

2025-04-09 Thread Daniel Sahlberg
Den mån 24 feb. 2025 kl 16:06 skrev notroj (via GitHub) : > > notroj commented on PR #28: > URL: https://github.com/apache/subversion/pull/28#issuecomment-2678738474 > >> Builds and tests complete successfully with HTTPD 2.4.58. Have not > tested with HTTPD trunk and I don't think we have a te

Re: [PR] mod_dav_svn: Use mod_dav's DAVBasePath setting [subversion]

2025-03-14 Thread via GitHub
MarsrockEarth commented on PR #28: URL: https://github.com/apache/subversion/pull/28#issuecomment-2724190636 您的来信已收到 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] mod_dav_svn: Use mod_dav's DAVBasePath setting [subversion]

2025-03-14 Thread via GitHub
dsahlberg-apache-org commented on PR #28: URL: https://github.com/apache/subversion/pull/28#issuecomment-2724189280 @notroj Do you want to add the CI workflow before you commit this or can we go ahead and commit and close the PR? -- This is an automated message from the Apache Git Service

Re: [PR] mod_dav_svn: Use mod_dav's DAVBasePath setting [subversion]

2025-02-24 Thread via GitHub
notroj commented on PR #28: URL: https://github.com/apache/subversion/pull/28#issuecomment-2678738474 > Builds and tests complete successfully with HTTPD 2.4.58. Have not tested with HTTPD trunk and I don't think we have a test case for LocationMatch anyway. Yeah, I will add a CI work

Re: [PR] mod_dav_svn: Use mod_dav's DAVBasePath setting [subversion]

2025-02-24 Thread via GitHub
notroj commented on code in PR #28: URL: https://github.com/apache/subversion/pull/28#discussion_r1967810459 ## .github/workflows/autoconf.yml: ## Review Comment: Ah great, looks perfect. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] mod_dav_svn: Use mod_dav's DAVBasePath setting [subversion]

2025-02-24 Thread via GitHub
notroj commented on code in PR #28: URL: https://github.com/apache/subversion/pull/28#discussion_r1967808026 ## subversion/mod_dav_svn/mod_dav_svn.c: ## @@ -781,6 +781,15 @@ const char * dav_svn__get_root_dir(request_rec *r) { dir_conf_t *conf; + const char *base; + Revie

Re: [PR] mod_dav_svn: Use mod_dav's DAVBasePath setting [subversion]

2025-02-21 Thread via GitHub
MarsrockEarth commented on PR #28: URL: https://github.com/apache/subversion/pull/28#issuecomment-2675476968 您的来信已收到 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] mod_dav_svn: Use mod_dav's DAVBasePath setting [subversion]

2025-02-21 Thread via GitHub
dsahlberg-apache-org commented on code in PR #28: URL: https://github.com/apache/subversion/pull/28#discussion_r1966095166 ## .github/workflows/autoconf.yml: ## Review Comment: I already added something very similar in r1923964/r1923965, didn't notice this was already incl

Re: [PR] mod_dav_svn: Use mod_dav's DAVBasePath setting [subversion]

2025-02-07 Thread via GitHub
notroj commented on PR #28: URL: https://github.com/apache/subversion/pull/28#issuecomment-2642877175 The arm64 test failure here is interesting, it is likely to be unrelated to the code change. The arm64 support in GHA is new/experimental so it might be something random but the tests have

[PR] mod_dav_svn: Use mod_dav's DAVBasePath setting [subversion]

2025-02-07 Thread via GitHub
notroj opened a new pull request, #28: URL: https://github.com/apache/subversion/pull/28 ``` mod_dav_svn: Use mod_dav's DAVBasePath setting to determine the repository root path, allowing SVN to be configured via LocationMatch like: DAV svn SVNParentPath /srv/repo