dsahlberg-apache-org commented on code in PR #28:
URL: https://github.com/apache/subversion/pull/28#discussion_r1966095166
##########
.github/workflows/autoconf.yml:
##########
Review Comment:
I already added something very similar in r1923964/r1923965, didn't notice
this was already included in this PR.
##########
subversion/mod_dav_svn/mod_dav_svn.c:
##########
@@ -781,6 +781,15 @@ const char *
dav_svn__get_root_dir(request_rec *r)
{
dir_conf_t *conf;
+ const char *base;
+
Review Comment:
Any particular reason why base isn't declared within the #if block?
If compiled with < 20211221.28, there is a compiler warning about an unused
variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@subversion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
